Message ID | 20181104041209.23028-5-ricardo.martincoski@gmail.com |
---|---|
State | Accepted |
Headers | show
Return-Path: <buildroot-bounces@busybox.net> X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=busybox.net (client-ip=140.211.166.137; helo=fraxinus.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=<UNKNOWN>) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="UIAjo284"; dkim-atps=neutral Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 42nj8d08gnzB4jw for <incoming-buildroot@patchwork.ozlabs.org>; Sun, 4 Nov 2018 15:13:05 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 96EE281A24; Sun, 4 Nov 2018 04:13:03 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org X-Amavis-Alert: BAD HEADER SECTION, Duplicate header field: "References" Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id BUxZk-j12VWV; Sun, 4 Nov 2018 04:13:03 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by fraxinus.osuosl.org (Postfix) with ESMTP id E82C8861C7; Sun, 4 Nov 2018 04:13:02 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id 98C661BF589 for <buildroot@lists.busybox.net>; Sun, 4 Nov 2018 04:13:00 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 9581286132 for <buildroot@lists.busybox.net>; Sun, 4 Nov 2018 04:13:00 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org X-Amavis-Alert: BAD HEADER SECTION, Duplicate header field: "References" Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id HEHOvM7EBk_z for <buildroot@lists.busybox.net>; Sun, 4 Nov 2018 04:12:59 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-qk1-f194.google.com (mail-qk1-f194.google.com [209.85.222.194]) by fraxinus.osuosl.org (Postfix) with ESMTPS id 601BE861D7 for <buildroot@buildroot.org>; Sun, 4 Nov 2018 04:12:59 +0000 (UTC) Received: by mail-qk1-f194.google.com with SMTP id d19so9550575qkg.5 for <buildroot@buildroot.org>; Sat, 03 Nov 2018 21:12:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=3y6DwB0U71dWrTt3woTzyb+UcT8C6+BHuktM+Nn1yDM=; b=UIAjo284pMY6i3GtrK4xPoidfY9IyXYH0l8WWuHX7c93BtM/fO8olysV5g7Llk+RLH Dxy6HhjkytWLMhDECaX02L5mD4hLpdGbO5FyLwVAvIDEk0CnO2MJW0yctraUvVj6E1ez Tjh8rSzOY6x3hqQySTohfYY3zSVJdeHKajfC4Y+G6GMqGxCBD3DFJ+DY8c3db99a4Maf X5e9znVMY/VloQu0wielyZbFhX8cfGFHvcIPoX7Se4kjozuT6UxkwO+g62QdiGaIue+3 RDgzhDTdov79A1Lo1qSq4ThcvCO2NSNm4Wv4gPkCHF9mMGt1Iq2oXCZ09Dz1WiMnOcmc TpoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=3y6DwB0U71dWrTt3woTzyb+UcT8C6+BHuktM+Nn1yDM=; b=IeiURLbd89/TRd48Y/mPHQdKI8AX6ZeeMyVP9ZL0ver2MwC2cMllKmL+Bhv9BA/wyb n2D0fJw/Knmr/vvVXxmwRYoYlSU/tBiiLeuP3mMPrRv4NdIuRVuJaB/q899y2ywldySc hZ4mGXKvj8EuDU3lDlxfUqrPBLUYT3Gf2UiaouDWYSaj1XlVGMpOHCdWPCFVId+GT+4z v5NX7ZY+z99ieWJ8zm5mwzevUWx/YYDvIrsXiznZFvEO/WIugNE5ZkAip/MT7Wr8fQaY YJgfEvmAXM/qvmNGIYHURi1gpml3v6EjdrxgDKpSAcuIuk9aGIn86qExS8OLB+sRdY5T Ky7Q== X-Gm-Message-State: AGRZ1gItJvdQ4oWQ+0JbnP14gs7jy2HbEgIR/sydB+B6Xb87wnmJuRe+ 7Zo/uF4SXCx3cX4E1YVQ4IX64E8q X-Google-Smtp-Source: AJdET5ez0KLs/nvHzNmBCUlS3qLsSpj3laNI6UoKf7cv7bMwxQSdOCHhn6+XykS7/JPrNP5Zc2vn/Q== X-Received: by 2002:ae9:e901:: with SMTP id x1mr15078121qkf.332.1541304778365; Sat, 03 Nov 2018 21:12:58 -0700 (PDT) Received: from ultri5.home ([177.18.158.192]) by smtp.gmail.com with ESMTPSA id 35-v6sm25625076qtr.91.2018.11.03.21.12.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 03 Nov 2018 21:12:57 -0700 (PDT) From: Ricardo Martincoski <ricardo.martincoski@gmail.com> To: buildroot@buildroot.org Date: Sun, 4 Nov 2018 02:12:08 -0200 Message-Id: <20181104041209.23028-5-ricardo.martincoski@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20181104041209.23028-1-ricardo.martincoski@gmail.com> References: <20181104041209.23028-1-ricardo.martincoski@gmail.com> In-Reply-To: <20181103045624.31059-1-ricardo.martincoski@gmail.com> References: <20181103045624.31059-1-ricardo.martincoski@gmail.com> Subject: [Buildroot] [PATCH v2 4/5] check-package: ignore external.mk X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot <buildroot.busybox.net> List-Unsubscribe: <http://lists.busybox.net/mailman/options/buildroot>, <mailto:buildroot-request@busybox.net?subject=unsubscribe> List-Archive: <http://lists.busybox.net/pipermail/buildroot/> List-Post: <mailto:buildroot@busybox.net> List-Help: <mailto:buildroot-request@busybox.net?subject=help> List-Subscribe: <http://lists.busybox.net/mailman/listinfo/buildroot>, <mailto:buildroot-request@busybox.net?subject=subscribe> Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>, Ricardo Martincoski <ricardo.martincoski@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" <buildroot-bounces@busybox.net> |
Series | Fix bug 11271 and add test for check-package | expand |
diff --git a/utils/check-package b/utils/check-package index 3dbc28b0a2..3969ec3ec7 100755 --- a/utils/check-package +++ b/utils/check-package @@ -71,6 +71,9 @@ def get_lib_from_filename(fname): return None if DO_NOT_CHECK_INTREE.match(fname): return None + else: + if os.path.basename(fname) == "external.mk" and os.path.exists(fname[:-2] + "desc"): + return None if CONFIG_IN_FILENAME.search(fname): return checkpackagelib.lib_config if fname.endswith(".hash"):
The external.mk file in a br2-external usually contains raw makefile targets. This file is common code and not a package recipe so it should not be tested against the code-style of a package .mk file. When using this script to check files in a br2-external tree, usually the user is responsible for not passing files that check-package do not understand. But external.mk is special because it is part of the br2-external structure, so it is likely someone expects it to be checkable by an in-tree script. Instead of adding another blob to the manual, just ignore this file. Only do that when a br2-external is being tested (so with option -b passed to the script) and also check that it is on the root path of the br2-external to allow someone to have a package called external. Reported on bug #11271. Reported-by: Vitaliy Lotorev <lotorev@gmail.com> Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com> Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com> --- Changes v1 -> v2: - no changes --- utils/check-package | 3 +++ 1 file changed, 3 insertions(+)