From patchwork Sat Nov 3 22:16:07 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steve French X-Patchwork-Id: 992685 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-cifs-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="JVcqr/+5"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 42nYF24dN9zB4hC for ; Sun, 4 Nov 2018 09:16:22 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727016AbeKDH24 (ORCPT ); Sun, 4 Nov 2018 02:28:56 -0500 Received: from mail-pf1-f196.google.com ([209.85.210.196]:34507 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726727AbeKDH24 (ORCPT ); Sun, 4 Nov 2018 02:28:56 -0500 Received: by mail-pf1-f196.google.com with SMTP id y18-v6so229998pfn.1 for ; Sat, 03 Nov 2018 15:16:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=qtiP1or++mgI6x4aA5iM5za8yHoMz2DYHxRI6Xe9BHc=; b=JVcqr/+5mdBTBddgikn/oPHu1RTZhgxZ4e9HzUbE+dSG46o8p6ggPAeMCXZFop29vy nsTmGzNxvRX5+eK4cT9h57VdahD+WVUzgDGzZZa8Z73/ouRJw/rgOeLAS+Ikh+nT+m9B SDBPjj765o2OxrAyA4t93OdAI7cIKWJ5hjuZxztZNfAjSA1IVhF3ldYshewQUkc4E5Wg O6vklJtu6sOUzcw3XT8IQhVp6MZaNCO0COEOaxkAxTpUbytUBwCqRZEoA0EMUhVdNsBv 6YP8Iiz6JKddq+N+T5gTHNb1DZGQL9YyDu/HMb3hoiLn2Uj7QhE3dOBiLPyjCxEziNsm J34A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=qtiP1or++mgI6x4aA5iM5za8yHoMz2DYHxRI6Xe9BHc=; b=mDw7+tULrfCCX7FbnG3q2T8ZqdTIyELQUa8WCXyy1STOZkhkWi2lzuiDS+nXXDN/uZ bOtIwP1ES8S7Ef2/0el/Iia9IbjetgxE+V+mp6k8ZhyfXIaamm3N7ywfP/VH+RtDnuNI 6zdzTdkAJfEjuW2GLMLKi8ZovtfkRD7qjyx7yzIGmADMN9pYauuimGiHXgCrQhtZQaG6 NLNVO9ecVKIOD9fOjsYnyIGRCrxLcWbnARJQ6orJG944ypYpAJ0RhqbmsFPD72SPk98o +QqaJm1dDQU3227Xgbhd2lW31tCui0+P3G8gYV+pSuDawsrodBz5ZxF3/2HqyqEd0rWz aoXA== X-Gm-Message-State: AGRZ1gJyqHCaKWLc+NOpviJTy0JE8Wi2m0/m6ild2ozTkP+JaqhRYhht ua/Y6u6v4OM4rj0K+7OYYJ0lnXdVT9OUxENNJAiBw981 X-Google-Smtp-Source: AJdET5ddpkLnGZyKg1kKVDE9z3Tl904FWiIhLsvqbZbeaVxSkEGekZVjaBdUJctAtvRcJnnbYWdmgQe/DwKJh1VCYOQ= X-Received: by 2002:a65:6684:: with SMTP id b4mr15427426pgw.55.1541283379684; Sat, 03 Nov 2018 15:16:19 -0700 (PDT) MIME-Version: 1.0 From: Steve French Date: Sat, 3 Nov 2018 17:16:07 -0500 Message-ID: Subject: [PATCH] cifs: In Kconfig CONFIG_CIFS_POSIX needs depends on legacy (insecure cifs) To: CIFS Sender: linux-cifs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-cifs@vger.kernel.org Missing a dependency. Shouldn't show cifs posix extensions in Kconfig if CONFIG_CIFS_ALLOW_INSECURE_DIALECTS (ie SMB1 protocol) is disabled. Signed-off-by: Steve French --- fs/cifs/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) From 58358877002760b327528729855421e55b96a77f Mon Sep 17 00:00:00 2001 From: Steve French Date: Sat, 3 Nov 2018 15:02:44 -0500 Subject: [PATCH] cifs: In Kconfig CONFIG_CIFS_POSIX needs depends on legacy (insecure cifs) Missing a dependency. Shouldn't show cifs posix extensions in Kconfig if CONFIG_CIFS_ALLOW_INSECURE_DIALECTS (ie SMB1 protocol) is disabled. Signed-off-by: Steve French --- fs/cifs/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/cifs/Kconfig b/fs/cifs/Kconfig index abcd78e332fe..85dadb93c992 100644 --- a/fs/cifs/Kconfig +++ b/fs/cifs/Kconfig @@ -133,7 +133,7 @@ config CIFS_XATTR config CIFS_POSIX bool "CIFS POSIX Extensions" - depends on CIFS_XATTR + depends on CIFS && CIFS_ALLOW_INSECURE_LEGACY && CIFS_XATTR help Enabling this option will cause the cifs client to attempt to negotiate a newer dialect with servers, such as Samba 3.0.5 -- 2.17.1