From patchwork Fri Nov 2 09:12:58 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dong Aisheng X-Patchwork-Id: 992227 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-gpio-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.b="A6J8Eo1t"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 42mbvh6DkpzB4V0 for ; Fri, 2 Nov 2018 20:13:04 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726227AbeKBSTd (ORCPT ); Fri, 2 Nov 2018 14:19:33 -0400 Received: from mail-eopbgr40083.outbound.protection.outlook.com ([40.107.4.83]:3507 "EHLO EUR03-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726030AbeKBSTd (ORCPT ); Fri, 2 Nov 2018 14:19:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Bs96e4IIfzkF1qpC229XAOATQR5wRQMEOEJ+G+krhjs=; b=A6J8Eo1toMp1iKOX+Wp6I3sl2ucTH2f9T6XG5IzPpn8jdeSdzPnYPLTmdu1Q8t4Q9aTmk7X3dx2QwWiEdG5xuY125YUaiuGlGCnhP0PKwJcbnB1mf1nmwXiGPffu1TBN5jNk/DjuJWMz54CTqTlL5E/CSFREKnQXmOoNsZCvLSw= Received: from AM0PR04MB4211.eurprd04.prod.outlook.com (52.134.126.21) by AM0PR04MB4113.eurprd04.prod.outlook.com (52.134.125.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1294.26; Fri, 2 Nov 2018 09:12:58 +0000 Received: from AM0PR04MB4211.eurprd04.prod.outlook.com ([fe80::797a:f972:9281:6d10]) by AM0PR04MB4211.eurprd04.prod.outlook.com ([fe80::797a:f972:9281:6d10%2]) with mapi id 15.20.1294.024; Fri, 2 Nov 2018 09:12:58 +0000 From: "A.s. Dong" To: "linux-arm-kernel@lists.infradead.org" CC: "dongas86@gmail.com" , "kernel@pengutronix.de" , "shawnguo@kernel.org" , Fabio Estevam , "robh+dt@kernel.org" , dl-linux-imx , "linux@armlinux.org.uk" , "A.s. Dong" , Linus Walleij , Stefan Agner , "linux-gpio@vger.kernel.org" , "devicetree@vger.kernel.org" Subject: [PATCH V4 05/10] dt-bindings: pinctrl: imx7ulp: back to imx legacy binding for consistency Thread-Topic: [PATCH V4 05/10] dt-bindings: pinctrl: imx7ulp: back to imx legacy binding for consistency Thread-Index: AQHUcow/fq0Prpq5nUKLG5MJPXYPrg== Date: Fri, 2 Nov 2018 09:12:58 +0000 Message-ID: <1541149669-10857-6-git-send-email-aisheng.dong@nxp.com> References: <1541149669-10857-1-git-send-email-aisheng.dong@nxp.com> In-Reply-To: <1541149669-10857-1-git-send-email-aisheng.dong@nxp.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: git-send-email 2.7.4 x-clientproxiedby: HK0PR04CA0024.apcprd04.prod.outlook.com (2603:1096:203:36::36) To AM0PR04MB4211.eurprd04.prod.outlook.com (2603:10a6:208:66::21) authentication-results: spf=none (sender IP is ) smtp.mailfrom=aisheng.dong@nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [119.31.174.66] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM0PR04MB4113; 6:xazeQSP4SSBxC4TF/iIScEB3okTi8u3Ro5BnVJ7oQ7eASqsmZl6VDf0xfi0bQoCZ2ixepl2pd8Xkg3LZW1+JBjTBncudcebSf8x0PrTdh7rtg+BNsRsQm7xbqURtOll5QofbYhKznobXDzEJrVMTSQjuWjRw5ypz4lz9t4uOwHimFNiosGqTSyElbTddtFrhzdH8lKXzyI2FdFPCDpUqb6jbcHm3nATIgUcEnGEwtHbEiJO9VdsikW7R32daawOxGDQ8b1Q9JwDnh29n+3jsvUOJQQipm/Ug83w74njcdLSbTSSQ/Cgk2lSiYsHPgib9GCRUby5ocRfaebu9ts96icGR8sPQv3+8HuAqea2wHak/VkGOl7JGHyne2+mvRMjelglt19pxMF4AGVLVfsnfJO4hXEiUgOeJDq2+X1pbE3ZI/MRD1gKt8XBPSGOQSuhtQcnvz1dJfFUt6WJyilLVlA==; 5:PoS6jt03fFLxGoGofjiRcUPl5Vp6LDD0mG9DJVGUe5JCiJMBTEtBIjRHUNCSDZnlfKbtiLsBQ5lMBkxWzdc+4j5Fxe7vp05+E/VK7vpd+IK5+GdDN8syw1dcXrdwvYuTaYSRwd/ogDrbQZbcaJ+JAxA2ZHJU2XVp2lV7aQV6w5w=; 7:5CtfHvBAo+Ehc3xuvwmGLhJc/rDx9E8E0O0jp092kPAJJ/y9POyW98ce2SZlbme044zTsPTX9BgoNkbMNiCC6tAkPzUsS7avEjUC2RJh8Ke6Pvot37pWUr2a3GM6EDmW5NLjU9SOuQQuJnbVhOvUWg== x-ms-office365-filtering-correlation-id: 98bdc999-0a79-49e0-6bff-08d640a361c4 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:AM0PR04MB4113; x-ms-traffictypediagnostic: AM0PR04MB4113: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(9452136761055)(269456686620040)(185117386973197); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(93006095)(93001095)(10201501046)(3002001)(3231382)(944501410)(52105095)(6055026)(148016)(149066)(150057)(6041310)(20161123558120)(20161123564045)(20161123560045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(201708071742011)(7699051)(76991095); SRVR:AM0PR04MB4113; BCL:0; PCL:0; RULEID:; SRVR:AM0PR04MB4113; x-forefront-prvs: 08444C7C87 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39860400002)(346002)(136003)(366004)(376002)(396003)(189003)(199004)(54534003)(8676002)(53936002)(11346002)(446003)(68736007)(86362001)(575784001)(14444005)(99286004)(81156014)(256004)(81166006)(6436002)(106356001)(2351001)(186003)(5640700003)(2906002)(7736002)(386003)(6506007)(6116002)(102836004)(478600001)(3846002)(305945005)(6486002)(76176011)(52116002)(6512007)(4326008)(6916009)(66066001)(105586002)(2900100001)(36756003)(26005)(25786009)(71190400001)(50226002)(5660300001)(316002)(97736004)(54906003)(2501003)(14454004)(8936002)(486006)(71200400001)(7416002)(39060400002)(2616005)(476003); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR04MB4113; H:AM0PR04MB4211.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: fxKh4HV2hNFCzPduWhd91q1dY+3Yp1F47C5VLsKisfcbw2lmAsaPjHuhjq+r503tiYSSubWBICbNrygv+dGpYC2hIMU7Xwd3mGphNbzY1eLmE4nTMzEHEagjAeGgevhfo7JlX8oEllhtrGfuH8XqdkmeWjIjUVLAAaSQzFEY1ISwlBZe4F+jG2jdXiyPwlRTOihAOH7lLPf9x6Y1MwGaBLRZiGEsMbiibbB3BfDV2fSVsFQE51NRaxj0cJ89NwvkbVaDlk75Tuuj+1/CsYCborl9k5AU2IRV23m2fu/vJJoVIGz7khm+RTWgXW5F2x70uNr6BKSsEEzHnqUAoQ5bLKk2p37ZofD08hFpb4zwhfg= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 98bdc999-0a79-49e0-6bff-08d640a361c4 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Nov 2018 09:12:58.7846 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB4113 Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org We already had an earlier conclusion that all new i.MX Socs will keep using the legacy i.MX Pinctrl bindings instead of generic pin config. However, MX7ULP generic pin config binding support has already been in tree before that time. Per SoC maintainers' suggestions, in order to get a better consistency for all i.MX devices, we'd like to go back to imx legacy binding for MX7ULP as well. Cc: Rob Herring Cc: Linus Walleij Cc: Shawn Guo Cc: Stefan Agner Cc: Sascha Hauer Cc: Fabio Estevam Cc: linux-gpio@vger.kernel.org Cc: devicetree@vger.kernel.org Signed-off-by: Dong Aisheng Acked-by: Fabio Estevam Reviewed-by: Rob Herring --- ChangeLog: v3: new patch --- .../bindings/pinctrl/fsl,imx7ulp-pinctrl.txt | 66 ++++++++++------------ 1 file changed, 29 insertions(+), 37 deletions(-) diff --git a/Documentation/devicetree/bindings/pinctrl/fsl,imx7ulp-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/fsl,imx7ulp-pinctrl.txt index 44ad670a..bfa3703 100644 --- a/Documentation/devicetree/bindings/pinctrl/fsl,imx7ulp-pinctrl.txt +++ b/Documentation/devicetree/bindings/pinctrl/fsl,imx7ulp-pinctrl.txt @@ -7,55 +7,47 @@ Note: This binding doc is only for the IOMUXC1 support in A7 Domain and it only supports generic pin config. -Please also refer pinctrl-bindings.txt in this directory for generic pinctrl -binding. - -=== Pin Controller Node === +Please refer to fsl,imx-pinctrl.txt in this directory for common binding +part and usage. Required properties: -- compatible: "fsl,imx7ulp-iomuxc1" -- reg: Should contain the base physical address and size of the iomuxc - registers. - -=== Pin Configuration Node === -- pinmux: One integers array, represents a group of pins mux setting. - The format is pinmux = , PIN_FUNC_ID is a pin working on - a specific function. - - NOTE: i.MX7ULP PIN_FUNC_ID consists of 4 integers as it shares one mux - and config register as follows: - - - Refer to imx7ulp-pinfunc.h in in device tree source folder for all - available imx7ulp PIN_FUNC_ID. - -Optional Properties: -- drive-strength Integer. Controls Drive Strength - 0: Standard - 1: Hi Driver -- drive-push-pull Bool. Enable Pin Push-pull -- drive-open-drain Bool. Enable Pin Open-drian -- slew-rate: Integer. Controls Slew Rate - 0: Standard - 1: Slow -- bias-disable: Bool. Pull disabled -- bias-pull-down: Bool. Pull down on pin -- bias-pull-up: Bool. Pull up on pin +- compatible: "fsl,imx7ulp-iomuxc1". +- fsl,pins: Each entry consists of 5 integers which represents the mux + and config setting for one pin. The first 4 integers + are specified + using a PIN_FUNC_ID macro, which can be found in + imx7ulp-pinfunc.h in the device tree source folder. + The last integer CONFIG is the pad setting value like + pull-up on this pin. + + Please refer to i.MX7ULP Reference Manual for detailed + CONFIG settings. + +CONFIG bits definition: +PAD_CTL_OBE (1 << 17) +PAD_CTL_IBE (1 << 16) +PAD_CTL_LK (1 << 16) +PAD_CTL_DSE_HI (1 << 6) +PAD_CTL_DSE_STD (0 << 6) +PAD_CTL_ODE (1 << 5) +PAD_CTL_PUSH_PULL (0 << 5) +PAD_CTL_SRE_SLOW (1 << 2) +PAD_CTL_SRE_STD (0 << 2) +PAD_CTL_PE (1 << 0) Examples: #include "imx7ulp-pinfunc.h" /* Pin Controller Node */ -iomuxc1: iomuxc@40ac0000 { +iomuxc1: pinctrl@40ac0000 { compatible = "fsl,imx7ulp-iomuxc1"; reg = <0x40ac0000 0x1000>; /* Pin Configuration Node */ pinctrl_lpuart4: lpuart4grp { - pinmux = < - IMX7ULP_PAD_PTC3__LPUART4_RX - IMX7ULP_PAD_PTC2__LPUART4_TX + fsl,pins = < + IMX7ULP_PAD_PTC3__LPUART4_RX 0x1 + IMX7ULP_PAD_PTC2__LPUART4_TX 0x1 >; - bias-pull-up; }; };