From patchwork Thu Nov 1 15:06:31 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ben Pfaff X-Patchwork-Id: 991962 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=openvswitch.org (client-ip=140.211.169.12; helo=mail.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=ovn.org Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 42m7pD6VdFzB4XH for ; Fri, 2 Nov 2018 02:06:44 +1100 (AEDT) Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id 3499FAA6; Thu, 1 Nov 2018 15:06:41 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id D4626A6E for ; Thu, 1 Nov 2018 15:06:39 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [217.70.183.194]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 2064475B for ; Thu, 1 Nov 2018 15:06:38 +0000 (UTC) X-Originating-IP: 75.54.222.30 Received: from sigabrt.attlocal.net (75-54-222-30.lightspeed.rdcyca.sbcglobal.net [75.54.222.30]) (Authenticated sender: blp@ovn.org) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 89FC940006; Thu, 1 Nov 2018 15:06:36 +0000 (UTC) From: Ben Pfaff To: dev@openvswitch.org Date: Thu, 1 Nov 2018 08:06:31 -0700 Message-Id: <20181101150632.32493-1-blp@ovn.org> X-Mailer: git-send-email 2.16.1 X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org Cc: Ben Pfaff Subject: [ovs-dev] [PATCH 1/2] checkpatch: Add explicit test for mailing list as author. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org Somehow some such patches snuck through. checkpatch caught them (and the committer missed that) but this makes it even more explicit. Signed-off-by: Ben Pfaff Reviewed-by: Yifeng Sun --- tests/checkpatch.at | 8 ++++++++ utilities/checkpatch.py | 3 +++ 2 files changed, 11 insertions(+) diff --git a/tests/checkpatch.at b/tests/checkpatch.at index 8af3a8c0371e..bd7422494e33 100755 --- a/tests/checkpatch.at +++ b/tests/checkpatch.at @@ -51,6 +51,14 @@ try_checkpatch \ Commit: A" \ "ERROR: Author A needs to sign off." +# Single author but somehow the mailing list is the author. +try_checkpatch \ + "Author: Foo Bar via dev + Commit: A + + Signed-off-by: A" \ + "ERROR: Author should not be mailing list." + # Sign-off for single author and different committer. try_checkpatch \ "Author: A diff --git a/utilities/checkpatch.py b/utilities/checkpatch.py index 5f5dd8318e32..54aa4b6346db 100755 --- a/utilities/checkpatch.py +++ b/utilities/checkpatch.py @@ -731,6 +731,9 @@ def ovs_checkpatch_parse(text, filename, author=None, committer=None): if not author: print_error("Patch lacks author.") continue + if " via " in author or "@openvswitch.org" in author: + print_error("Author should not be mailing list.") + continue if author in co_authors: print_error("Author should not be also be co-author.") continue