[6/6] dma: tegra: add tracepoint for residual update

Message ID 20181031160309.20408-7-ben.dooks@codethink.co.uk
State New
Headers show
Series
  • [1/6] dma: tegra: avoid overflow of byte tracking
Related show

Commit Message

Ben Dooks Oct. 31, 2018, 4:03 p.m.
Add a tracepoint in the residual update instead of using dev_dbg()
to allow debugging via the trace pipe.

Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
Fixes since v1:
- copy the devname instead of referencing the dmachan device

Cc: Ingo Molnar <mingo@redhat.com> (maintainer:TRACING)
Cc: Steven Rostedt <rostedt@goodmis.org> (maintainer:TRACING)
---
 drivers/dma/tegra20-apb-dma.c        |  5 ++---
 include/trace/events/tegra_apb_dma.h | 27 +++++++++++++++++++++++++++
 2 files changed, 29 insertions(+), 3 deletions(-)

Patch

diff --git a/drivers/dma/tegra20-apb-dma.c b/drivers/dma/tegra20-apb-dma.c
index 22114c9a6e98..211efea67db6 100644
--- a/drivers/dma/tegra20-apb-dma.c
+++ b/drivers/dma/tegra20-apb-dma.c
@@ -886,9 +886,8 @@  static unsigned int tegra_dma_update_residual(struct tegra_dma_channel *tdc,
 	}
 
 done:	
-	dev_dbg(tdc2dev(tdc), "residual: req %08lx, ahb@%08lx, wcount %08lx, done %d\n",
-		 sg_req->ch_regs.ahb_ptr, ahbptr, wcount, done);
-
+	trace_tegra_dma_tx_state(&tdc->dma_chan, ahbptr, status, result,
+				 tmp, residual);
 	return result;
 }
 
diff --git a/include/trace/events/tegra_apb_dma.h b/include/trace/events/tegra_apb_dma.h
index 1f55c2c6049d..8fa0f0974828 100644
--- a/include/trace/events/tegra_apb_dma.h
+++ b/include/trace/events/tegra_apb_dma.h
@@ -41,6 +41,33 @@  TRACE_EVENT(tegra_dma_complete_cb,
 		  __get_str(chan), __entry->count, __entry->ptr)
 );
 
+TRACE_EVENT(tegra_dma_tx_state,
+	TP_PROTO(struct dma_chan *dc, unsigned long ahb,
+		 unsigned long wc, unsigned int done,
+		 unsigned long byte_count, unsigned int residual),
+	TP_ARGS(dc, ahb, wc, done, byte_count, residual),
+	TP_STRUCT__entry(
+		__string(chan,	16)
+		__field(unsigned long,	ahb)
+		__field(unsigned long,	wc)
+		__field(unsigned long,	done)
+		__field(unsigned int,	residual)
+		 __field(unsigned long,	byte_count)
+	),
+	TP_fast_assign(
+		__assign_str(chan, dev_name(&dc->dev->device));
+		__entry->ahb = ahb;
+		__entry->wc = wc;
+		__entry->done = done;
+		__entry->residual = residual;
+		__entry->byte_count = byte_count;
+	),
+	TP_printk("%s: txresidual: ahb %08lx wc %08lx => done %lu bc %lu residual %u",
+		  __get_str(chan),
+		  __entry->ahb, __entry->wc, __entry->done,
+		  __entry->byte_count, __entry->residual)
+);
+
 TRACE_EVENT(tegra_dma_isr,
 	TP_PROTO(struct dma_chan *dc, int irq),
 	TP_ARGS(dc, irq),