From patchwork Tue Oct 30 20:47:25 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yi-Hung Wei X-Patchwork-Id: 991065 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=openvswitch.org (client-ip=140.211.169.12; helo=mail.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Fi4m7pcA"; dkim-atps=neutral Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 42l3c86skVz9s9m for ; Wed, 31 Oct 2018 07:54:15 +1100 (AEDT) Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id DB4993938; Tue, 30 Oct 2018 20:52:35 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 8CEFC37FA for ; Tue, 30 Oct 2018 20:52:11 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.7.6 Received: from mail-pf1-f193.google.com (mail-pf1-f193.google.com [209.85.210.193]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 03B177F7 for ; Tue, 30 Oct 2018 20:52:10 +0000 (UTC) Received: by mail-pf1-f193.google.com with SMTP id j13-v6so2959080pff.11 for ; Tue, 30 Oct 2018 13:52:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=rDDf4XVJSx+Iwpgcx88JAugE9jfXCnpd5C9ANiTq3nk=; b=Fi4m7pcADgHjRwngizxkPsOUz+cP5mcXvu3/zRRjrnXYXKuxxrZVtieGMK2tQPc5FP eg+fNAede3dfDT1Yr5DB8e9GrQV/8bSi0ms2tfC1ULcoLr6KUCT91qqGJEoPMrnGz+tY QyRwUW6KdD64qGRoy1PpmBj4oieN0ykOboPmGYkvGpzdncrPeMzKZyXvOGychGh0bbrj v39eSMhuitDubOILL4ckCKSdqUxcQhQYsnx2cBGy9BwXoPB9BHyNVw7XSlu7MBON9OWU ghIv6a4sP+zGUPzdcVeo5QIZKbes2xJMqCevuAW/SycuNyopwiDN3KEO8cOk6du2N/by NSqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=rDDf4XVJSx+Iwpgcx88JAugE9jfXCnpd5C9ANiTq3nk=; b=mqVxXSoA9wzmWUhM3d82UYebvlF3eLlwS+aID8T2B4PcIvHNISzGI3RL8SIngKcwpF mX7U8PB7jbSaRjG/DBrWDo9uJXB18aVNQR4owv3MRjavWnKRxABJo7ZYJa6Pex1n5Xnm FY5bqoHcLt3MDrgFM5kbZWvGcb7LG/cpfTTkmMj5LP1eUvfB9pWme5lt3QESwNFVL6GT 95OdEFqTO2UofH1D3lm/y3U76NbK/2Z81DtBizECxN0Zk6peOB3Sg38fSSbmfyXVd3rf yP30XH6v7oOiNy02koaRvKsinDPazhBjnGeWqCLF1Hs4Fwd5t4FON92WMBEI9gg5nGbk 8plA== X-Gm-Message-State: AGRZ1gLXSTyTkmL6TxmjIVwrtZejzY4icVtIPwjC1lloT9c4msIMYeWR DeddrGMHKzTFSsHsP+x8Yj2hFswz X-Google-Smtp-Source: AJdET5c628VHfjqHqeQ17Ldlrn525srtMCnFJRkF8+W1JZU3PsYw/Rws85APUqn+vh5O8Lygm6zN3w== X-Received: by 2002:a63:9409:: with SMTP id m9-v6mr246497pge.93.1540932729923; Tue, 30 Oct 2018 13:52:09 -0700 (PDT) Received: from Husky.eng.vmware.com ([66.170.99.1]) by smtp.gmail.com with ESMTPSA id a11-v6sm5801954pff.8.2018.10.30.13.52.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 30 Oct 2018 13:52:08 -0700 (PDT) From: Yi-Hung Wei To: dev@openvswitch.org Date: Tue, 30 Oct 2018 13:47:25 -0700 Message-Id: <1540932445-4832-1-git-send-email-yihung.wei@gmail.com> X-Mailer: git-send-email 2.7.4 X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org Subject: [ovs-dev] [PATCH] ovs-lib.in: Remove unnecessary conntrack flush X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org We introduced flush-conntrack in force-reload-kmod script by commit 8bea39b186ca ("datapath: Prevent panic") to prevent kernel panic. It turns out that the kernel panic is actually triggered by the IPv4 secret timer, and it is fixed by commit 121905984724 ("compat: Initialize IPv4 reassembly secret timer"). This commit removes the unnecessary conntrack flush in the script. Signed-off-by: Yi-Hung Wei CC: Greg Rose Reviewed-by: Greg Rose --- utilities/ovs-lib.in | 3 --- 1 file changed, 3 deletions(-) diff --git a/utilities/ovs-lib.in b/utilities/ovs-lib.in index f6b539317a30..7df672c2c7bc 100644 --- a/utilities/ovs-lib.in +++ b/utilities/ovs-lib.in @@ -608,9 +608,6 @@ force_reload_kmod () { stop_ovsdb start_ovsdb || return 1 - if [ -n "$(ovs-dpctl show)" ]; then - action "Flush old conntrack entries" ovs-appctl dpctl/flush-conntrack - fi stop_forwarding if action "Saving interface configuration" save_interfaces; then