PR libstdc++/87809 avoid invalid expressions in exception specifications

Message ID	20181030145027.GA13646@redhat.com
State	New
Headers	show Return-Path: <gcc-patches-return-488609-incoming=patchwork.ozlabs.org@gcc.gnu.org> DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:subject:message-id:mime-version:content-type; q=dns; s= default; b=EYdz45h3x2cb8LJsmAspkVrzDkrfFmpFoIIpV/Dk8bTr6GvH/3D1g aSgKyuRvNlEWBIvl6AKro0LWDsboc2D4qB+CEHX/vBQCvTAKp1az1i2s74uSbUdN JiCdzae5uE/IdK6SiUqNArz3VHrvvE9um7hlKxmcoGJFN2eD6i4ODw= Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk Sender: gcc-patches-owner@gcc.gnu.org Date: Tue, 30 Oct 2018 14:50:27 +0000 From: Jonathan Wakely <jwakely@redhat.com> To: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org Subject: [PATCH] PR libstdc++/87809 avoid invalid expressions in exception specifications Message-ID: <20181030145027.GA13646@redhat.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="yrj/dFKFPuw6o+aM" Content-Disposition: inline User-Agent: Mutt/1.9.2 (2017-12-15)
Series	PR libstdc++/87809 avoid invalid expressions in exception specifications \| expand PR libstdc++/87809 avoid invalid expressions in exception specifications

diff --git a/libstdc++-v3/include/bits/forward_list.h b/libstdc++-v3/include/bits/forward_list.h index ebec3b5c818..1d01a54721b 100644 --- a/libstdc++-v3/include/bits/forward_list.h +++ b/libstdc++-v3/include/bits/forward_list.h @@ -293,7 +293,7 @@ _GLIBCXX_BEGIN_NAMESPACE_CONTAINER _Fwd_list_node_base _M_head; _Fwd_list_impl() - noexcept( noexcept(_Node_alloc_type()) ) + noexcept(is_nothrow_default_constructible<_Node_alloc_type>::value) : _Node_alloc_type(), _M_head() { } diff --git a/libstdc++-v3/include/bits/stl_bvector.h b/libstdc++-v3/include/bits/stl_bvector.h index 19c16839cfa..3752897272f 100644 --- a/libstdc++-v3/include/bits/stl_bvector.h +++ b/libstdc++-v3/include/bits/stl_bvector.h @@ -473,8 +473,8 @@ _GLIBCXX_BEGIN_NAMESPACE_CONTAINER : public _Bit_alloc_type, public _Bvector_impl_data { public: - _Bvector_impl() - _GLIBCXX_NOEXCEPT_IF( noexcept(_Bit_alloc_type()) ) + _Bvector_impl() _GLIBCXX_NOEXCEPT_IF( + is_nothrow_default_constructible<_Bit_alloc_type>::value) : _Bit_alloc_type() { } diff --git a/libstdc++-v3/include/bits/stl_list.h b/libstdc++-v3/include/bits/stl_list.h index 3544981698c..cb8aa88d548 100644 --- a/libstdc++-v3/include/bits/stl_list.h +++ b/libstdc++-v3/include/bits/stl_list.h @@ -372,7 +372,8 @@ _GLIBCXX_BEGIN_NAMESPACE_CXX11 { __detail::_List_node_header _M_node; - _List_impl() _GLIBCXX_NOEXCEPT_IF( noexcept(_Node_alloc_type()) ) + _List_impl() _GLIBCXX_NOEXCEPT_IF( + is_nothrow_default_constructible<_Node_alloc_type>::value) : _Node_alloc_type() { } diff --git a/libstdc++-v3/include/bits/stl_vector.h b/libstdc++-v3/include/bits/stl_vector.h index 40debd62396..05f9b7ef6c3 100644 --- a/libstdc++-v3/include/bits/stl_vector.h +++ b/libstdc++-v3/include/bits/stl_vector.h @@ -125,7 +125,8 @@ _GLIBCXX_BEGIN_NAMESPACE_CONTAINER struct _Vector_impl : public _Tp_alloc_type, public _Vector_impl_data { - _Vector_impl() _GLIBCXX_NOEXCEPT_IF( noexcept(_Tp_alloc_type()) ) + _Vector_impl() _GLIBCXX_NOEXCEPT_IF( + is_nothrow_default_constructible<_Tp_alloc_type>::value) : _Tp_alloc_type() { } diff --git a/libstdc++-v3/testsuite/23_containers/forward_list/cons/87809.cc b/libstdc++-v3/testsuite/23_containers/forward_list/cons/87809.cc new file mode 100644 index 00000000000..cde9dfff3e0 --- /dev/null +++ b/libstdc++-v3/testsuite/23_containers/forward_list/cons/87809.cc @@ -0,0 +1,42 @@ +// Copyright (C) 2018 Free Software Foundation, Inc. +// +// This file is part of the GNU ISO C++ Library. This library is free +// software; you can redistribute it and/or modify it under the +// terms of the GNU General Public License as published by the +// Free Software Foundation; either version 3, or (at your option) +// any later version. + +// This library is distributed in the hope that it will be useful, +// but WITHOUT ANY WARRANTY; without even the implied warranty of +// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +// GNU General Public License for more details. + +// You should have received a copy of the GNU General Public License along +// with this library; see the file COPYING3. If not see +// <http://www.gnu.org/licenses/>. + +// { dg-do compile { target c++11 } } + +#include <forward_list> + +template <typename T> +struct Alloc +{ + using value_type = T; + + T* allocate(unsigned n); + void deallocate(T* p, unsigned n); + + Alloc(int) { } + + template<typename U> + Alloc(const Alloc&) { } +}; + +template<typename T, typename U> + bool operator==(Alloc<T>, Alloc) { return true; } +template<typename T, typename U> + bool operator!=(Alloc<T>, Alloc) { return false; } + +constexpr bool b + = std::is_default_constructible<std::forward_list<bool, Alloc<bool>>>::value; diff --git a/libstdc++-v3/testsuite/23_containers/list/cons/87809.cc b/libstdc++-v3/testsuite/23_containers/list/cons/87809.cc new file mode 100644 index 00000000000..d7c5256b62c --- /dev/null +++ b/libstdc++-v3/testsuite/23_containers/list/cons/87809.cc @@ -0,0 +1,42 @@ +// Copyright (C) 2018 Free Software Foundation, Inc. +// +// This file is part of the GNU ISO C++ Library. This library is free +// software; you can redistribute it and/or modify it under the +// terms of the GNU General Public License as published by the +// Free Software Foundation; either version 3, or (at your option) +// any later version. + +// This library is distributed in the hope that it will be useful, +// but WITHOUT ANY WARRANTY; without even the implied warranty of +// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +// GNU General Public License for more details. + +// You should have received a copy of the GNU General Public License along +// with this library; see the file COPYING3. If not see +// <http://www.gnu.org/licenses/>. + +// { dg-do compile { target c++11 } } + +#include <list> + +template <typename T> +struct Alloc +{ + using value_type = T; + + T* allocate(unsigned n); + void deallocate(T* p, unsigned n); + + Alloc(int) { } + + template<typename U> + Alloc(const Alloc&) { } +}; + +template<typename T, typename U> + bool operator==(Alloc<T>, Alloc) { return true; } +template<typename T, typename U> + bool operator!=(Alloc<T>, Alloc) { return false; } + +constexpr bool b + = std::is_default_constructible<std::list<bool, Alloc<bool>>>::value; diff --git a/libstdc++-v3/testsuite/23_containers/vector/bool/cons/87809.cc b/libstdc++-v3/testsuite/23_containers/vector/bool/cons/87809.cc new file mode 100644 index 00000000000..b697abe5658 --- /dev/null +++ b/libstdc++-v3/testsuite/23_containers/vector/bool/cons/87809.cc @@ -0,0 +1,42 @@ +// Copyright (C) 2018 Free Software Foundation, Inc. +// +// This file is part of the GNU ISO C++ Library. This library is free +// software; you can redistribute it and/or modify it under the +// terms of the GNU General Public License as published by the +// Free Software Foundation; either version 3, or (at your option) +// any later version. + +// This library is distributed in the hope that it will be useful, +// but WITHOUT ANY WARRANTY; without even the implied warranty of +// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +// GNU General Public License for more details. + +// You should have received a copy of the GNU General Public License along +// with this library; see the file COPYING3. If not see +// <http://www.gnu.org/licenses/>. + +// { dg-do compile { target c++11 } } + +#include <vector> + +template <typename T> +struct Alloc +{ + using value_type = T; + + T* allocate(unsigned n); + void deallocate(T* p, unsigned n); + + Alloc(int) { } + + template<typename U> + Alloc(const Alloc&) { } +}; + +template<typename T, typename U> + bool operator==(Alloc<T>, Alloc) { return true; } +template<typename T, typename U> + bool operator!=(Alloc<T>, Alloc) { return false; } + +constexpr bool b + = std::is_default_constructible<std::vector<bool, Alloc<bool>>>::value; diff --git a/libstdc++-v3/testsuite/23_containers/vector/cons/87809.cc b/libstdc++-v3/testsuite/23_containers/vector/cons/87809.cc new file mode 100644 index 00000000000..07199339b14 --- /dev/null +++ b/libstdc++-v3/testsuite/23_containers/vector/cons/87809.cc @@ -0,0 +1,42 @@ +// Copyright (C) 2018 Free Software Foundation, Inc. +// +// This file is part of the GNU ISO C++ Library. This library is free +// software; you can redistribute it and/or modify it under the +// terms of the GNU General Public License as published by the +// Free Software Foundation; either version 3, or (at your option) +// any later version. + +// This library is distributed in the hope that it will be useful, +// but WITHOUT ANY WARRANTY; without even the implied warranty of +// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +// GNU General Public License for more details. + +// You should have received a copy of the GNU General Public License along +// with this library; see the file COPYING3. If not see +// <http://www.gnu.org/licenses/>. + +// { dg-do compile { target c++11 } } + +#include <vector> + +template <typename T> +struct Alloc +{ + using value_type = T; + + T* allocate(unsigned n); + void deallocate(T* p, unsigned n); + + Alloc(int) { } + + template<typename U> + Alloc(const Alloc&) { } +}; + +template<typename T, typename U> + bool operator==(Alloc<T>, Alloc) { return true; } +template<typename T, typename U> + bool operator!=(Alloc<T>, Alloc) { return false; } + +constexpr bool b + = std::is_default_constructible<std::vector<int, Alloc<int>>>::value;

PR libstdc++/87809 avoid invalid expressions in exception specifications

Commit Message

Patch