| Message ID | e45e3edd61bc0d5c7f3e46ac118084bdc6e5495f.1540851969.git.lorenzo.bianconi@redhat.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [OpenWrt-Devel] ramips: add mt76x0 node to RT-AC51U device tree | expand |
> Hi Lorenzo, > > thank you for your work on the mt76 drivers! > > On Mon, Oct 29, 2018 at 11:31 PM Lorenzo Bianconi > <lorenzo.bianconi@redhat.com> wrote: > > > > Introduce mt76x0e device tree node in RT-AC51U dts. > > Define mt76x0e mtd partition and offset > > > > Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com> > > --- > > target/linux/ramips/dts/RT-AC51U.dts | 11 +++++++++++ > > 1 file changed, 11 insertions(+) > > > > diff --git a/target/linux/ramips/dts/RT-AC51U.dts b/target/linux/ramips/dts/RT-AC51U.dts > > index 6bed8446e5..f6cc36b719 100644 > > --- a/target/linux/ramips/dts/RT-AC51U.dts > > +++ b/target/linux/ramips/dts/RT-AC51U.dts > > @@ -135,3 +135,14 @@ > > }; > > }; > > }; > > + > > +&pcie { > > + status = "okay"; > > +}; > > + > > +&pcie0 { > > + mt76@0,0 { > this should be wifi@0,0 because node-names are supposed to represent > the device type, not a specific "implementation" > quote from [0]: "A node for a 3com Ethernet adapter would be use the > name ethernet, not 3com509." Hi Martin, thx for the review. I will fix it in v2. Regards, Lorenzo > > > + reg = <0x0000 0 0 0 0>; > > + mediatek,mtd-eeprom = <&factory 0x8000>; > > + }; > > +}; > > -- > > 2.19.1 > > > > > > _______________________________________________ > > openwrt-devel mailing list > > openwrt-devel@lists.openwrt.org > > https://lists.openwrt.org/mailman/listinfo/openwrt-devel > > [0] https://elinux.org/Device_Tree_Usage#Node_Names
The sender domain has a DMARC Reject/Quarantine policy which disallows sending mailing list messages using the original "From" header. To mitigate this problem, the original message has been wrapped automatically by the mailing list software. Hi Lorenzo, thank you for your work on the mt76 drivers! On Mon, Oct 29, 2018 at 11:31 PM Lorenzo Bianconi <lorenzo.bianconi@redhat.com> wrote: > > Introduce mt76x0e device tree node in RT-AC51U dts. > Define mt76x0e mtd partition and offset > > Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com> > --- > target/linux/ramips/dts/RT-AC51U.dts | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/target/linux/ramips/dts/RT-AC51U.dts b/target/linux/ramips/dts/RT-AC51U.dts > index 6bed8446e5..f6cc36b719 100644 > --- a/target/linux/ramips/dts/RT-AC51U.dts > +++ b/target/linux/ramips/dts/RT-AC51U.dts > @@ -135,3 +135,14 @@ > }; > }; > }; > + > +&pcie { > + status = "okay"; > +}; > + > +&pcie0 { > + mt76@0,0 { this should be wifi@0,0 because node-names are supposed to represent the device type, not a specific "implementation" quote from [0]: "A node for a 3com Ethernet adapter would be use the name ethernet, not 3com509." > + reg = <0x0000 0 0 0 0>; > + mediatek,mtd-eeprom = <&factory 0x8000>; > + }; > +}; > -- > 2.19.1 > > > _______________________________________________ > openwrt-devel mailing list > openwrt-devel@lists.openwrt.org > https://lists.openwrt.org/mailman/listinfo/openwrt-devel [0] https://elinux.org/Device_Tree_Usage#Node_Names
diff --git a/target/linux/ramips/dts/RT-AC51U.dts b/target/linux/ramips/dts/RT-AC51U.dts index 6bed8446e5..f6cc36b719 100644 --- a/target/linux/ramips/dts/RT-AC51U.dts +++ b/target/linux/ramips/dts/RT-AC51U.dts @@ -135,3 +135,14 @@ }; }; }; + +&pcie { + status = "okay"; +}; + +&pcie0 { + mt76@0,0 { + reg = <0x0000 0 0 0 0>; + mediatek,mtd-eeprom = <&factory 0x8000>; + }; +};
Introduce mt76x0e device tree node in RT-AC51U dts. Define mt76x0e mtd partition and offset Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com> --- target/linux/ramips/dts/RT-AC51U.dts | 11 +++++++++++ 1 file changed, 11 insertions(+)