From patchwork Mon Oct 29 12:49:19 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ilya Maximets X-Patchwork-Id: 990180 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=openvswitch.org (client-ip=140.211.169.12; helo=mail.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=samsung.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=samsung.com header.i=@samsung.com header.b="i5lr/o2D"; dkim-atps=neutral Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 42kDwh5wqLz9s3Z for ; Mon, 29 Oct 2018 23:50:44 +1100 (AEDT) Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id C3ECF2890; Mon, 29 Oct 2018 12:49:50 +0000 (UTC) X-Original-To: ovs-dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 5F1222842 for ; Mon, 29 Oct 2018 12:49:47 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id CD4A525A for ; Mon, 29 Oct 2018 12:49:46 +0000 (UTC) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20181029124945euoutp028160995adec1f1f3b2af1094dc88bcca~iFT_bqZpM1683616836euoutp02R; Mon, 29 Oct 2018 12:49:45 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20181029124945euoutp028160995adec1f1f3b2af1094dc88bcca~iFT_bqZpM1683616836euoutp02R DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1540817385; bh=ylUzvlPrAX6aLBP68Nq5VwVcQealxsH8tAkiTdzAIMc=; h=From:To:Cc:Subject:Date:In-reply-to:References:From; b=i5lr/o2DMzLJwj3pwqQNafKuSxuGV4lN8rHJsLx37aJKY6dsASD2XyFCmOdhlK75P 8+iLqAb21L8jA+H9MbG3zD75ybE9CwOoJsOOW0eREvI+nVAx8lz1Q1lhdaOpOQIsf7 jY6bK/Ze2YKOuyB874ReIg90IA/eM5vUEIG2xNso= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20181029124945eucas1p1bd2393ff2c2a5be3985737911606429b~iFT_Clu1s0774607746eucas1p1M; Mon, 29 Oct 2018 12:49:45 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id 9C.FA.04806.8E107DB5; Mon, 29 Oct 2018 12:49:44 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20181029124944eucas1p1bdec5cdee3c327f4db9329c6a1e88ec7~iFT9XBL2Z2144721447eucas1p1P; Mon, 29 Oct 2018 12:49:44 +0000 (GMT) X-AuditID: cbfec7f5-367ff700000012c6-4a-5bd701e89f05 Received: from eusync3.samsung.com ( [203.254.199.213]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id B7.5C.04284.8E107DB5; Mon, 29 Oct 2018 12:49:44 +0000 (GMT) Received: from imaximets.rnd.samsung.ru ([106.109.129.180]) by eusync3.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0PHD00EQH2AI7G60@eusync3.samsung.com>; Mon, 29 Oct 2018 12:49:44 +0000 (GMT) From: Ilya Maximets To: ovs-dev@openvswitch.org Date: Mon, 29 Oct 2018 15:49:19 +0300 Message-id: <20181029124926.12199-3-i.maximets@samsung.com> X-Mailer: git-send-email 2.17.1 In-reply-to: <20181029124926.12199-1-i.maximets@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrGIsWRmVeSWpSXmKPExsWy7djPc7ovGK9HG8x4rWOxZdpkVotXi84z W1xp/8lusfHhWVaLuZ+eM1rcnuNl8fTiL2aLliU7mRw4PG78u8XmsXjPSyaPZ9MPM3nc2H6a 1ePZzf+MHn1bVjF6/G++yhrAHsVlk5Kak1mWWqRvl8CVsWTrV+aCA/IVk24sY21gPCPZxcjJ ISFgInHlwjZGEFtIYAWjxPaWqi5GLiD7M6PEhQmTWGGKXt2/xQyRWMYocbR7ASuE08wksf3n N3aQKjYBHYlTq4+AjRIRkJZ43fsGrIhZYCKTxNufF9hAEsICNhLnJx0Hsjk4WARUJVqX8IGY vALWEm8vGUAsk5dYveEAM4jNCVT9/H4/G8gYCYEFbBL33k5nAqmXEHCRONCfB1EvLPHq+BZ2 CFtGorPjIBOEXS9xv+UlI0RvB6PE9EP/oBL2EltenwNrYBbgk5i0bTozxExeiY42IYgSD4me 5ouMED/2M0qsPTWNZQKj5AJGhlWM4qmlxbnpqcXGeanlesWJucWleel6yfm5mxiBsXn63/Gv Oxj3/Uk6xCjAwajEw/uA+1q0EGtiWXFl7iFGCQ5mJRHeV2eBQrwpiZVVqUX58UWlOanFhxil OViUxHmXzdsYLSSQnliSmp2aWpBaBJNl4uCUamCskWFgmLJqT7ZzXPCq+8mT3AxOFutYPBBK uy1u9j6fhVnT7u4biaMdCncrrPbNLX4t/YK398S7rysYl66/E+r2OTk+Jesy09qSf00ypjLf dKbMOb7SfUXNnft/04+qxH2aJ6osPuPkQd7CIpWNzGydQQ9KzZl99Jh2sd5wqd148PSxOdI6 h3mUWIozEg21mIuKEwGWYDXvyQIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprKLMWRmVeSWpSXmKPExsVy+t/xq7ovGK9HG1zu57fYMm0yq8WrReeZ La60/2S32PjwLKvF3E/PGS1uz/GyeHrxF7NFy5KdTA4cHjf+3WLzWLznJZPHs+mHmTxubD/N 6vHs5n9Gj74tqxg9/jdfZQ1gj+KySUnNySxLLdK3S+DKWLL1K3PBAfmKSTeWsTYwnpHsYuTk kBAwkXh1/xZzFyMXh5DAEkaJvxvvMEI4rUwSPzfsYQWpYhPQkTi1+ggjiC0iIC3xuvcNK0gR s8BkJoklLU3MIAlhARuJ85OOs3UxcnCwCKhKtC7hAzF5Bawl3l4ygFgmL7F6wwGwak6g6uf3 +9lAbCGgklUf5zJPYORZwMiwilEktbQ4Nz232FCvODG3uDQvXS85P3cTIzCwth37uXkH46WN wYcYBTgYlXh4H3BfixZiTSwrrsw9xCjBwawkwvvqLFCINyWxsiq1KD++qDQntfgQozQHi5I4 73mDyighgfTEktTs1NSC1CKYLBMHp1QDY4PAjI+dP8KWTLnyYGpz3vRFbgJPJ55PeVPxOdze 22oNY+kyi1dn2PcGa/tNizss/2j379cB96yDVt/4cbzk1zbBjed/LtvS//5kysmGe59t/swO s9rkx/TnTLLhe90/Ese/6UzfZb2wJ33XXeOj31/4vfjH47PahTnzEMvGly+U69btDdv8YeZb JZbijERDLeai4kQAzXEphSgCAAA= X-CMS-MailID: 20181029124944eucas1p1bdec5cdee3c327f4db9329c6a1e88ec7 X-Msg-Generator: CA CMS-TYPE: 201P X-CMS-RootMailID: 20181029124944eucas1p1bdec5cdee3c327f4db9329c6a1e88ec7 References: <20181029124926.12199-1-i.maximets@samsung.com> X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org Cc: Shahaf Shuler , Flavio Leitner , Ilya Maximets Subject: [ovs-dev] [PATCH 2/9] dp-packet: Constantify offloading APIs. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org Getters should have const arguments. Signed-off-by: Ilya Maximets --- lib/dp-packet.h | 28 ++++++++++++++-------------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/lib/dp-packet.h b/lib/dp-packet.h index 5b4c9c7a3..0c4c8c853 100644 --- a/lib/dp-packet.h +++ b/lib/dp-packet.h @@ -469,7 +469,7 @@ dp_packet_set_allocated(struct dp_packet *b, uint16_t s) /* Returns the RSS hash of the packet 'p'. Note that the returned value is * correct only if 'dp_packet_rss_valid(p)' returns true */ static inline uint32_t -dp_packet_get_rss_hash(struct dp_packet *p) +dp_packet_get_rss_hash(const struct dp_packet *p) { return p->mbuf.hash.rss; } @@ -482,7 +482,7 @@ dp_packet_set_rss_hash(struct dp_packet *p, uint32_t hash) } static inline bool -dp_packet_rss_valid(struct dp_packet *p) +dp_packet_rss_valid(const struct dp_packet *p) { return p->mbuf.ol_flags & PKT_RX_RSS_HASH; } @@ -509,28 +509,28 @@ dp_packet_mbuf_init(struct dp_packet *p) } static inline bool -dp_packet_ip_checksum_valid(struct dp_packet *p) +dp_packet_ip_checksum_valid(const struct dp_packet *p) { return (p->mbuf.ol_flags & PKT_RX_IP_CKSUM_MASK) == PKT_RX_IP_CKSUM_GOOD; } static inline bool -dp_packet_ip_checksum_bad(struct dp_packet *p) +dp_packet_ip_checksum_bad(const struct dp_packet *p) { return (p->mbuf.ol_flags & PKT_RX_IP_CKSUM_MASK) == PKT_RX_IP_CKSUM_BAD; } static inline bool -dp_packet_l4_checksum_valid(struct dp_packet *p) +dp_packet_l4_checksum_valid(const struct dp_packet *p) { return (p->mbuf.ol_flags & PKT_RX_L4_CKSUM_MASK) == PKT_RX_L4_CKSUM_GOOD; } static inline bool -dp_packet_l4_checksum_bad(struct dp_packet *p) +dp_packet_l4_checksum_bad(const struct dp_packet *p) { return (p->mbuf.ol_flags & PKT_RX_L4_CKSUM_MASK) == PKT_RX_L4_CKSUM_BAD; @@ -544,7 +544,7 @@ reset_dp_packet_checksum_ol_flags(struct dp_packet *p) } static inline bool -dp_packet_has_flow_mark(struct dp_packet *p, uint32_t *mark) +dp_packet_has_flow_mark(const struct dp_packet *p, uint32_t *mark) { if (p->mbuf.ol_flags & PKT_RX_FDIR_ID) { *mark = p->mbuf.hash.fdir.hi; @@ -606,7 +606,7 @@ dp_packet_set_allocated(struct dp_packet *b, uint16_t s) /* Returns the RSS hash of the packet 'p'. Note that the returned value is * correct only if 'dp_packet_rss_valid(p)' returns true */ static inline uint32_t -dp_packet_get_rss_hash(struct dp_packet *p) +dp_packet_get_rss_hash(const struct dp_packet *p) { return p->rss_hash; } @@ -619,7 +619,7 @@ dp_packet_set_rss_hash(struct dp_packet *p, uint32_t hash) } static inline bool -dp_packet_rss_valid(struct dp_packet *p) +dp_packet_rss_valid(const struct dp_packet *p) { return p->rss_hash_valid; } @@ -641,25 +641,25 @@ dp_packet_mbuf_init(struct dp_packet *p OVS_UNUSED) } static inline bool -dp_packet_ip_checksum_valid(struct dp_packet *p OVS_UNUSED) +dp_packet_ip_checksum_valid(const struct dp_packet *p OVS_UNUSED) { return false; } static inline bool -dp_packet_ip_checksum_bad(struct dp_packet *p OVS_UNUSED) +dp_packet_ip_checksum_bad(const struct dp_packet *p OVS_UNUSED) { return false; } static inline bool -dp_packet_l4_checksum_valid(struct dp_packet *p OVS_UNUSED) +dp_packet_l4_checksum_valid(const struct dp_packet *p OVS_UNUSED) { return false; } static inline bool -dp_packet_l4_checksum_bad(struct dp_packet *p OVS_UNUSED) +dp_packet_l4_checksum_bad(const struct dp_packet *p OVS_UNUSED) { return false; } @@ -670,7 +670,7 @@ reset_dp_packet_checksum_ol_flags(struct dp_packet *p OVS_UNUSED) } static inline bool -dp_packet_has_flow_mark(struct dp_packet *p OVS_UNUSED, +dp_packet_has_flow_mark(const struct dp_packet *p OVS_UNUSED, uint32_t *mark OVS_UNUSED) { return false;