| Message ID | F8C98D83-CF3C-4BF5-9AEA-D313DC730413@comcast.net |
|---|---|
| State | New |
| Headers | show |
| Series | [testsuite] : check for weak support | expand |
Ping. Ok to commit? paul > On Oct 25, 2018, at 2:57 PM, Paul Koning <paulkoning@comcast.net> wrote: > > I ran into a failures due to no weak symbol support in my target. This patch cures that. Is it right? The test case uses "weakref" so I' not 100% sure that checking for "weak" support is correct. If not, I can put in a skip-if check for the target (pdp11) instead. > > paul > > ChangeLog: > > 2018-10-25 Paul Koning <ni1d@arrl.net> > > * gcc.dg/tree-ssa/attr-alias.c: Skip if no weak support. > > Index: testsuite/gcc.dg/tree-ssa/attr-alias.c > =================================================================== > --- testsuite/gcc.dg/tree-ssa/attr-alias.c (revision 265404) > +++ testsuite/gcc.dg/tree-ssa/attr-alias.c (working copy) > @@ -1,5 +1,6 @@ > /* { dg-do compile } */ > /* { dg-require-alias "" } */ > +/* { dg-require-weak "" } */ > /* { dg-options "-O2 -fdump-tree-optimized -std=gnu89" } */ > void abort (void); > __attribute__ ((weak)) >
On 10/30/18 6:55 AM, Paul Koning wrote: > Ping. Ok to commit? > > paul > >> On Oct 25, 2018, at 2:57 PM, Paul Koning <paulkoning@comcast.net> wrote: >> >> I ran into a failures due to no weak symbol support in my target. This patch cures that. Is it right? The test case uses "weakref" so I' not 100% sure that checking for "weak" support is correct. If not, I can put in a skip-if check for the target (pdp11) instead. >> >> paul >> >> ChangeLog: >> >> 2018-10-25 Paul Koning <ni1d@arrl.net> >> >> * gcc.dg/tree-ssa/attr-alias.c: Skip if no weak support. OK. This would fall under the obvious rule IMHO. There's a "weak" attribute so clearly the test needs to require weak support :-) jeff
> On Oct 30, 2018, at 10:17 AM, Jeff Law <law@redhat.com> wrote: > > On 10/30/18 6:55 AM, Paul Koning wrote: >> Ping. Ok to commit? >> >> paul >> >>> On Oct 25, 2018, at 2:57 PM, Paul Koning <paulkoning@comcast.net> wrote: >>> >>> I ran into a failures due to no weak symbol support in my target. This patch cures that. Is it right? The test case uses "weakref" so I' not 100% sure that checking for "weak" support is correct. If not, I can put in a skip-if check for the target (pdp11) instead. >>> >>> paul >>> >>> ChangeLog: >>> >>> 2018-10-25 Paul Koning <ni1d@arrl.net> >>> >>> * gcc.dg/tree-ssa/attr-alias.c: Skip if no weak support. > OK. This would fall under the obvious rule IMHO. There's a "weak" > attribute so clearly the test needs to require weak support :-) > > jeff Thanks. Committed. paul
Index: testsuite/gcc.dg/tree-ssa/attr-alias.c =================================================================== --- testsuite/gcc.dg/tree-ssa/attr-alias.c (revision 265404) +++ testsuite/gcc.dg/tree-ssa/attr-alias.c (working copy) @@ -1,5 +1,6 @@ /* { dg-do compile } */ /* { dg-require-alias "" } */ +/* { dg-require-weak "" } */ /* { dg-options "-O2 -fdump-tree-optimized -std=gnu89" } */ void abort (void); __attribute__ ((weak))