Patchwork [U-Boot] imx31_litekit: Remove local config.mk

login
register
mail settings
Submitter Fabio Estevam
Date June 6, 2011, 1:13 p.m.
Message ID <1307366016-7232-1-git-send-email-fabio.estevam@freescale.com>
Download mbox | patch
Permalink /patch/98888/
State Accepted
Commit ac88e66e14886ab97c25c91b0f3a5350d7c8db65
Delegated to: Stefano Babic
Headers show

Comments

Fabio Estevam - June 6, 2011, 1:13 p.m.
Local board config.mk should be avoided.

Place CONFIG_SYS_TEXT_BASE definition into the board config file instead.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 board/logicpd/imx31_litekit/config.mk |    1 -
 include/configs/imx31_litekit.h       |    2 ++
 2 files changed, 2 insertions(+), 1 deletions(-)
 delete mode 100644 board/logicpd/imx31_litekit/config.mk
Stefano Babic - June 6, 2011, 1:26 p.m.
On 06/06/2011 03:13 PM, Fabio Estevam wrote:
> Local board config.mk should be avoided.
> 
> Place CONFIG_SYS_TEXT_BASE definition into the board config file instead.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---

Thanks for fixing this issue, too.

Acked-by: Stefano Babic <sbabic@denx.de>

Regards,
Stefano
Stefano Babic - June 7, 2011, 1:09 p.m.
On 06/06/2011 03:13 PM, Fabio Estevam wrote:
> Local board config.mk should be avoided.
> 
> Place CONFIG_SYS_TEXT_BASE definition into the board config file instead.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>

Applied to u-boot-imx, thanks.

Best regards,
Stefano Babic

Patch

diff --git a/board/logicpd/imx31_litekit/config.mk b/board/logicpd/imx31_litekit/config.mk
deleted file mode 100644
index a7887ba..0000000
--- a/board/logicpd/imx31_litekit/config.mk
+++ /dev/null
@@ -1 +0,0 @@ 
-CONFIG_SYS_TEXT_BASE = 0xa0000000
diff --git a/include/configs/imx31_litekit.h b/include/configs/imx31_litekit.h
index 7ee7076..1131db0 100644
--- a/include/configs/imx31_litekit.h
+++ b/include/configs/imx31_litekit.h
@@ -39,6 +39,8 @@ 
 #define CONFIG_DISPLAY_CPUINFO
 #define CONFIG_DISPLAY_BOARDINFO
 
+#define CONFIG_SYS_TEXT_BASE	0xa0000000
+
 /* Temporarily disabled */
 #if 0
 #define CONFIG_OF_LIBFDT		1