Noisier debugging of unexpected mid cancellation
diff mbox series

Message ID CAH2r5ms1D9RkaO0rQgHMN3dhrgHUsVGK-QsdS+kdfgxeZ7BL6w@mail.gmail.com
State New
Headers show
Series
  • Noisier debugging of unexpected mid cancellation
Related show

Commit Message

Steve French Oct. 24, 2018, 2:14 a.m. UTC
Have been trying to debug xfstest 28 warnings (unexpected cancellation
of mid "CIFS VFS: Close unmatched open") so wanted to make this
earlier (FYI level) message noisier and add which command is causing
it (in this case open)

Patch
diff mbox series

From d9d6a30f0baa36859703c67b29aba9c259db1c0f Mon Sep 17 00:00:00 2001
From: Steve French <stfrench@microsoft.com>
Date: Tue, 23 Oct 2018 21:04:57 -0500
Subject: [PATCH 2/2] smb3: add debug for unexpected mid cancellation

We have hit this intermittently, increase the verbosity of
warning message on unexpected mid cancellation.

Signed-off-by: Steve French <stfrench@microsoft.com>
---
 fs/cifs/transport.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/cifs/transport.c b/fs/cifs/transport.c
index fd80749c7838..f8112433f0c8 100644
--- a/fs/cifs/transport.c
+++ b/fs/cifs/transport.c
@@ -876,8 +876,8 @@  compound_send_recv(const unsigned int xid, struct cifs_ses *ses,
 	for (i = 0; i < num_rqst; i++) {
 		rc = wait_for_response(ses->server, midQ[i]);
 		if (rc != 0) {
-			cifs_dbg(FYI, "Cancelling wait for mid %llu\n",
-				 midQ[i]->mid);
+			cifs_dbg(VFS, "Cancelling wait for mid %llu cmd: %d\n",
+				 midQ[i]->mid, le16_to_cpu(midQ[i]->command));
 			send_cancel(ses->server, &rqst[i], midQ[i]);
 			spin_lock(&GlobalMid_Lock);
 			if (midQ[i]->mid_state == MID_REQUEST_SUBMITTED) {
-- 
2.17.1