Patchwork slirp: fix guestfwd id

login
register
mail settings
Submitter Alexander Graf
Date June 4, 2011, 5:25 a.m.
Message ID <1307165159-29222-1-git-send-email-agraf@suse.de>
Download mbox | patch
Permalink /patch/98755/
State New
Headers show

Comments

Alexander Graf - June 4, 2011, 5:25 a.m.
When using -net user,guestfwd=... Qemu immediately complains about the id
being in invalid format. This is because we pass in an id that contains a
colon, while the id restrictions don't allow colons.

This patch changes the colon into a dot, making guestfwd work again.

Signed-off-by: Alexander Graf <agraf@suse.de>
---
 net/slirp.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Stefan Hajnoczi - June 7, 2011, 1:55 p.m.
On Sat, Jun 04, 2011 at 07:25:59AM +0200, Alexander Graf wrote:
> When using -net user,guestfwd=... Qemu immediately complains about the id
> being in invalid format. This is because we pass in an id that contains a
> colon, while the id restrictions don't allow colons.
> 
> This patch changes the colon into a dot, making guestfwd work again.
> 
> Signed-off-by: Alexander Graf <agraf@suse.de>
> ---
>  net/slirp.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

Thanks, applied to the trivial patches tree:
http://repo.or.cz/w/qemu/stefanha.git/shortlog/refs/heads/trivial-patches

Stefan

Patch

diff --git a/net/slirp.c b/net/slirp.c
index e387a11..e057a14 100644
--- a/net/slirp.c
+++ b/net/slirp.c
@@ -614,7 +614,7 @@  static int slirp_guestfwd(SlirpState *s, const char *config_str,
     }
 
     fwd = qemu_malloc(sizeof(struct GuestFwd));
-    snprintf(buf, sizeof(buf), "guestfwd.tcp:%d", port);
+    snprintf(buf, sizeof(buf), "guestfwd.tcp.%d", port);
     fwd->hd = qemu_chr_open(buf, p, NULL);
     if (!fwd->hd) {
         error_report("could not open guest forwarding device '%s'", buf);