diff mbox series

ixgbe: fix MAC anti-spoofing filter after VFLR

Message ID 1540190671-43799-1-git-send-email-radoslawx.tyl@intel.com
State Accepted
Delegated to: Jeff Kirsher
Headers show
Series ixgbe: fix MAC anti-spoofing filter after VFLR | expand

Commit Message

Radoslaw Tyl Oct. 22, 2018, 6:44 a.m. UTC
This change resolves a driver bug where the driver is logging a
message that says "Spoofed packets detected". This can occur on the PF
(host) when a VF has VLAN+MACVLAN enabled and is re-started with a
different MAC address.

MAC and VLAN anti-spoofing filters are to be enabled together.

Signed-off-by: Radoslaw Tyl <radoslawx.tyl@intel.com>
---
 drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Bowers, AndrewX Oct. 23, 2018, 11:30 p.m. UTC | #1
> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces@osuosl.org] On
> Behalf Of Radoslaw Tyl
> Sent: Sunday, October 21, 2018 11:45 PM
> To: intel-wired-lan@lists.osuosl.org
> Cc: Tyl, RadoslawX <radoslawx.tyl@intel.com>
> Subject: [Intel-wired-lan] [PATCH] ixgbe: fix MAC anti-spoofing filter after
> VFLR
> 
> This change resolves a driver bug where the driver is logging a message that
> says "Spoofed packets detected". This can occur on the PF
> (host) when a VF has VLAN+MACVLAN enabled and is re-started with a
> different MAC address.
> 
> MAC and VLAN anti-spoofing filters are to be enabled together.
> 
> Signed-off-by: Radoslaw Tyl <radoslawx.tyl@intel.com>
> ---
>  drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Piotr Skajewski Oct. 31, 2018, 8:41 a.m. UTC | #2
>> -----Original Message-----
>> From: Intel-wired-lan [mailto:intel-wired-lan-bounces@osuosl.org] On
>> Behalf Of Radoslaw Tyl
>> Sent: Sunday, October 21, 2018 11:45 PM
>> To: intel-wired-lan@lists.osuosl.org
>> Cc: Tyl, RadoslawX <radoslawx.tyl@intel.com>
>> Subject: [Intel-wired-lan] [PATCH] ixgbe: fix MAC anti-spoofing filter after
>> VFLR
>> 
>> This change resolves a driver bug where the driver is logging a message that
>> says "Spoofed packets detected". This can occur on the PF
>> (host) when a VF has VLAN+MACVLAN enabled and is re-started with a
>> different MAC address.
>> 
>> MAC and VLAN anti-spoofing filters are to be enabled together.
>> 
>> Signed-off-by: Radoslaw Tyl <radoslawx.tyl@intel.com>
>> ---
>>  drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c | 4 +++-
>>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> Tested-by: Andrew Bowers <andrewx.bowers@intel.com>

Acked-by: Piotr Skajewski <piotrx.skajewski@intel.com>
diff mbox series

Patch

diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c
index af25a8f..5dacfc8 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c
@@ -722,8 +722,10 @@  static inline void ixgbe_vf_reset_event(struct ixgbe_adapter *adapter, u32 vf)
 			ixgbe_set_vmvir(adapter, vfinfo->pf_vlan,
 					adapter->default_up, vf);
 
-		if (vfinfo->spoofchk_enabled)
+		if (vfinfo->spoofchk_enabled) {
 			hw->mac.ops.set_vlan_anti_spoofing(hw, true, vf);
+			hw->mac.ops.set_mac_anti_spoofing(hw, true, vf);
+		}
 	}
 
 	/* reset multicast table array for vf */