| Message ID | 4DEA9A7F.4020504@eukrea.com |
|---|---|
| State | Superseded |
| Delegated to: | Reinhard Meyer |
| Headers | show |
Hi Eric, Thanks - but the bigger problem is that snapper9260.c isn't even in the repository! Regards, Simon On Sat, Jun 4, 2011 at 1:50 PM, Eric Bénard <eric@eukrea.com> wrote: > Hi Simon, > > On 04/06/2011 20:47, Simon Glass wrote: > > Hi Reinhard, > > > > I have been asked to have a quick look at this patch, which is showing > > accepted here: > > > > http://patchwork.ozlabs.org/patch/81422/ > > > > The diffstat on patchwork is: > > > > MAINTAINERS | 5 + > > board/bluewater/snapper9260/Makefile | 53 ++++++++ > > board/bluewater/snapper9260/snapper9260.c | 169 > +++++++++++++++++++++++++ > > boards.cfg | 2 + > > include/configs/snapper9260.h | 191 > +++++++++++++++++++++++++++++ > > 5 files changed, 420 insertions(+), 0 deletions(-) > > create mode 100644 board/bluewater/snapper9260/Makefile > > create mode 100644 board/bluewater/snapper9260/snapper9260.c > > create mode 100644 include/configs/snapper9260.h > > > > but when I look at the commit I only see this: > > > > git log --author=Ryan --stat > > commit 74cd9777f8dd44fd944a9ac75cfbc24eeb206453 > > Author: Ryan Mallon<ryan@bluewatersys.com> > > Date: Tue Feb 1 16:18:00 2011 +0000 > > > > Add support for Bluewater Systems Snapper 9260 and 9G20 modules > > > > Add support for Bluewater Systems AT91 based Snapper 9260 and 9G20 > > single board computer modules. Includes NAND flash and Ethernet > > support. > > > > Signed-off-by: Ryan Mallon<ryan@bluewatersys.com> > > > > boards.cfg | 2 ++ > > 1 files changed, 2 insertions(+), 0 deletions(-) > > > > > > As a result it does not build. Has something been dropped by mistake? > > > 9260 seems broken (and also arch/arm/cpu/arm926ejs/at91/lowlevel_init.S), > this > may help : > > diff --git a/arch/arm/cpu/arm926ejs/at91/at91sam9260_devices.c > b/arch/arm/cpu/arm926ejs/at91/at91sam9260_devices.c > index 6bdc75c..ace1ca8 100644 > --- a/arch/arm/cpu/arm926ejs/at91/at91sam9260_devices.c > +++ b/arch/arm/cpu/arm926ejs/at91/at91sam9260_devices.c > @@ -24,9 +24,10 @@ > > #include <common.h> > #include <asm/io.h> > +#include <asm/arch/hardware.h> > #include <asm/arch/at91_common.h> > #include <asm/arch/at91_pmc.h> > -#include <asm/arch/gpio.h> > +#include <asm/arch/at91_pio.h> > > /* > * if CONFIG_AT91_GPIO_PULLUP ist set, keep pullups on on all > _______________________________________________ > U-Boot mailing list > U-Boot@lists.denx.de > http://lists.denx.de/mailman/listinfo/u-boot >
On Sat, Jun 4, 2011 at 1:50 PM, Eric Bénard <eric@eukrea.com> wrote: > Hi Simon, > > On 04/06/2011 20:47, Simon Glass wrote: > > Hi Reinhard, > > > > I have been asked to have a quick look at this patch, which is showing > > accepted here: > > > > http://patchwork.ozlabs.org/patch/81422/ > > > > The diffstat on patchwork is: > > > > MAINTAINERS | 5 + > > board/bluewater/snapper9260/Makefile | 53 ++++++++ > > board/bluewater/snapper9260/snapper9260.c | 169 > +++++++++++++++++++++++++ > > boards.cfg | 2 + > > include/configs/snapper9260.h | 191 > +++++++++++++++++++++++++++++ > > 5 files changed, 420 insertions(+), 0 deletions(-) > > create mode 100644 board/bluewater/snapper9260/Makefile > > create mode 100644 board/bluewater/snapper9260/snapper9260.c > > create mode 100644 include/configs/snapper9260.h > > > > but when I look at the commit I only see this: > > > > git log --author=Ryan --stat > > commit 74cd9777f8dd44fd944a9ac75cfbc24eeb206453 > > Author: Ryan Mallon<ryan@bluewatersys.com> > > Date: Tue Feb 1 16:18:00 2011 +0000 > > > > Add support for Bluewater Systems Snapper 9260 and 9G20 modules > > > > Add support for Bluewater Systems AT91 based Snapper 9260 and 9G20 > > single board computer modules. Includes NAND flash and Ethernet > > support. > > > > Signed-off-by: Ryan Mallon<ryan@bluewatersys.com> > > > > boards.cfg | 2 ++ > > 1 files changed, 2 insertions(+), 0 deletions(-) > > > > > > As a result it does not build. Has something been dropped by mistake? > > > 9260 seems broken (and also arch/arm/cpu/arm926ejs/at91/lowlevel_init.S), > this > may help : > > diff --git a/arch/arm/cpu/arm926ejs/at91/at91sam9260_devices.c > b/arch/arm/cpu/arm926ejs/at91/at91sam9260_devices.c > index 6bdc75c..ace1ca8 100644 > --- a/arch/arm/cpu/arm926ejs/at91/at91sam9260_devices.c > +++ b/arch/arm/cpu/arm926ejs/at91/at91sam9260_devices.c > @@ -24,9 +24,10 @@ > > #include <common.h> > #include <asm/io.h> > +#include <asm/arch/hardware.h> > #include <asm/arch/at91_common.h> > #include <asm/arch/at91_pmc.h> > -#include <asm/arch/gpio.h> > +#include <asm/arch/at91_pio.h> > > /* > * if CONFIG_AT91_GPIO_PULLUP ist set, keep pullups on on all > _______________________________________________ > U-Boot mailing list > U-Boot@lists.denx.de > http://lists.denx.de/mailman/listinfo/u-boot > Hi, Thanks for that - however it seems that snapper9260.c is missing from the repository. Regards, Simon
diff --git a/arch/arm/cpu/arm926ejs/at91/at91sam9260_devices.c b/arch/arm/cpu/arm926ejs/at91/at91sam9260_devices.c index 6bdc75c..ace1ca8 100644 --- a/arch/arm/cpu/arm926ejs/at91/at91sam9260_devices.c +++ b/arch/arm/cpu/arm926ejs/at91/at91sam9260_devices.c @@ -24,9 +24,10 @@ #include <common.h> #include <asm/io.h> +#include <asm/arch/hardware.h> #include <asm/arch/at91_common.h> #include <asm/arch/at91_pmc.h> -#include <asm/arch/gpio.h> +#include <asm/arch/at91_pio.h> /* * if CONFIG_AT91_GPIO_PULLUP ist set, keep pullups on on all