From patchwork Fri Jun 3 23:18:26 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Connor Hansen X-Patchwork-Id: 98678 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 03952B6FB0 for ; Sat, 4 Jun 2011 09:18:53 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752723Ab1FCXSd (ORCPT ); Fri, 3 Jun 2011 19:18:33 -0400 Received: from mail-pw0-f46.google.com ([209.85.160.46]:57900 "EHLO mail-pw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752354Ab1FCXSb (ORCPT ); Fri, 3 Jun 2011 19:18:31 -0400 Received: by pwi15 with SMTP id 15so1201300pwi.19 for ; Fri, 03 Jun 2011 16:18:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:from:to:cc:subject:date:message-id:x-mailer; bh=CCSPl/LWr+NycQt1g7yoKF1BO7GwRe9wmaa0Patp/UQ=; b=Kxb/QYXl3O3qJwMsU71GUPV0ixIb13dw2E2iI4dCHQCkNkyiGlIPoD9p6Zl2DB8Kuw 3C987pPBlOuGsgaeWCq90t3n0CgsfLBxmY3pfBrkQXJ2mqFV6Kmm8BLM0yw4EEBXO1UC x8fACfgLTSitG6XF7WZnrPJMOGDGPX7na/joQ= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer; b=KLVRKgjzeqIDw/u4Fs2gJyC+ChiwLSsbH3KgyanGAGys94bQ1nyqoCSULpwz8RWg5l kcU7DJX/4a1O9ELC52cVE355b/rNU+0F4qDYYRjdVDHx1qeDTTe/PtdiTqTuHAGvXP18 i7EzyJQrIIrt+KrWy9a/SUXYtPYq3PDAZY4/o= Received: by 10.68.5.68 with SMTP id q4mr1060966pbq.117.1307143111403; Fri, 03 Jun 2011 16:18:31 -0700 (PDT) Received: from localhost.localdomain (c-71-197-87-91.hsd1.ca.comcast.net [71.197.87.91]) by mx.google.com with ESMTPS id k9sm1787929pbc.54.2011.06.03.16.18.30 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 03 Jun 2011 16:18:30 -0700 (PDT) From: Connor Hansen To: hadi@cyberus.ca Cc: davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Connor Hansen Subject: [PATCH] sch_generic unused variable warning Date: Fri, 3 Jun 2011 16:18:26 -0700 Message-Id: <1307143106-14523-1-git-send-email-cmdkhh@gmail.com> X-Mailer: git-send-email 1.7.4.4 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org during randconfig testing net/sched/sch_generic produced net/sched/sch_generic.c: In function dev_watchdog net/sched/sch_generic.c:254:10: warning: unused variable drivername drivername is only used in the scope of the WARN_ONCE Signed-off-by: Connor Hansen --- net/sched/sch_generic.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/net/sched/sch_generic.c b/net/sched/sch_generic.c index b1721d7..7380da2 100644 --- a/net/sched/sch_generic.c +++ b/net/sched/sch_generic.c @@ -251,9 +251,8 @@ static void dev_watchdog(unsigned long arg) } if (some_queue_timedout) { - char drivername[64]; WARN_ONCE(1, KERN_INFO "NETDEV WATCHDOG: %s (%s): transmit queue %u timed out\n", - dev->name, netdev_drivername(dev, drivername, 64), i); + dev->name, netdev_drivername(dev, char drivername[64], 64), i); dev->netdev_ops->ndo_tx_timeout(dev); } if (!mod_timer(&dev->watchdog_timer,