| Message ID | 1539953556-35762-2-git-send-email-lolivei@synopsys.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | [V3,1/4] Documentation: dt-bindings: phy: Document the Synopsys MIPI DPHY Rx bindings | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | "total: 0 errors, 1 warnings, 28 lines checked" |
On Fri, Oct 19, 2018 at 02:52:23PM +0200, Luis Oliveira wrote: > Add device-tree bindings documentation for SNPS DesignWare MIPI D-PHY in > RX mode. > > Signed-off-by: Luis Oliveira <lolivei@synopsys.com> > --- > Changelog > v2-V3 > - removed gpios reference - it was for a separated driver > - changed address to show complete address > > .../devicetree/bindings/phy/snps,dphy-rx.txt | 28 ++++++++++++++++++++++ > 1 file changed, 28 insertions(+) > create mode 100644 Documentation/devicetree/bindings/phy/snps,dphy-rx.txt > > diff --git a/Documentation/devicetree/bindings/phy/snps,dphy-rx.txt b/Documentation/devicetree/bindings/phy/snps,dphy-rx.txt > new file mode 100644 > index 0000000..03d17ab > --- /dev/null > +++ b/Documentation/devicetree/bindings/phy/snps,dphy-rx.txt > @@ -0,0 +1,28 @@ > +Synopsys DesignWare MIPI Rx D-PHY block details > + > +Description > +----------- > + > +The Synopsys MIPI D-PHY controller supports MIPI-DPHY in receiver mode. > +Please refer to phy-bindings.txt for more information. > + > +Required properties: > +- compatible : Shall be "snps,dphy-rx". > +- #phy-cells : Must be 1. > +- snps,dphy-frequency : Output frequency of the D-PHY. Needs a unit suffix (-hz). > +- snps,dphy-te-len : Size of the communication interface (8 bits->8 or 12bits->12). > +- reg : Physical base address and size of the device memory mapped > + registers; How many, what are they, and what order? Looks like 3 below. Also, a tab after spaces error. > + > +Example: > + > + mipi_dphy_rx1: dphy@d00003040 { > + compatible = "snps,dphy-rx"; > + #phy-cells = <1>; > + snps,dphy-frequency = <300000>; > + snps,dphy-te-len = <12>; > + reg = < 0xd0003040 0x20 > + 0xd0008000 0x100 > + 0xd0009000 0x100>; > + }; > + > -- > 2.7.4 >
Hi Rob, my responses inline. On 24-Oct-18 18:36, Rob Herring wrote: > On Fri, Oct 19, 2018 at 02:52:23PM +0200, Luis Oliveira wrote: >> Add device-tree bindings documentation for SNPS DesignWare MIPI D-PHY in >> RX mode. >> >> Signed-off-by: Luis Oliveira <lolivei@synopsys.com> >> --- >> Changelog >> v2-V3 >> - removed gpios reference - it was for a separated driver >> - changed address to show complete address >> >> .../devicetree/bindings/phy/snps,dphy-rx.txt | 28 ++++++++++++++++++++++ >> 1 file changed, 28 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/phy/snps,dphy-rx.txt >> >> diff --git a/Documentation/devicetree/bindings/phy/snps,dphy-rx.txt b/Documentation/devicetree/bindings/phy/snps,dphy-rx.txt >> new file mode 100644 >> index 0000000..03d17ab >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/phy/snps,dphy-rx.txt >> @@ -0,0 +1,28 @@ >> +Synopsys DesignWare MIPI Rx D-PHY block details >> + >> +Description >> +----------- >> + >> +The Synopsys MIPI D-PHY controller supports MIPI-DPHY in receiver mode. >> +Please refer to phy-bindings.txt for more information. >> + >> +Required properties: >> +- compatible : Shall be "snps,dphy-rx". >> +- #phy-cells : Must be 1. >> +- snps,dphy-frequency : Output frequency of the D-PHY. > > Needs a unit suffix (-hz). > Yes, >> +- snps,dphy-te-len : Size of the communication interface (8 bits->8 or 12bits->12). >> +- reg : Physical base address and size of the device memory mapped >> + registers; > > How many, what are they, and what order? Looks like 3 below. > > Also, a tab after spaces error. > Yep, I will fix it. Thanks >> + >> +Example: >> + >> + mipi_dphy_rx1: dphy@d00003040 { >> + compatible = "snps,dphy-rx"; >> + #phy-cells = <1>; >> + snps,dphy-frequency = <300000>; >> + snps,dphy-te-len = <12>; >> + reg = < 0xd0003040 0x20 >> + 0xd0008000 0x100 >> + 0xd0009000 0x100>; >> + }; >> + >> -- >> 2.7.4 >>
Hi Rob, my responses inline. On 24-Oct-18 18:36, Rob Herring wrote: > On Fri, Oct 19, 2018 at 02:52:23PM +0200, Luis Oliveira wrote: >> Add device-tree bindings documentation for SNPS DesignWare MIPI D-PHY in >> RX mode. >> >> Signed-off-by: Luis Oliveira <lolivei@synopsys.com> >> --- >> Changelog >> v2-V3 >> - removed gpios reference - it was for a separated driver >> - changed address to show complete address >> >> .../devicetree/bindings/phy/snps,dphy-rx.txt | 28 ++++++++++++++++++++++ >> 1 file changed, 28 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/phy/snps,dphy-rx.txt >> >> diff --git a/Documentation/devicetree/bindings/phy/snps,dphy-rx.txt b/Documentation/devicetree/bindings/phy/snps,dphy-rx.txt >> new file mode 100644 >> index 0000000..03d17ab >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/phy/snps,dphy-rx.txt >> @@ -0,0 +1,28 @@ >> +Synopsys DesignWare MIPI Rx D-PHY block details >> + >> +Description >> +----------- >> + >> +The Synopsys MIPI D-PHY controller supports MIPI-DPHY in receiver mode. >> +Please refer to phy-bindings.txt for more information. >> + >> +Required properties: >> +- compatible : Shall be "snps,dphy-rx". >> +- #phy-cells : Must be 1. >> +- snps,dphy-frequency : Output frequency of the D-PHY. > > Needs a unit suffix (-hz). > Yes, >> +- snps,dphy-te-len : Size of the communication interface (8 bits->8 or 12bits->12). >> +- reg : Physical base address and size of the device memory mapped >> + registers; > > How many, what are they, and what order? Looks like 3 below. > > Also, a tab after spaces error. > Yep, I will fix it. Thanks >> + >> +Example: >> + >> + mipi_dphy_rx1: dphy@d00003040 { >> + compatible = "snps,dphy-rx"; >> + #phy-cells = <1>; >> + snps,dphy-frequency = <300000>; >> + snps,dphy-te-len = <12>; >> + reg = < 0xd0003040 0x20 >> + 0xd0008000 0x100 >> + 0xd0009000 0x100>; >> + }; >> + >> -- >> 2.7.4 >>
Hi Luis, Thank you for the patch. On Friday, 19 October 2018 15:52:23 EET Luis Oliveira wrote: > Add device-tree bindings documentation for SNPS DesignWare MIPI D-PHY in > RX mode. > > Signed-off-by: Luis Oliveira <lolivei@synopsys.com> > --- > Changelog > v2-V3 > - removed gpios reference - it was for a separated driver > - changed address to show complete address > > .../devicetree/bindings/phy/snps,dphy-rx.txt | 28 +++++++++++++++++++ > 1 file changed, 28 insertions(+) > create mode 100644 Documentation/devicetree/bindings/phy/snps,dphy-rx.txt > > diff --git a/Documentation/devicetree/bindings/phy/snps,dphy-rx.txt > b/Documentation/devicetree/bindings/phy/snps,dphy-rx.txt new file mode > 100644 > index 0000000..03d17ab > --- /dev/null > +++ b/Documentation/devicetree/bindings/phy/snps,dphy-rx.txt > @@ -0,0 +1,28 @@ > +Synopsys DesignWare MIPI Rx D-PHY block details > + > +Description > +----------- > + > +The Synopsys MIPI D-PHY controller supports MIPI-DPHY in receiver mode. > +Please refer to phy-bindings.txt for more information. > + > +Required properties: > +- compatible : Shall be "snps,dphy-rx". > +- #phy-cells : Must be 1. > +- snps,dphy-frequency : Output frequency of the D-PHY. You replied to my review of v2 that you would remove this property. Is this an oversight ? > +- snps,dphy-te-len : Size of the communication interface (8 bits->8 or > 12bits->12). > +- reg : Physical base address and size of the device memory mapped > + registers; Please document the ranges. > +Example: > + > + mipi_dphy_rx1: dphy@d00003040 { > + compatible = "snps,dphy-rx"; > + #phy-cells = <1>; > + snps,dphy-frequency = <300000>; > + snps,dphy-te-len = <12>; > + reg = < 0xd0003040 0x20 > + 0xd0008000 0x100 > + 0xd0009000 0x100>; > + }; > +
diff --git a/Documentation/devicetree/bindings/phy/snps,dphy-rx.txt b/Documentation/devicetree/bindings/phy/snps,dphy-rx.txt new file mode 100644 index 0000000..03d17ab --- /dev/null +++ b/Documentation/devicetree/bindings/phy/snps,dphy-rx.txt @@ -0,0 +1,28 @@ +Synopsys DesignWare MIPI Rx D-PHY block details + +Description +----------- + +The Synopsys MIPI D-PHY controller supports MIPI-DPHY in receiver mode. +Please refer to phy-bindings.txt for more information. + +Required properties: +- compatible : Shall be "snps,dphy-rx". +- #phy-cells : Must be 1. +- snps,dphy-frequency : Output frequency of the D-PHY. +- snps,dphy-te-len : Size of the communication interface (8 bits->8 or 12bits->12). +- reg : Physical base address and size of the device memory mapped + registers; + +Example: + + mipi_dphy_rx1: dphy@d00003040 { + compatible = "snps,dphy-rx"; + #phy-cells = <1>; + snps,dphy-frequency = <300000>; + snps,dphy-te-len = <12>; + reg = < 0xd0003040 0x20 + 0xd0008000 0x100 + 0xd0009000 0x100>; + }; +
Add device-tree bindings documentation for SNPS DesignWare MIPI D-PHY in RX mode. Signed-off-by: Luis Oliveira <lolivei@synopsys.com> --- Changelog v2-V3 - removed gpios reference - it was for a separated driver - changed address to show complete address .../devicetree/bindings/phy/snps,dphy-rx.txt | 28 ++++++++++++++++++++++ 1 file changed, 28 insertions(+) create mode 100644 Documentation/devicetree/bindings/phy/snps,dphy-rx.txt -- 2.7.4