| Message ID | 1539883285-7990-2-git-send-email-aisheng.dong@nxp.com |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | [V7,1/3] dt-bindings: fsl: scu: make power domain compatible string SoC specific | expand |
On Thu, 18 Oct 2018 17:25:57 +0000, "A.s. Dong" wrote: > As the power domain API might change in the future for new SoCs, although > in a very low possibility, it's still better to make the compatible string > more SoC specific to avoid the possible version change for new SoCs. > > Due to there're still no users in kernel, it's safe to update it without > breaking anything. > > Cc: Shawn Guo <shawnguo@kernel.org> > Cc: Sascha Hauer <kernel@pengutronix.de> > Cc: Fabio Estevam <fabio.estevam@nxp.com> > Cc: Rob Herring <robh+dt@kernel.org> > Cc: Mark Rutland <mark.rutland@arm.com> > Cc: devicetree@vger.kernel.org > Suggested-by: Sascha Hauer <s.hauer@pengutronix.de> > Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com> > --- > ChangeLog: > v6->v7: > * keep "fsl,scu-pd" as fall back compatible string > v5->v6: > * new patch > --- > Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > Reviewed-by: Rob Herring <robh@kernel.org>
diff --git a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt index 46d0af1..e5f3edf 100644 --- a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt +++ b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt @@ -58,7 +58,9 @@ This binding for the SCU power domain providers uses the generic power domain binding[2]. Required properties: -- compatible: Should be "fsl,scu-pd". +- compatible: Should be one of: + "fsl,imx8qxp-scu-pd" + followed by "fsl,scu-pd" - #address-cells: Should be 1. - #size-cells: Should be 0. @@ -153,7 +155,7 @@ firmware { }; imx8qx-pm { - compatible = "fsl,scu-pd"; + compatible = "fsl,imx8qxp-scu-pd", "fsl,scu-pd"; #address-cells = <1>; #size-cells = <0>;
As the power domain API might change in the future for new SoCs, although in a very low possibility, it's still better to make the compatible string more SoC specific to avoid the possible version change for new SoCs. Due to there're still no users in kernel, it's safe to update it without breaking anything. Cc: Shawn Guo <shawnguo@kernel.org> Cc: Sascha Hauer <kernel@pengutronix.de> Cc: Fabio Estevam <fabio.estevam@nxp.com> Cc: Rob Herring <robh+dt@kernel.org> Cc: Mark Rutland <mark.rutland@arm.com> Cc: devicetree@vger.kernel.org Suggested-by: Sascha Hauer <s.hauer@pengutronix.de> Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com> --- ChangeLog: v6->v7: * keep "fsl,scu-pd" as fall back compatible string v5->v6: * new patch --- Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)