diff mbox series

[iproute] ip-route: Fix parse_encap_seg6() srh parsing

Message ID 20181018134414.32474-1-phil@nwl.cc
State Accepted, archived
Delegated to: stephen hemminger
Headers show
Series [iproute] ip-route: Fix parse_encap_seg6() srh parsing | expand

Commit Message

Phil Sutter Oct. 18, 2018, 1:44 p.m. UTC 
In case caller did not specify 'segs' parameter, parse_srh() would read
garbage while iterating over 'segbuf'. Avoid this by initializing
'segbuf' to an empty string.

Fixes: e8493916a8ede ("iproute: add support for SR-IPv6 lwtunnel encapsulation")
Signed-off-by: Phil Sutter <phil@nwl.cc>
---
 ip/iproute_lwtunnel.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Stephen Hemminger Oct. 22, 2018, 5:08 p.m. UTC | #1 
On Thu, 18 Oct 2018 15:44:14 +0200
Phil Sutter <phil@nwl.cc> wrote:

> In case caller did not specify 'segs' parameter, parse_srh() would read
> garbage while iterating over 'segbuf'. Avoid this by initializing
> 'segbuf' to an empty string.
> 
> Fixes: e8493916a8ede ("iproute: add support for SR-IPv6 lwtunnel encapsulation")
> Signed-off-by: Phil Sutter <phil@nwl.cc>

Applied
diff mbox series

Patch

diff --git a/ip/iproute_lwtunnel.c b/ip/iproute_lwtunnel.c
index 85045d4fff742..4ebfaa7cd6826 100644
--- a/ip/iproute_lwtunnel.c
+++ b/ip/iproute_lwtunnel.c
@@ -494,7 +494,7 @@  static int parse_encap_seg6(struct rtattr *rta, size_t len, int *argcp,
 	struct seg6_iptunnel_encap *tuninfo;
 	struct ipv6_sr_hdr *srh;
 	char **argv = *argvp;
-	char segbuf[1024];
+	char segbuf[1024] = "";
 	int argc = *argcp;
 	int encap = -1;
 	__u32 hmac = 0;