| Message ID | 20181018114154.8886-1-phil@nwl.cc |
|---|---|
| State | Accepted, archived |
| Delegated to: | stephen hemminger |
| Headers | show |
| Series | [iproute] rdma: Fix for ineffective check in add_filter() | expand |
On 10/18/18 5:41 AM, Phil Sutter wrote: > With 'name' field defined as array in struct filters, it will always > contain a value irrespective of whether a name was assigned or not. > > Fix this by turning the field into a const char pointer. > > Fixes: 8cd644095842a ("devlink: Add support for devlink resource abstraction") Stale paste buffer? Seems like the correct tag is Fixes: 1174be72d1b4c ("rdma: Add filtering infrastructure") > Signed-off-by: Phil Sutter <phil@nwl.cc> > --- > rdma/rdma.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/rdma/rdma.h b/rdma/rdma.h > index d4b7ba1918b13..c3b7530b6cc71 100644 > --- a/rdma/rdma.h > +++ b/rdma/rdma.h > @@ -34,7 +34,7 @@ > > #define MAX_NUMBER_OF_FILTERS 64 > struct filters { > - char name[32]; > + const char *name; > bool is_number; > }; > >
Hi, On Thu, Oct 18, 2018 at 09:27:47AM -0600, David Ahern wrote: > On 10/18/18 5:41 AM, Phil Sutter wrote: > > With 'name' field defined as array in struct filters, it will always > > contain a value irrespective of whether a name was assigned or not. > > > > Fix this by turning the field into a const char pointer. > > > > Fixes: 8cd644095842a ("devlink: Add support for devlink resource abstraction") > > Stale paste buffer? Seems like the correct tag is > Fixes: 1174be72d1b4c ("rdma: Add filtering infrastructure") Oh, indeed. Also the wrong person in Cc: Arkadi is innocent, culprit patch came from Leon. Stephen, should I respin or will you correct the Fixes tag? Thanks, Phil
On Thu, 18 Oct 2018 13:41:54 +0200 Phil Sutter <phil@nwl.cc> wrote: > With 'name' field defined as array in struct filters, it will always > contain a value irrespective of whether a name was assigned or not. > > Fix this by turning the field into a const char pointer. > > Fixes: 8cd644095842a ("devlink: Add support for devlink resource abstraction") > Signed-off-by: Phil Sutter <phil@nwl.cc> Applied, and fixed fixes
diff --git a/rdma/rdma.h b/rdma/rdma.h index d4b7ba1918b13..c3b7530b6cc71 100644 --- a/rdma/rdma.h +++ b/rdma/rdma.h @@ -34,7 +34,7 @@ #define MAX_NUMBER_OF_FILTERS 64 struct filters { - char name[32]; + const char *name; bool is_number; };
With 'name' field defined as array in struct filters, it will always contain a value irrespective of whether a name was assigned or not. Fix this by turning the field into a const char pointer. Fixes: 8cd644095842a ("devlink: Add support for devlink resource abstraction") Signed-off-by: Phil Sutter <phil@nwl.cc> --- rdma/rdma.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)