Patchwork [lucid/fsl-imx51] UBUNTU: [Config] Disable parport_pc on fsl-imx51

login
register
mail settings
Submitter Paolo Pisati
Date June 3, 2011, 1:23 p.m.
Message ID <4DE8E034.7080007@canonical.com>
Download mbox | patch
Permalink /patch/98571/
State New
Headers show

Comments

Paolo Pisati - June 3, 2011, 1:23 p.m.
BugLink: http://bugs.launchpad.net/bugs/601226

SRU Justification

Impact: when the parport_pc module is loaded, it triggers a panic (see
https://launchpadlibrarian.net/72913087/imx51-parport.txt)
Stefan Bader - June 6, 2011, 12:09 p.m.
On 03.06.2011 15:23, Paolo Pisati wrote:
> BugLink: http://bugs.launchpad.net/bugs/601226
>
> SRU Justification
>
> Impact: when the parport_pc module is loaded, it triggers a panic (see
> https://launchpadlibrarian.net/72913087/imx51-parport.txt)
>
>
>
Guess arm won't have a pc style parallel port ever...

Acked-by: Stefan Bader <stefan.bader@canonical.com>
Herton Ronaldo Krzesinski - June 6, 2011, 12:28 p.m.
On Fri, Jun 03, 2011 at 03:23:00PM +0200, Paolo Pisati wrote:
> BugLink: http://bugs.launchpad.net/bugs/601226
> 
> SRU Justification
> 
> Impact: when the parport_pc module is loaded, it triggers a panic (see
> https://launchpadlibrarian.net/72913087/imx51-parport.txt)
> 
> 
> -- 
> bye,
> p.
> 

> From f9e80175423bdf75bad1819e9ede01a5ac495745 Mon Sep 17 00:00:00 2001
> From: Paolo Pisati <paolo.pisati@canonical.com>
> Date: Fri, 3 Jun 2011 11:04:04 +0200
> Subject: [PATCH] UBUNTU: [Config] Disable parport_pc on fsl-imx51
> 
> BugLink: http://bugs.launchpad.net/bugs/601226
> 
> Disable parport_pc module to avoid a kernel NULL pointer dereference when
> the module is loaded.

Besides fixing this issue, also can't see any imx51 system which could
have a pc style parallel port.

Acked-by: Herton Ronaldo Krzesinski <herton.krzesinski@canonical.com>

> 
> Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
> ---
>  debian.fsl-imx51/config/config.common.ubuntu |   34 +-------------------------
>  1 files changed, 1 insertions(+), 33 deletions(-)
> 
> diff --git a/debian.fsl-imx51/config/config.common.ubuntu b/debian.fsl-imx51/config/config.common.ubuntu
> index 2598a0a..f91465a 100644
> --- a/debian.fsl-imx51/config/config.common.ubuntu
> +++ b/debian.fsl-imx51/config/config.common.ubuntu
> @@ -1187,9 +1187,6 @@ CONFIG_KINGSUN_DONGLE=m
>  CONFIG_KPROBES=y
>  # CONFIG_KPROBES_SANITY_TEST is not set
>  CONFIG_KRETPROBES=y
> -CONFIG_KS0108=m
> -CONFIG_KS0108_DELAY=2
> -CONFIG_KS0108_PORT=0x378
>  CONFIG_KS8842=m
>  CONFIG_KS8851=m
>  CONFIG_KS959_DONGLE=m
> @@ -1825,37 +1822,12 @@ CONFIG_PANEL=m
>  CONFIG_PANEL_PARPORT=0
>  CONFIG_PANEL_PROFILE=5
>  CONFIG_PANTHERLORD_FF=y
> -CONFIG_PARIDE=m
> -CONFIG_PARIDE_ATEN=m
> -CONFIG_PARIDE_BPCK=m
> -CONFIG_PARIDE_BPCK6=m
> -CONFIG_PARIDE_COMM=m
> -CONFIG_PARIDE_DSTR=m
> -CONFIG_PARIDE_EPAT=m
> -# CONFIG_PARIDE_EPATC8 is not set
> -CONFIG_PARIDE_EPIA=m
> -CONFIG_PARIDE_FIT2=m
> -CONFIG_PARIDE_FIT3=m
> -CONFIG_PARIDE_FRIQ=m
> -CONFIG_PARIDE_FRPW=m
> -CONFIG_PARIDE_KBIC=m
> -CONFIG_PARIDE_KTTI=m
> -CONFIG_PARIDE_ON20=m
> -CONFIG_PARIDE_ON26=m
> -CONFIG_PARIDE_PCD=m
> -CONFIG_PARIDE_PD=m
> -CONFIG_PARIDE_PF=m
> -CONFIG_PARIDE_PG=m
> -CONFIG_PARIDE_PT=m
>  CONFIG_PARPORT=m
>  CONFIG_PARPORT_1284=y
>  CONFIG_PARPORT_AX88796=m
>  # CONFIG_PARPORT_GSC is not set
>  CONFIG_PARPORT_NOT_PC=y
> -CONFIG_PARPORT_PC=m
> -CONFIG_PARPORT_PC_FIFO=y
> -CONFIG_PARPORT_PC_PCMCIA=m
> -# CONFIG_PARPORT_PC_SUPERIO is not set
> +# CONFIG_PARPORT_PC is not set
>  CONFIG_PARTITION_ADVANCED=y
>  CONFIG_PATA_FSL=y
>  CONFIG_PATA_PCMCIA=m
> @@ -2085,11 +2057,8 @@ CONFIG_SCSI_DMA=y
>  CONFIG_SCSI_ENCLOSURE=m
>  CONFIG_SCSI_FC_ATTRS=m
>  CONFIG_SCSI_FC_TGT_ATTRS=y
> -CONFIG_SCSI_IMM=m
>  CONFIG_SCSI_ISCSITARGET=m
>  CONFIG_SCSI_ISCSI_ATTRS=m
> -# CONFIG_SCSI_IZIP_EPP16 is not set
> -# CONFIG_SCSI_IZIP_SLOW_CTR is not set
>  # CONFIG_SCSI_LOGGING is not set
>  CONFIG_SCSI_LOWLEVEL=y
>  CONFIG_SCSI_LOWLEVEL_PCMCIA=y
> @@ -2099,7 +2068,6 @@ CONFIG_SCSI_NETLINK=y
>  CONFIG_SCSI_OSD_DPRINT_SENSE=1
>  CONFIG_SCSI_OSD_INITIATOR=m
>  CONFIG_SCSI_OSD_ULD=m
> -CONFIG_SCSI_PPA=m
>  CONFIG_SCSI_PROC_FS=y
>  CONFIG_SCSI_SAS_ATA=y
>  CONFIG_SCSI_SAS_ATTRS=m
> -- 
> 1.7.4.1
> 
> 

> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team
Tim Gardner - June 6, 2011, 5:34 p.m.
On 06/03/2011 07:23 AM, Paolo Pisati wrote:
> BugLink: http://bugs.launchpad.net/bugs/601226
>
> SRU Justification
>
> Impact: when the parport_pc module is loaded, it triggers a panic (see
> https://launchpadlibrarian.net/72913087/imx51-parport.txt)
>
>
>

I inserted a "Bump ABI" commit at the start of the series, plus I added 
some build glue 
(debian.fsl-imx51/abi/2.6.31-608.25/armel/ignore.modules) to your 
'UBUNTU: [Config] Disable parport_pc on fsl-imx51' patch.

git checkout -f fsl-imx51
git fetch origin && git fetch origin fsl-imx51
git reset --hard FETCH_HEAD

rtg

Patch

From f9e80175423bdf75bad1819e9ede01a5ac495745 Mon Sep 17 00:00:00 2001
From: Paolo Pisati <paolo.pisati@canonical.com>
Date: Fri, 3 Jun 2011 11:04:04 +0200
Subject: [PATCH] UBUNTU: [Config] Disable parport_pc on fsl-imx51

BugLink: http://bugs.launchpad.net/bugs/601226

Disable parport_pc module to avoid a kernel NULL pointer dereference when
the module is loaded.

Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
---
 debian.fsl-imx51/config/config.common.ubuntu |   34 +-------------------------
 1 files changed, 1 insertions(+), 33 deletions(-)

diff --git a/debian.fsl-imx51/config/config.common.ubuntu b/debian.fsl-imx51/config/config.common.ubuntu
index 2598a0a..f91465a 100644
--- a/debian.fsl-imx51/config/config.common.ubuntu
+++ b/debian.fsl-imx51/config/config.common.ubuntu
@@ -1187,9 +1187,6 @@  CONFIG_KINGSUN_DONGLE=m
 CONFIG_KPROBES=y
 # CONFIG_KPROBES_SANITY_TEST is not set
 CONFIG_KRETPROBES=y
-CONFIG_KS0108=m
-CONFIG_KS0108_DELAY=2
-CONFIG_KS0108_PORT=0x378
 CONFIG_KS8842=m
 CONFIG_KS8851=m
 CONFIG_KS959_DONGLE=m
@@ -1825,37 +1822,12 @@  CONFIG_PANEL=m
 CONFIG_PANEL_PARPORT=0
 CONFIG_PANEL_PROFILE=5
 CONFIG_PANTHERLORD_FF=y
-CONFIG_PARIDE=m
-CONFIG_PARIDE_ATEN=m
-CONFIG_PARIDE_BPCK=m
-CONFIG_PARIDE_BPCK6=m
-CONFIG_PARIDE_COMM=m
-CONFIG_PARIDE_DSTR=m
-CONFIG_PARIDE_EPAT=m
-# CONFIG_PARIDE_EPATC8 is not set
-CONFIG_PARIDE_EPIA=m
-CONFIG_PARIDE_FIT2=m
-CONFIG_PARIDE_FIT3=m
-CONFIG_PARIDE_FRIQ=m
-CONFIG_PARIDE_FRPW=m
-CONFIG_PARIDE_KBIC=m
-CONFIG_PARIDE_KTTI=m
-CONFIG_PARIDE_ON20=m
-CONFIG_PARIDE_ON26=m
-CONFIG_PARIDE_PCD=m
-CONFIG_PARIDE_PD=m
-CONFIG_PARIDE_PF=m
-CONFIG_PARIDE_PG=m
-CONFIG_PARIDE_PT=m
 CONFIG_PARPORT=m
 CONFIG_PARPORT_1284=y
 CONFIG_PARPORT_AX88796=m
 # CONFIG_PARPORT_GSC is not set
 CONFIG_PARPORT_NOT_PC=y
-CONFIG_PARPORT_PC=m
-CONFIG_PARPORT_PC_FIFO=y
-CONFIG_PARPORT_PC_PCMCIA=m
-# CONFIG_PARPORT_PC_SUPERIO is not set
+# CONFIG_PARPORT_PC is not set
 CONFIG_PARTITION_ADVANCED=y
 CONFIG_PATA_FSL=y
 CONFIG_PATA_PCMCIA=m
@@ -2085,11 +2057,8 @@  CONFIG_SCSI_DMA=y
 CONFIG_SCSI_ENCLOSURE=m
 CONFIG_SCSI_FC_ATTRS=m
 CONFIG_SCSI_FC_TGT_ATTRS=y
-CONFIG_SCSI_IMM=m
 CONFIG_SCSI_ISCSITARGET=m
 CONFIG_SCSI_ISCSI_ATTRS=m
-# CONFIG_SCSI_IZIP_EPP16 is not set
-# CONFIG_SCSI_IZIP_SLOW_CTR is not set
 # CONFIG_SCSI_LOGGING is not set
 CONFIG_SCSI_LOWLEVEL=y
 CONFIG_SCSI_LOWLEVEL_PCMCIA=y
@@ -2099,7 +2068,6 @@  CONFIG_SCSI_NETLINK=y
 CONFIG_SCSI_OSD_DPRINT_SENSE=1
 CONFIG_SCSI_OSD_INITIATOR=m
 CONFIG_SCSI_OSD_ULD=m
-CONFIG_SCSI_PPA=m
 CONFIG_SCSI_PROC_FS=y
 CONFIG_SCSI_SAS_ATA=y
 CONFIG_SCSI_SAS_ATTRS=m
-- 
1.7.4.1