| Message ID | 1307097169-11744-3-git-send-email-jamie@jamieiles.com |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, 2011-06-03 at 11:32 +0100, Jamie Iles wrote: > The module init exit functions should be annotated with __init and > __exit. > > Cc: David Woodhouse <dwmw2@infradead.org> > Cc: Chuanxiao Dong <chuanxiao.dong@intel.com> > Cc: Artem Bityutskiy <dedekind1@gmail.com> > Signed-off-by: Jamie Iles <jamie@jamieiles.com> Would you please use "mtd: denali:" prefix? I cannot apply this patch because it depends on the previous patch. You could re-structure the code and make simpler patches like this go first, then they could be taken quicker. Thanks!
diff --git a/drivers/mtd/nand/denali.c b/drivers/mtd/nand/denali.c index a4b4a29..491458a 100644 --- a/drivers/mtd/nand/denali.c +++ b/drivers/mtd/nand/denali.c @@ -1686,14 +1686,14 @@ static struct pci_driver denali_pci_driver = { .remove = denali_pci_remove, }; -static int __devinit denali_init(void) +static int __init denali_init(void) { pr_info(KERN_INFO "Spectra MTD driver\n"); return pci_register_driver(&denali_pci_driver); } /* Free memory */ -static void __devexit denali_exit(void) +static void __exit denali_exit(void) { pci_unregister_driver(&denali_pci_driver); }
The module init exit functions should be annotated with __init and __exit. Cc: David Woodhouse <dwmw2@infradead.org> Cc: Chuanxiao Dong <chuanxiao.dong@intel.com> Cc: Artem Bityutskiy <dedekind1@gmail.com> Signed-off-by: Jamie Iles <jamie@jamieiles.com> --- drivers/mtd/nand/denali.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)