| Message ID | 20181017081601.42717-1-netanel@amazon.com |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
| Series | [net-next] net: ena: Fix Kconfig dependencies X86 | expand |
Hello! On 17.10.2018 11:16, netanel@amazon.com wrote: > From: Netanel Belgazal <netanel@amazon.com> > > The Kconfig limitation of X86 is to too wide. > The ENA driver only requires a little endian dependency. > > Change the dependency to be on little endian CPU. > > Signed-off-by: Netanel Belgazal <netanel@amazon.com> > --- > drivers/net/ethernet/amazon/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/amazon/Kconfig b/drivers/net/ethernet/amazon/Kconfig > index 99b30353541a..f4d16c7e104f 100644 > --- a/drivers/net/ethernet/amazon/Kconfig > +++ b/drivers/net/ethernet/amazon/Kconfig > @@ -17,7 +17,7 @@ if NET_VENDOR_AMAZON > > config ENA_ETHERNET > tristate "Elastic Network Adapter (ENA) support" > - depends on (PCI_MSI && X86) > + depends on (PCI_MSI && !CPU_BIG_ENDIAN) Parens not needed here. High time to remove them, I think. [...] MBR, Sergei
Sure.
Removing them and resubmit.
On 10/17/18, 11:37 AM, "Sergei Shtylyov" <sergei.shtylyov@cogentembedded.com> wrote:
Hello!
On 17.10.2018 11:16, netanel@amazon.com wrote:
> From: Netanel Belgazal <netanel@amazon.com>
>
> The Kconfig limitation of X86 is to too wide.
> The ENA driver only requires a little endian dependency.
>
> Change the dependency to be on little endian CPU.
>
> Signed-off-by: Netanel Belgazal <netanel@amazon.com>
> ---
> drivers/net/ethernet/amazon/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/amazon/Kconfig b/drivers/net/ethernet/amazon/Kconfig
> index 99b30353541a..f4d16c7e104f 100644
> --- a/drivers/net/ethernet/amazon/Kconfig
> +++ b/drivers/net/ethernet/amazon/Kconfig
> @@ -17,7 +17,7 @@ if NET_VENDOR_AMAZON
>
> config ENA_ETHERNET
> tristate "Elastic Network Adapter (ENA) support"
> - depends on (PCI_MSI && X86)
> + depends on (PCI_MSI && !CPU_BIG_ENDIAN)
Parens not needed here. High time to remove them, I think.
[...]
MBR, Sergei
diff --git a/drivers/net/ethernet/amazon/Kconfig b/drivers/net/ethernet/amazon/Kconfig index 99b30353541a..f4d16c7e104f 100644 --- a/drivers/net/ethernet/amazon/Kconfig +++ b/drivers/net/ethernet/amazon/Kconfig @@ -17,7 +17,7 @@ if NET_VENDOR_AMAZON config ENA_ETHERNET tristate "Elastic Network Adapter (ENA) support" - depends on (PCI_MSI && X86) + depends on (PCI_MSI && !CPU_BIG_ENDIAN) ---help--- This driver supports Elastic Network Adapter (ENA)"