From patchwork Fri Jun 3 02:06:08 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg Dietsche X-Patchwork-Id: 98510 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 1FDF0B715A for ; Fri, 3 Jun 2011 12:41:50 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752507Ab1FCClk (ORCPT ); Thu, 2 Jun 2011 22:41:40 -0400 Received: from que31.charter.net ([209.225.8.23]:54154 "EHLO que31.charter.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751401Ab1FCCli (ORCPT ); Thu, 2 Jun 2011 22:41:38 -0400 X-Greylist: delayed 428 seconds by postgrey-1.27 at vger.kernel.org; Thu, 02 Jun 2011 22:41:38 EDT Received: from imp09 ([10.20.200.9]) by mta11.charter.net (InterMail vM.7.09.02.04 201-2219-117-106-20090629) with ESMTP id <20110603021207.DZSA29959.mta11.charter.net@imp09>; Thu, 2 Jun 2011 22:12:07 -0400 Received: from www.farmergreg.com ([96.42.32.177]) by imp09 with smtp.charter.net id rEC71g0083pHlLY05EC7bk; Thu, 02 Jun 2011 22:12:07 -0400 X-Authority-Analysis: v=1.1 cv=1b2X7W/SifksZeClH/haT1SUt4udqxFGF00pZw2/jJk= c=1 sm=1 a=Ihstlyeb0LIA:10 a=lDGNyK2vIvEA:10 a=xzrYXqw+0zwiO4gHSXHcAg==:17 a=KeKsPS5gM2DD1xSM1Q8A:9 a=xzrYXqw+0zwiO4gHSXHcAg==:117 Received: from red.farmergreg.com ([10.0.0.128]) by www.farmergreg.com with esmtp (Exim 4.72) (envelope-from ) id 1QSJrr-00014b-Cg; Thu, 02 Jun 2011 21:12:07 -0500 Received: from greg by red.farmergreg.com with local (Exim 4.72) (envelope-from ) id 1QSJrt-000781-0H; Thu, 02 Jun 2011 21:12:09 -0500 From: Greg Dietsche To: sgruszka@redhat.com, linville@tuxdriver.com Cc: kernel-janitors@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Dietsche Subject: [PATCH 3/5] iwlegacy: return -EINVAL instead of -1 Date: Thu, 2 Jun 2011 21:06:08 -0500 Message-Id: <1307066770-27309-3-git-send-email-Gregory.Dietsche@cuw.edu> X-Mailer: git-send-email 1.7.2.5 In-Reply-To: <1307066770-27309-1-git-send-email-Gregory.Dietsche@cuw.edu> References: <1307066770-27309-1-git-send-email-Gregory.Dietsche@cuw.edu> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Cleanup the code to return -EINVAL instead of -1 Signed-off-by: Greg Dietsche --- drivers/net/wireless/iwlegacy/iwl-4965.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/wireless/iwlegacy/iwl-4965.c b/drivers/net/wireless/iwlegacy/iwl-4965.c index ffda05c..06dcee5 100644 --- a/drivers/net/wireless/iwlegacy/iwl-4965.c +++ b/drivers/net/wireless/iwlegacy/iwl-4965.c @@ -496,7 +496,7 @@ static s32 iwl4965_get_tx_atten_grp(u16 channel) channel <= CALIB_IWL_TX_ATTEN_GR4_LCH) return CALIB_CH_GROUP_4; - return -1; + return -EINVAL; } static u32 iwl4965_get_sub_band(const struct iwl_priv *priv, u32 channel)