Patchwork qlcnic: Fix bug in FW queue dump

login
register
mail settings
Submitter Anirban Chakraborty
Date June 2, 2011, 10:42 p.m.
Message ID <1307054541-11178-1-git-send-email-anirban.chakraborty@qlogic.com>
Download mbox | patch
Permalink /patch/98494/
State Accepted
Delegated to: David Miller
Headers show

Comments

Anirban Chakraborty - June 2, 2011, 10:42 p.m.
Due to a change in FW template, a bug was introduced in dump queue entries. This is
fixed by reinitializing queue address before looping for each que dump operation.

Signed-off-by: Anirban Chakraborty <anirban.chakraborty@qlogic.com>
---
 drivers/net/qlcnic/qlcnic_hw.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
David Miller - June 5, 2011, 9:18 p.m.
From: Anirban Chakraborty <anirban.chakraborty@qlogic.com>
Date: Thu,  2 Jun 2011 15:42:21 -0700

> Due to a change in FW template, a bug was introduced in dump queue entries. This is
> fixed by reinitializing queue address before looping for each que dump operation.
> 
> Signed-off-by: Anirban Chakraborty <anirban.chakraborty@qlogic.com>

Applied.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/net/qlcnic/qlcnic_hw.c b/drivers/net/qlcnic/qlcnic_hw.c
index e965661..a5d9fbf 100644
--- a/drivers/net/qlcnic/qlcnic_hw.c
+++ b/drivers/net/qlcnic/qlcnic_hw.c
@@ -1406,6 +1406,7 @@  qlcnic_dump_que(struct qlcnic_adapter *adapter, struct qlcnic_dump_entry *entry,
 
 	for (loop = 0; loop < que->no_ops; loop++) {
 		QLCNIC_WR_DUMP_REG(que->sel_addr, base, que_id);
+		addr = que->read_addr;
 		for (i = 0; i < cnt; i++) {
 			QLCNIC_RD_DUMP_REG(addr, base, &data);
 			*buffer++ = cpu_to_le32(data);