diff mbox series

acpica: fix linker issues when building with ACPI disabled

Message ID 20181016153846.28424-1-colin.king@canonical.com
State Accepted
Headers show
Series acpica: fix linker issues when building with ACPI disabled | expand

Commit Message

Colin Ian King Oct. 16, 2018, 3:38 p.m. UTC 
From: Colin Ian King <colin.king@canonical.com>

Some toolchains hit linker issues with missing symbols when
building with ACPI disabled.  Work around this by declaring
these symbols even though they are never referenced.

Works around PPC REHL 7.6 build issue:

/root/fwts/src/acpica/.libs/libfwtsacpica.so: undefined reference to
`AcpiGbl_InitEntries'
/root/fwts/src/acpica/.libs/libfwtsacpica.so: undefined reference to
`AcpiGbl_InitFileLineCount'

Fixes: 24f2f2bfbb8f ("ACPICA: Update to version 20180810")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 src/acpica/fwts_acpica.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Alex Hung Oct. 17, 2018, 5:37 a.m. UTC | #1 
On 2018-10-16 11:38 p.m., Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> Some toolchains hit linker issues with missing symbols when
> building with ACPI disabled.  Work around this by declaring
> these symbols even though they are never referenced.
> 
> Works around PPC REHL 7.6 build issue:
> 
> /root/fwts/src/acpica/.libs/libfwtsacpica.so: undefined reference to
> `AcpiGbl_InitEntries'
> /root/fwts/src/acpica/.libs/libfwtsacpica.so: undefined reference to
> `AcpiGbl_InitFileLineCount'
> 
> Fixes: 24f2f2bfbb8f ("ACPICA: Update to version 20180810")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  src/acpica/fwts_acpica.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/src/acpica/fwts_acpica.c b/src/acpica/fwts_acpica.c
> index 4ffe80fd..d0c6ed7c 100644
> --- a/src/acpica/fwts_acpica.c
> +++ b/src/acpica/fwts_acpica.c
> @@ -1373,5 +1373,7 @@ VOID_FUNC(MpSaveSerialInfo)
>   */
>  unsigned char AcpiGbl_AbortLoopOnTimeout = FALSE;
>  unsigned char AcpiGbl_VerboseHandlers = FALSE;
> +void *AcpiGbl_InitEntries = NULL;
> +uint32_t AcpiGbl_InitFileLineCount = 0;
>  
>  #endif
> 



Acked-by: Alex Hung <alex.hung@canonical.com>
Ivan Hu Oct. 22, 2018, 3:06 a.m. UTC | #2 
On 10/16/18 11:38 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Some toolchains hit linker issues with missing symbols when
> building with ACPI disabled.  Work around this by declaring
> these symbols even though they are never referenced.
>
> Works around PPC REHL 7.6 build issue:
>
> /root/fwts/src/acpica/.libs/libfwtsacpica.so: undefined reference to
> `AcpiGbl_InitEntries'
> /root/fwts/src/acpica/.libs/libfwtsacpica.so: undefined reference to
> `AcpiGbl_InitFileLineCount'
>
> Fixes: 24f2f2bfbb8f ("ACPICA: Update to version 20180810")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  src/acpica/fwts_acpica.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/src/acpica/fwts_acpica.c b/src/acpica/fwts_acpica.c
> index 4ffe80fd..d0c6ed7c 100644
> --- a/src/acpica/fwts_acpica.c
> +++ b/src/acpica/fwts_acpica.c
> @@ -1373,5 +1373,7 @@ VOID_FUNC(MpSaveSerialInfo)
>   */
>  unsigned char AcpiGbl_AbortLoopOnTimeout = FALSE;
>  unsigned char AcpiGbl_VerboseHandlers = FALSE;
> +void *AcpiGbl_InitEntries = NULL;
> +uint32_t AcpiGbl_InitFileLineCount = 0;
>  
>  #endif


Acked-by: Ivan Hu <ivan.hu@canonical.com>
diff mbox series

Patch

diff --git a/src/acpica/fwts_acpica.c b/src/acpica/fwts_acpica.c
index 4ffe80fd..d0c6ed7c 100644
--- a/src/acpica/fwts_acpica.c
+++ b/src/acpica/fwts_acpica.c
@@ -1373,5 +1373,7 @@  VOID_FUNC(MpSaveSerialInfo)
  */
 unsigned char AcpiGbl_AbortLoopOnTimeout = FALSE;
 unsigned char AcpiGbl_VerboseHandlers = FALSE;
+void *AcpiGbl_InitEntries = NULL;
+uint32_t AcpiGbl_InitFileLineCount = 0;
 
 #endif