| Message ID | 20181015065157.3634-2-maozhongyi@cmss.chinamobile.com |
|---|---|
| State | New |
| Headers | show |
| Series | [1/3] archive-source.sh: Modern shell scripting (use $() instead of ``) | expand |
On 2018-10-15 08:51, Mao Zhongyi wrote: > Various shell files contain a mix between obsolete `` and > modern $(); use of `` is only required when using /bin/sh > on Solaris. It would be nice to convert to using $() > everywhere, or at least in all bash scripts, as well as in > all scripts that are known to not be run on Solaris. > > Signed-off-by: Mao Zhongyi <maozhongyi@cmss.chinamobile.com> > --- > scripts/git-submodule.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/git-submodule.sh b/scripts/git-submodule.sh > index 807ca0b4f8..d452149c1a 100755 > --- a/scripts/git-submodule.sh > +++ b/scripts/git-submodule.sh > @@ -59,7 +59,7 @@ status) > fi > > test -f "$substat" || exit 1 > - CURSTATUS=`$GIT submodule status $modules` > + CURSTATUS=$($GIT submodule status $modules) > OLDSTATUS=`cat $substat` > test "$CURSTATUS" = "$OLDSTATUS" > exit $? > Reviewed-by: Thomas Huth <thuth@redhat.com>
diff --git a/scripts/git-submodule.sh b/scripts/git-submodule.sh index 807ca0b4f8..d452149c1a 100755 --- a/scripts/git-submodule.sh +++ b/scripts/git-submodule.sh @@ -59,7 +59,7 @@ status) fi test -f "$substat" || exit 1 - CURSTATUS=`$GIT submodule status $modules` + CURSTATUS=$($GIT submodule status $modules) OLDSTATUS=`cat $substat` test "$CURSTATUS" = "$OLDSTATUS" exit $?
Various shell files contain a mix between obsolete `` and modern $(); use of `` is only required when using /bin/sh on Solaris. It would be nice to convert to using $() everywhere, or at least in all bash scripts, as well as in all scripts that are known to not be run on Solaris. Signed-off-by: Mao Zhongyi <maozhongyi@cmss.chinamobile.com> --- scripts/git-submodule.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)