From patchwork Thu Jun 2 05:52:05 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Connor Hansen X-Patchwork-Id: 98350 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 6FC3AB6F9A for ; Thu, 2 Jun 2011 15:52:32 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932371Ab1FBFwN (ORCPT ); Thu, 2 Jun 2011 01:52:13 -0400 Received: from mail-px0-f179.google.com ([209.85.212.179]:60574 "EHLO mail-px0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932362Ab1FBFwK (ORCPT ); Thu, 2 Jun 2011 01:52:10 -0400 Received: by pxi2 with SMTP id 2so369027pxi.10 for ; Wed, 01 Jun 2011 22:52:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:from:to:cc:subject:date:message-id:x-mailer; bh=w7dcX8LIiWz8Phn1ZXajjiuYiW86vlOd5p3Fktlw3Vs=; b=oRZ9jT3UyCKG1mWHayVmQVjkVa337Ygeo4DoOwBbUq7Osf3RFBMDUgwh3dFMAxGpY9 WUyHl6/h31qsqjk4LMiC/JoBV/3cV5sg6UNQfO4LkQa4xledHCybfPnHwyWpJvq4LJWl +aUMGcwJFGM+3BlLazndHV3G4adpBkvmwlmk8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer; b=FrH+PcihIZ3teVRTp5NGu3tihqs/E3/PbRlRxMB+4nAlyRUGQ7ghhQLH4N3W/GV7n/ OMG4cXis6W8PFsvPIN6KAnrYcRGVZ9dxlGwfZP2mki0ihUXk82sQMnj3BgB3cquQiBHM GDiaQzuCMDe1CxrXn1UvOF7a7TxZJDa7MHr4E= Received: by 10.142.62.9 with SMTP id k9mr51667wfa.162.1306993930360; Wed, 01 Jun 2011 22:52:10 -0700 (PDT) Received: from localhost.localdomain (c-71-197-87-91.hsd1.ca.comcast.net [71.197.87.91]) by mx.google.com with ESMTPS id f10sm214176wfe.12.2011.06.01.22.52.09 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 01 Jun 2011 22:52:09 -0700 (PDT) From: Connor Hansen To: davem@davemloft.net Cc: bp@alien8.de, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, Connor Hansen Subject: [PATCH] ide-cd: signedness warning fix again Date: Wed, 1 Jun 2011 22:52:05 -0700 Message-Id: <1306993925-26044-1-git-send-email-cmdkhh@gmail.com> X-Mailer: git-send-email 1.7.4.4 Sender: linux-ide-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org One of the legit warnings 'make W=3 drivers/ide/ide-cd.c' generates is: drivers/ide/ide-cd.c: In function ide_cd_do_request drivers/ide/ide-cd.c:828:2: warning: conversion to int from \ unsigned int may change the sign of the result drivers/ide/ide-cd.c:833:2: warning: conversion to int from \ unsigned int may change the sign of the result nsectors is declared int, should be unsigned int. blk_rq-sectors() returns unsigned int, and ide_complete_rq expects unsigned int as well. Fixes both warnings. Signed-off-by: Connor Hansen --- drivers/ide/ide-cd.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/ide/ide-cd.c b/drivers/ide/ide-cd.c index 5d17ab4..0a61f63 100644 --- a/drivers/ide/ide-cd.c +++ b/drivers/ide/ide-cd.c @@ -778,7 +778,8 @@ static ide_startstop_t ide_cd_do_request(ide_drive_t *drive, struct request *rq, sector_t block) { struct ide_cmd cmd; - int uptodate = 0, nsectors; + int uptodate = 0; + unsigned int nsectors; ide_debug_log(IDE_DBG_RQ, "cmd: 0x%x, block: %llu", rq->cmd[0], (unsigned long long)block);