diff mbox series

[-next] gpio: fix SNPS_CREG kconfig dependency warning

Message ID 8bfd2cd6-702a-878c-ac41-b61698835f1a@infradead.org
State New
Headers show
Series [-next] gpio: fix SNPS_CREG kconfig dependency warning | expand

Commit Message

Randy Dunlap Oct. 13, 2018, 3:46 a.m. UTC 
From: Randy Dunlap <rdunlap@infradead.org>

Fix kconfig warning for GPIO_SNPS_CREG:

WARNING: unmet direct dependencies detected for OF_GPIO
  Depends on [n]: GPIOLIB [=y] && OF [=n] && HAS_IOMEM [=y]
  Selected by [y]:
  - GPIO_SNPS_CREG [=y] && GPIOLIB [=y] && HAS_IOMEM [=y] && (ARC || COMPILE_TEST [=y])

Drivers in drivers/gpio/Kconfig depend on OF_GPIO, not select it.
This prevents attempting to build when OF is not enabled.

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-gpio@vger.kernel.org
Cc: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>
---
Found in mmotm but comes from/applies to linux-next.

 drivers/gpio/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Linus Walleij Oct. 15, 2018, 2:24 p.m. UTC | #1 
On Sat, Oct 13, 2018 at 5:46 AM Randy Dunlap <rdunlap@infradead.org> wrote:

> From: Randy Dunlap <rdunlap@infradead.org>
>
> Fix kconfig warning for GPIO_SNPS_CREG:
>
> WARNING: unmet direct dependencies detected for OF_GPIO
>   Depends on [n]: GPIOLIB [=y] && OF [=n] && HAS_IOMEM [=y]
>   Selected by [y]:
>   - GPIO_SNPS_CREG [=y] && GPIOLIB [=y] && HAS_IOMEM [=y] && (ARC || COMPILE_TEST [=y])
>
> Drivers in drivers/gpio/Kconfig depend on OF_GPIO, not select it.
> This prevents attempting to build when OF is not enabled.
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: linux-gpio@vger.kernel.org
> Cc: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>
> ---
> Found in mmotm but comes from/applies to linux-next.

Patch applied, thanks!

Yours,
Linus Walleij
diff mbox series

Patch

--- linux-next-20181012.orig/drivers/gpio/Kconfig
+++ linux-next-20181012/drivers/gpio/Kconfig
@@ -439,7 +439,7 @@  config GPIO_SIOX
 config GPIO_SNPS_CREG
 	bool "Synopsys GPIO via CREG (Control REGisters) driver"
 	depends on ARC || COMPILE_TEST
-	select OF_GPIO
+	depends on OF_GPIO
 	help
 	  This driver supports GPIOs via CREG on various Synopsys SoCs.
 	  This is a single-register MMIO GPIO driver for complex cases