[1/1] utils/get-developers: fix syntax error

Message ID 20181011230050.28593-1-greg@quimbo.fr
State Accepted
Commit 8320ad3341b9242eaf82df7a4d4c1a367991ec3d
Headers show
Series
  • [1/1] utils/get-developers: fix syntax error
Related show

Commit Message

Grégoire Delattre Oct. 11, 2018, 11 p.m.
From: Grégoire Delattre <gregoire.delattre@gmail.com>

This fixes a syntax error introduced in bcf2ed5cc3.

Output before the patch:
    $ ./utils/get-developers outgoing/*
        File "./utils/get-developers", line 97
            print dev
                    ^
        SyntaxError: Missing parentheses in call to 'print'. Did you mean
        print(dev)?

Output after the patch:
    $ ./utils/get-developers outgoing/*
    git send-email --to buildroot@buildroot.org

Signed-off-by: Grégoire Delattre <gregoire.delattre@gmail.com>
---
 utils/get-developers | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Peter Korsgaard Oct. 12, 2018, 7:05 a.m. | #1
>>>>> "Grégoire" == Grégoire Delattre <greg@quimbo.fr> writes:

 > From: Grégoire Delattre <gregoire.delattre@gmail.com>
 > This fixes a syntax error introduced in bcf2ed5cc3.

 > Output before the patch:
 >     $ ./utils/get-developers outgoing/*
 >         File "./utils/get-developers", line 97
 >             print dev
 >                     ^
 >         SyntaxError: Missing parentheses in call to 'print'. Did you mean
 >         print(dev)?

 > Output after the patch:
 >     $ ./utils/get-developers outgoing/*
 >     git send-email --to buildroot@buildroot.org

Ahh, indeed - We need print(foo) instead of print foo for python 3.x
compatibility.

Committed with the commit message extended to explain that this is for
python 3.x, thanks.

Patch

diff --git a/utils/get-developers b/utils/get-developers
index 9135b41662..ce882e6699 100755
--- a/utils/get-developers
+++ b/utils/get-developers
@@ -94,7 +94,7 @@  def __main__():
 
         if args.email:
             for dev in matching_devs:
-                print dev
+                print(dev)
         else:
             result = "--to buildroot@buildroot.org"
             for dev in matching_devs: