From patchwork Thu Oct 11 21:45:40 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pablo Neira Ayuso X-Patchwork-Id: 982747 X-Patchwork-Delegate: pablo@netfilter.org Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netfilter-devel-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=netfilter.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 42WPfb4Y1qz9s89 for ; Fri, 12 Oct 2018 08:45:59 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726754AbeJLFPC (ORCPT ); Fri, 12 Oct 2018 01:15:02 -0400 Received: from mail.us.es ([193.147.175.20]:40726 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725956AbeJLFPC (ORCPT ); Fri, 12 Oct 2018 01:15:02 -0400 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id 2EC141E5342 for ; Thu, 11 Oct 2018 23:45:50 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 1FE6CDA8F5 for ; Thu, 11 Oct 2018 23:45:50 +0200 (CEST) Received: by antivirus1-rhel7.int (Postfix, from userid 99) id 15AB8DA8F0; Thu, 11 Oct 2018 23:45:50 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on antivirus1-rhel7.int X-Spam-Level: X-Spam-Status: No, score=-108.2 required=7.5 tests=ALL_TRUSTED,BAYES_50, SMTPAUTH_US2,USER_IN_WHITELIST autolearn=disabled version=3.4.1 Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 52354DA8F2; Thu, 11 Oct 2018 23:45:48 +0200 (CEST) Received: from 192.168.1.97 (192.168.1.97) by antivirus1-rhel7.int (F-Secure/fsigk_smtp/550/antivirus1-rhel7.int); Thu, 11 Oct 2018 23:45:48 +0200 (CEST) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int) Received: from salvia.here (unknown [31.4.241.169]) (Authenticated sender: pneira@us.es) by entrada.int (Postfix) with ESMTPA id 72AD74265A32; Thu, 11 Oct 2018 23:45:46 +0200 (CEST) X-SMTPAUTHUS: auth mail.us.es From: Pablo Neira Ayuso To: netfilter-devel@vger.kernel.org Cc: fw@strlen.de, steffen.klassert@secunet.com Subject: [PATCH nf-next] netfilter: nft_flow_offload: remove secpath check Date: Thu, 11 Oct 2018 23:45:40 +0200 Message-Id: <20181011214540.320-1-pablo@netfilter.org> X-Mailer: git-send-email 2.11.0 X-Virus-Scanned: ClamAV using ClamSMTP Sender: netfilter-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org It is safe to place a flow that is coming from IPSec into the flowtable. So decapsulated can benefit from the flowtable fastpath. Signed-off-by: Pablo Neira Ayuso Signed-off-by: Steffen Klassert --- I'm recovering this patch, this enables faster flowtable forwarding from ingress. Florian has been asking for a way to restore the xfrm cache, and I remember Steffen mentioned this two liner should be just enough to combine the flowtable infrastructure with ipsec. net/netfilter/nft_flow_offload.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/net/netfilter/nft_flow_offload.c b/net/netfilter/nft_flow_offload.c index d6bab8c3cbb0..bb21748153ae 100644 --- a/net/netfilter/nft_flow_offload.c +++ b/net/netfilter/nft_flow_offload.c @@ -54,8 +54,6 @@ static bool nft_flow_offload_skip(struct sk_buff *skb) if (unlikely(opt->optlen)) return true; - if (skb_sec_path(skb)) - return true; return false; }