From patchwork Thu Oct 11 20:58:29 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Sebor X-Patchwork-Id: 982725 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=gcc-patches-return-487394-incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="EhxK6GQJ"; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="VWXP3Nl4"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 42WNc51mqjz9sBZ for ; Fri, 12 Oct 2018 07:58:44 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:to :from:subject:message-id:date:mime-version:content-type; q=dns; s=default; b=f+vG/bySZGGtJkKXW3+EhYfpia9wihNq8cXDT/7vtZt191G+KH s82Ln+6kKf1u2cFjJIJks8/y/nlrYZp7b2kU5hA0E9voCafd9M9Jre2BKyfNgAx+ sMJu1hi8RQcONDsHAtR7tGFFIf4oPsqVuQRkcVUIb7Jd0mEbeb17SU7gY= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:to :from:subject:message-id:date:mime-version:content-type; s= default; bh=yrwdoHBm4BObENmrmuR7tJpXls8=; b=EhxK6GQJKgSMk2QrFtma +gOZ+bvrbJXFGJ0LMfqgb7SaVqvOGy2/YRgjgNlObXmeFMRYD0raGVZSi5FeQ7D1 5YzXtH30UhWwGCf5oR9ROofrVT5otelVgHEebzekluNQAxtZydivRAX+jGBYTlP+ lTjhBju5M/o9lIsCpyHoJyQ= Received: (qmail 107683 invoked by alias); 11 Oct 2018 20:58:37 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 107664 invoked by uid 89); 11 Oct 2018 20:58:36 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-24.4 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.2 spammy=mentions, Mention X-HELO: mail-qk1-f171.google.com Received: from mail-qk1-f171.google.com (HELO mail-qk1-f171.google.com) (209.85.222.171) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 11 Oct 2018 20:58:34 +0000 Received: by mail-qk1-f171.google.com with SMTP id 23-v6so6387791qkh.8 for ; Thu, 11 Oct 2018 13:58:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=to:from:subject:message-id:date:user-agent:mime-version; bh=nFACZY0NFedyJ7oPfbSuXVyoTf2t7CR241o6Oa7I44k=; b=VWXP3Nl4Q6bQ41RnVcYXjnHVup807pS//jbLfUs5raYdbtDbPm3hT47JJA9JNay2Mq G8PEfHkdmq2xh6ij9x1Pya05ttJJ7yrNSeBPPH8ob1inQPTkF04tLVOwbIDfzkuKNfhw MQpF8WvHJ46mIqrQGZ1b3idEWjTSY42kqAAKJjxb3SuJYzAcCu4z9ykAZFKEJ18Reseb 8v6kZaw3u//3j22kfTL04PJLGtNyMz9NJEI7PZj7EdwnDx10+iuSCUWHFMe5ve+7psNU 1j2wtNlJtBaUHQyFJORwecPVfLgt9ZDoaQssU+EWiY4M3mnVr156lDnAJp1VxRIferpy 4U2Q== Received: from localhost.localdomain (184-96-225-137.hlrn.qwest.net. [184.96.225.137]) by smtp.gmail.com with ESMTPSA id f85-v6sm18453833qkh.35.2018.10.11.13.58.30 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 11 Oct 2018 13:58:31 -0700 (PDT) To: Gcc Patch List From: Martin Sebor Subject: [doc PATCH] mention interaction with noinline in flatten Message-ID: Date: Thu, 11 Oct 2018 14:58:29 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 X-IsSubscribed: yes While writing tests for attribute flatten I wasn't 100% sure from reading the manual if it would respect attribute noinline or if it would override it. Turns out it's the former so the attached patch mentions it in the manual. Unless there are objections I will commit the change tomorrow. Martin gcc/ChangeLog: * doc/extend.texi (attribute flatten): Mention interaction with noinline. diff --git a/gcc/doc/extend.texi b/gcc/doc/extend.texi index 0d9b99f..d6f4630 100644 --- a/gcc/doc/extend.texi +++ b/gcc/doc/extend.texi @@ -2615,8 +2615,9 @@ explicit @code{externally_visible} attributes are still necessary. @cindex @code{flatten} function attribute Generally, inlining into a function is limited. For a function marked with this attribute, every call inside this function is inlined, if possible. -Whether the function itself is considered for inlining depends on its size and -the current inlining parameters. +Functions declared with attribute @code{noinline} and similar are not +inlined. Whether the function itself is considered for inlining depends +on its size and the current inlining parameters. @item format (@var{archetype}, @var{string-index}, @var{first-to-check}) @cindex @code{format} function attribute