[nft,5/8] monitor: Drop 'update table' and 'update chain' cases

Message ID 20181011154901.20082-6-phil@nwl.cc
State Accepted
Delegated to: Pablo Neira
Headers show
Series
  • monitor: Use libnftables for JSON output
Related show

Commit Message

Phil Sutter Oct. 11, 2018, 3:48 p.m.
There seems to be no situation where this comes to play. Also, since
there is no 'nft update table/chain' command, this is inconsistent with
input.

Signed-off-by: Phil Sutter <phil@nwl.cc>
---
 src/monitor.c | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

Patch

diff --git a/src/monitor.c b/src/monitor.c
index d75410888e3d0..3e70b89f0b2ab 100644
--- a/src/monitor.c
+++ b/src/monitor.c
@@ -186,10 +186,7 @@  static int netlink_events_table_cb(const struct nlmsghdr *nlh, int type,
 	switch (monh->format) {
 	case NFTNL_OUTPUT_DEFAULT:
 		if (type == NFT_MSG_NEWTABLE) {
-			if (nlh->nlmsg_flags & NLM_F_EXCL)
-				nft_mon_print(monh, "update table ");
-			else
-				nft_mon_print(monh, "add table ");
+			nft_mon_print(monh, "add table ");
 		} else {
 			nft_mon_print(monh, "delete table ");
 		}
@@ -227,10 +224,7 @@  static int netlink_events_chain_cb(const struct nlmsghdr *nlh, int type,
 	case NFTNL_OUTPUT_DEFAULT:
 		switch (type) {
 		case NFT_MSG_NEWCHAIN:
-			if (nlh->nlmsg_flags & NLM_F_EXCL)
-				nft_mon_print(monh, "update ");
-			else
-				nft_mon_print(monh, "add ");
+			nft_mon_print(monh, "add ");
 
 			c = netlink_delinearize_chain(monh->ctx, nlc);
 			chain_print_plain(c, monh->ctx->octx);