| Message ID | 20181011111501.21533-1-xypron.glpk@gmx.de |
|---|---|
| State | Accepted |
| Commit | 95187bb7cbb95c1074ad17ccc3822d83d972210d |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | [U-Boot,1/1] cmd/bdinfo: correct output of numerical values | expand |
On Thu, Oct 11, 2018 at 01:15:01PM +0200, Heinrich Schuchardt wrote: > Display all digits on 64bit systems. Currently we print only the lower > 32 bits. Examples of values that can exceed 32 bits are the size and start of > memory banks. > > For fdt_blob use the same output method as for other values. This avoids > misalignment. > > Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> Applied to u-boot/master, thanks!
diff --git a/cmd/bdinfo.c b/cmd/bdinfo.c index 60b438766d..cbeba6ba28 100644 --- a/cmd/bdinfo.c +++ b/cmd/bdinfo.c @@ -16,7 +16,7 @@ DECLARE_GLOBAL_DATA_PTR; __maybe_unused static void print_num(const char *name, ulong value) { - printf("%-12s= 0x%08lX\n", name, value); + printf("%-12s= 0x%0*lx\n", name, 2 * (int)sizeof(value), value); } __maybe_unused @@ -348,7 +348,7 @@ static int do_bdinfo(cmd_tbl_t *cmdtp, int flag, int argc, CONFIG_VAL(SYS_MALLOC_F_LEN)); #endif if (gd->fdt_blob) - printf("fdt_blob = %p\n", gd->fdt_blob); + print_num("fdt_blob", (ulong)gd->fdt_blob); return 0; }
Display all digits on 64bit systems. Currently we print only the lower 32 bits. Examples of values that can exceed 32 bits are the size and start of memory banks. For fdt_blob use the same output method as for other values. This avoids misalignment. Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> --- cmd/bdinfo.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)