[1/1] UBUNTU: SAUCE: arm64: dts: msm8916: camms: fix gic_irq_domain_translate warnings

Message ID 1539182932-23440-2-git-send-email-paolo.pisati@canonical.com
State New
Headers show
Series
  • [1/1] UBUNTU: SAUCE: arm64: dts: msm8916: camms: fix gic_irq_domain_translate warnings
Related show

Commit Message

Paolo Pisati Oct. 10, 2018, 2:48 p.m.
BugLink: https://bugs.launchpad.net/bugs/1797143

Remove the usage of IRQ_TYPE_NONE to fix loud warnings from
patch (83a86fbb5b56b "irqchip/gic: Loudly complain about
the use of IRQ_TYPE_NONE").

Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
---
 arch/arm64/boot/dts/qcom/msm8916.dtsi | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

Comments

Colin King Oct. 10, 2018, 2:50 p.m. | #1
On 10/10/18 15:48, Paolo Pisati wrote:
> BugLink: https://bugs.launchpad.net/bugs/1797143
> 
> Remove the usage of IRQ_TYPE_NONE to fix loud warnings from
> patch (83a86fbb5b56b "irqchip/gic: Loudly complain about
> the use of IRQ_TYPE_NONE").
> 
> Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
> ---
>  arch/arm64/boot/dts/qcom/msm8916.dtsi | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi
> index 51df6d37250c..03df1c2d56ef 100644
> --- a/arch/arm64/boot/dts/qcom/msm8916.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi
> @@ -1478,12 +1478,12 @@
>  				"ispif",
>  				"csi_clk_mux",
>  				"vfe0";
> -			interrupts = <GIC_SPI 78 0>,
> -				<GIC_SPI 79 0>,
> -				<GIC_SPI 51 0>,
> -				<GIC_SPI 52 0>,
> -				<GIC_SPI 55 0>,
> -				<GIC_SPI 57 0>;
> +			interrupts = <GIC_SPI 78 IRQ_TYPE_LEVEL_HIGH>,
> +				<GIC_SPI 79 IRQ_TYPE_LEVEL_HIGH>,
> +				<GIC_SPI 51 IRQ_TYPE_LEVEL_HIGH>,
> +				<GIC_SPI 52 IRQ_TYPE_LEVEL_HIGH>,
> +				<GIC_SPI 55 IRQ_TYPE_LEVEL_HIGH>,
> +				<GIC_SPI 57 IRQ_TYPE_LEVEL_HIGH>;
>  			interrupt-names = "csiphy0",
>  				"csiphy1",
>  				"csid0",
> 

Silence is golden for this warnings.

Acked-by: Colin Ian King <colin.king@canonical.com>
Stefan Bader Oct. 11, 2018, 7:55 a.m. | #2
On 10.10.2018 16:48, Paolo Pisati wrote:
> BugLink: https://bugs.launchpad.net/bugs/1797143
> 
> Remove the usage of IRQ_TYPE_NONE to fix loud warnings from
> patch (83a86fbb5b56b "irqchip/gic: Loudly complain about
> the use of IRQ_TYPE_NONE").
> 
> Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
Acked-by: Stefan Bader <stefan.bader@canonical.com>
> ---
>  arch/arm64/boot/dts/qcom/msm8916.dtsi | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi
> index 51df6d37250c..03df1c2d56ef 100644
> --- a/arch/arm64/boot/dts/qcom/msm8916.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi
> @@ -1478,12 +1478,12 @@
>  				"ispif",
>  				"csi_clk_mux",
>  				"vfe0";
> -			interrupts = <GIC_SPI 78 0>,
> -				<GIC_SPI 79 0>,
> -				<GIC_SPI 51 0>,
> -				<GIC_SPI 52 0>,
> -				<GIC_SPI 55 0>,
> -				<GIC_SPI 57 0>;
> +			interrupts = <GIC_SPI 78 IRQ_TYPE_LEVEL_HIGH>,
> +				<GIC_SPI 79 IRQ_TYPE_LEVEL_HIGH>,
> +				<GIC_SPI 51 IRQ_TYPE_LEVEL_HIGH>,
> +				<GIC_SPI 52 IRQ_TYPE_LEVEL_HIGH>,
> +				<GIC_SPI 55 IRQ_TYPE_LEVEL_HIGH>,
> +				<GIC_SPI 57 IRQ_TYPE_LEVEL_HIGH>;
>  			interrupt-names = "csiphy0",
>  				"csiphy1",
>  				"csid0",
>

Patch

diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi
index 51df6d37250c..03df1c2d56ef 100644
--- a/arch/arm64/boot/dts/qcom/msm8916.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi
@@ -1478,12 +1478,12 @@ 
 				"ispif",
 				"csi_clk_mux",
 				"vfe0";
-			interrupts = <GIC_SPI 78 0>,
-				<GIC_SPI 79 0>,
-				<GIC_SPI 51 0>,
-				<GIC_SPI 52 0>,
-				<GIC_SPI 55 0>,
-				<GIC_SPI 57 0>;
+			interrupts = <GIC_SPI 78 IRQ_TYPE_LEVEL_HIGH>,
+				<GIC_SPI 79 IRQ_TYPE_LEVEL_HIGH>,
+				<GIC_SPI 51 IRQ_TYPE_LEVEL_HIGH>,
+				<GIC_SPI 52 IRQ_TYPE_LEVEL_HIGH>,
+				<GIC_SPI 55 IRQ_TYPE_LEVEL_HIGH>,
+				<GIC_SPI 57 IRQ_TYPE_LEVEL_HIGH>;
 			interrupt-names = "csiphy0",
 				"csiphy1",
 				"csid0",