powerpc/rtasd: Improve unknown error logging

Message ID 20181010052302.18094-1-oohall@gmail.com
State Accepted
Commit b27e5f939b6d50e1b83e9febfee1c3f8de7789d7
Headers show
Series
  • powerpc/rtasd: Improve unknown error logging
Related show

Checks

Context Check Description
snowpatch_ozlabs/build-ppc32 success Test build-ppc32 on branch next
snowpatch_ozlabs/build-ppc64e success Test build-ppc64e on branch next
snowpatch_ozlabs/build-ppc64be success Test build-ppc64be on branch next
snowpatch_ozlabs/build-ppc64le success Test build-ppc64le on branch next
snowpatch_ozlabs/checkpatch warning Test checkpatch on branch next
snowpatch_ozlabs/apply_patch success next/apply_patch Successfully applied

Commit Message

Oliver Oct. 10, 2018, 5:23 a.m.
Currently when we get an unknown RTAS event it prints the type as
"Unknown" and no other useful information. Add the raw type code to the
log message so that we have something to work off.

Signed-off-by: Oliver O'Halloran <oohall@gmail.com>
---
 arch/powerpc/kernel/rtasd.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Comments

Vasant Hegde Oct. 10, 2018, 5:49 a.m. | #1
On 10/10/2018 10:53 AM, Oliver O'Halloran wrote:
> Currently when we get an unknown RTAS event it prints the type as
> "Unknown" and no other useful information. Add the raw type code to the
> log message so that we have something to work off.

Yeah. Useful one.

Reviewed-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com>

-Vasant

> 
> Signed-off-by: Oliver O'Halloran <oohall@gmail.com>
> ---
>   arch/powerpc/kernel/rtasd.c | 6 ++++--
>   1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/powerpc/kernel/rtasd.c b/arch/powerpc/kernel/rtasd.c
> index 44d66c33d59d..6fafc82c04b0 100644
> --- a/arch/powerpc/kernel/rtasd.c
> +++ b/arch/powerpc/kernel/rtasd.c
> @@ -150,8 +150,10 @@ static void printk_log_rtas(char *buf, int len)
>   	} else {
>   		struct rtas_error_log *errlog = (struct rtas_error_log *)buf;
> 
> -		printk(RTAS_DEBUG "event: %d, Type: %s, Severity: %d\n",
> -		       error_log_cnt, rtas_event_type(rtas_error_type(errlog)),
> +		printk(RTAS_DEBUG "event: %d, Type: %s (%d), Severity: %d\n",
> +		       error_log_cnt,
> +		       rtas_event_type(rtas_error_type(errlog)),
> +		       rtas_error_type(errlog),
>   		       rtas_error_severity(errlog));
>   	}
>   }
>
Michael Ellerman Oct. 15, 2018, 4:01 a.m. | #2
On Wed, 2018-10-10 at 05:23:02 UTC, Oliver O'Halloran wrote:
> Currently when we get an unknown RTAS event it prints the type as
> "Unknown" and no other useful information. Add the raw type code to the
> log message so that we have something to work off.
> 
> Signed-off-by: Oliver O'Halloran <oohall@gmail.com>
> Reviewed-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com>

Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/b27e5f939b6d50e1b83e9febfee1c3

cheers

Patch

diff --git a/arch/powerpc/kernel/rtasd.c b/arch/powerpc/kernel/rtasd.c
index 44d66c33d59d..6fafc82c04b0 100644
--- a/arch/powerpc/kernel/rtasd.c
+++ b/arch/powerpc/kernel/rtasd.c
@@ -150,8 +150,10 @@  static void printk_log_rtas(char *buf, int len)
 	} else {
 		struct rtas_error_log *errlog = (struct rtas_error_log *)buf;
 
-		printk(RTAS_DEBUG "event: %d, Type: %s, Severity: %d\n",
-		       error_log_cnt, rtas_event_type(rtas_error_type(errlog)),
+		printk(RTAS_DEBUG "event: %d, Type: %s (%d), Severity: %d\n",
+		       error_log_cnt,
+		       rtas_event_type(rtas_error_type(errlog)),
+		       rtas_error_type(errlog),
 		       rtas_error_severity(errlog));
 	}
 }