Patchwork rtc: Staticize non-exported __rtc_set_alarm()

login
register
mail settings
Submitter Mark Brown
Date June 1, 2011, 10:13 a.m.
Message ID <1306923196-6040-1-git-send-email-broonie@opensource.wolfsonmicro.com>
Download mbox | patch
Permalink /patch/98163/
State New
Headers show

Comments

Mark Brown - June 1, 2011, 10:13 a.m.
It's not referenced outside this file so there's no need for it to be in
the global namespace and sparse warns about that.

Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
 drivers/rtc/interface.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
John Stultz - June 2, 2011, 2:03 a.m.
On Wed, 2011-06-01 at 11:13 +0100, Mark Brown wrote:
> It's not referenced outside this file so there's no need for it to be in
> the global namespace and sparse warns about that.
> 
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>

Thanks for catching this, I've just queued it.
-john

Patch

diff --git a/drivers/rtc/interface.c b/drivers/rtc/interface.c
index ef6316a..df68618 100644
--- a/drivers/rtc/interface.c
+++ b/drivers/rtc/interface.c
@@ -318,7 +318,7 @@  int rtc_read_alarm(struct rtc_device *rtc, struct rtc_wkalrm *alarm)
 }
 EXPORT_SYMBOL_GPL(rtc_read_alarm);
 
-int __rtc_set_alarm(struct rtc_device *rtc, struct rtc_wkalrm *alarm)
+static int __rtc_set_alarm(struct rtc_device *rtc, struct rtc_wkalrm *alarm)
 {
 	struct rtc_time tm;
 	long now, scheduled;