From patchwork Wed Jun 1 07:49:06 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marc Zyngier X-Patchwork-Id: 98148 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 62F17B6F69 for ; Wed, 1 Jun 2011 18:48:50 +1000 (EST) Received: from canuck.infradead.org ([134.117.69.58]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1QRh6V-0004r0-JS; Wed, 01 Jun 2011 08:48:39 +0000 Received: from localhost ([127.0.0.1] helo=canuck.infradead.org) by canuck.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1QRh6V-0003pU-Dr; Wed, 01 Jun 2011 08:48:39 +0000 Received: from service87.mimecast.com ([94.185.240.25]) by canuck.infradead.org with smtp (Exim 4.76 #1 (Red Hat Linux)) id 1QRh6S-0003pB-93 for linux-mtd@lists.infradead.org; Wed, 01 Jun 2011 08:48:37 +0000 Received: from cam-owa2.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.21]) by service87.mimecast.com; Wed, 01 Jun 2011 08:48:17 +0100 Received: from [10.1.67.29] ([10.1.255.212]) by cam-owa2.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959); Wed, 1 Jun 2011 08:48:36 +0100 Subject: Re: [PATCH v6 1/8] MTD: Add integrator-flash feature to physmap From: Marc Zyngier To: Mike Frysinger In-Reply-To: References: <1305637877-24436-1-git-send-email-marc.zyngier@arm.com> <1305637877-24436-2-git-send-email-marc.zyngier@arm.com> <4DE53D52.4040508@ru.mvista.com> <20110531224428.6636e283@taxman.wild-wind.fr.eu.org> Organization: ARM Ltd Date: Wed, 01 Jun 2011 08:49:06 +0100 Message-ID: <1306914546.27474.349.camel@e102391-lin.cambridge.arm.com> Mime-Version: 1.0 X-Mailer: Evolution 2.28.3 X-OriginalArrivalTime: 01 Jun 2011 07:48:36.0212 (UTC) FILETIME=[50267B40:01CC2030] X-MC-Unique: 111060108481700601 X-CRM114-Version: 20090807-BlameThorstenAndJenny ( TRE 0.7.6 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20110601_044836_550162_E3A23516 X-CRM114-Status: GOOD ( 26.48 ) X-Spam-Score: -0.7 (/) X-Spam-Report: SpamAssassin version 3.3.1 on canuck.infradead.org summary: Content analysis details: (-0.7 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [94.185.240.25 listed in list.dnswl.org] Cc: David Woodhouse , linux-mtd@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Sergei Shtylyov X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-mtd-bounces@lists.infradead.org Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org On Tue, 2011-05-31 at 22:20 -0400, Mike Frysinger wrote: > On Tue, May 31, 2011 at 17:44, Marc Zyngier wrote: > > On Tue, 31 May 2011 23:11:14 +0400 Sergei Shtylyov wrote: > >> Marc Zyngier wrote: > >> > In the process of moving platforms away from integrator-flash > >> > (aka armflash), add to physmap the few features that make > >> > armflash unique: > >> > >> > - optionnal probing for the AFS partition type > >> > - init() and exit() methods, used by Integrator to control > >> > write access to the various onboard programmable components > >> > >> > Signed-off-by: Marc Zyngier > >> > Acked-by: Catalin Marinas > >> > Cc: David Woodhouse > >> [...] > >> > >> > diff --git a/include/linux/mtd/physmap.h b/include/linux/mtd/physmap.h > >> > index bcfd9f7..d37cca0 100644 > >> > --- a/include/linux/mtd/physmap.h > >> > +++ b/include/linux/mtd/physmap.h > >> > @@ -22,6 +22,8 @@ struct map_info; > >> > > >> > struct physmap_flash_data { > >> > unsigned int width; > >> > + int (*init)(struct platform_device *); > >> > + void (*exit)(struct platform_device *); > >> > >> How about a declaration for 'struct platform_device' beforehand? This breaks > >> build on other platforms at least... > > > > Sure. Please send a patch. > > uhh, what ? you broke things, so you fix them. i already pointed out > this breakage to you over a week ago. Mike, Sorry I missed your earlier comment about this. My bad. Now, about my reply to Sergei: * Sergei identified the problem, and proposed a valid fix. It's only fair he gets credited for his work (yes, you did it before he did, but I didn't know it). The SOB on a patch is the proper way of managing the attribution. * Posting a patch is the quickest way for the maintainer (in this case David) to be able to push a fix to mainline. * It also helps other folks reading the ML and facing the same issue. They can grab the patch, apply it locally and go on with their own stuff until the patch is merged. * The person reporting the problem probably has a configuration showing the problem. If any of my platforms had shown that error, I would have fixed it long before it hit the mailing list. Now, to keep everyone happy, an untested patch. David, can you please apply it? Cheers, M. >From 1440a857e119b90df68e87cf9da87fce870c86cf Mon Sep 17 00:00:00 2001 From: Marc Zyngier Date: Wed, 1 Jun 2011 08:37:28 +0100 Subject: [PATCH] MTD: Fix physmap compilation error Commit b7281ca2a4 (MTD: Add integrator-flash feature to physmap) broke some platforms by using 'struct platform_device' without declaring it. Add a forward declaration to keep everyone happy. Fix proposed by both Mike Frysinger and Sergei Shtylyov. Reported-by: Mike Frysinger Reported-by: Sergei Shtylyov Signed-off-by: Marc Zyngier --- include/linux/mtd/physmap.h | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/include/linux/mtd/physmap.h b/include/linux/mtd/physmap.h index d40bfa1..e5f21d2 100644 --- a/include/linux/mtd/physmap.h +++ b/include/linux/mtd/physmap.h @@ -19,6 +19,7 @@ #include struct map_info; +struct platform_device; struct physmap_flash_data { unsigned int width;