From patchwork Tue Oct 9 16:51:17 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Lance Taylor X-Patchwork-Id: 981415 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=gcc-patches-return-487216-incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=golang.org Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="aIZtqghq"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=golang-org.20150623.gappssmtp.com header.i=@golang-org.20150623.gappssmtp.com header.b="rrjNifJh"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 42V3Cm5BVNz9s7W for ; Wed, 10 Oct 2018 03:51:31 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:from:date:message-id:subject:to:content-type; q= dns; s=default; b=ZR7yNbXnQS05c2+Sz1lFjklU7Zrj/RIXVw9+3s+6JQT6lz bgOXToMJJ4IWXakfg4DOOrKXE0lFLfqfdZJhUGMZddM+clYcGzsbHr81gNfxcT1h aqBjrmvOVVzPlzF3aygVpiM/c1BLeEG6bjO579QbdhbAgKfs4PtRAm5JNnvvg= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:from:date:message-id:subject:to:content-type; s= default; bh=qeuho3AoIyL1Lu1ruGJ4wJwBUzA=; b=aIZtqghqcg1aSeDex2R8 KPTkX+UxvqQoic1h0eLuGtPZPKEaA9V4HYSOv42XKnBYTdLn2qhwkjql0KLGA1kt btlTZ9lFzvfjQD3176OOm43bvb9fCjCJ0YmI4y3rkxUtJskSTSZ61dbuajglxmXB RTPQx7MES1yTumCwQE9rWGw= Received: (qmail 24677 invoked by alias); 9 Oct 2018 16:51:24 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 24666 invoked by uid 89); 9 Oct 2018 16:51:23 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-11.0 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_2, GIT_PATCH_3, KAM_ASCII_DIVIDERS, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.2 spammy=zhang, Zhang, 264932, UD:T X-HELO: mail-lj1-f176.google.com Received: from mail-lj1-f176.google.com (HELO mail-lj1-f176.google.com) (209.85.208.176) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 09 Oct 2018 16:51:21 +0000 Received: by mail-lj1-f176.google.com with SMTP id v6-v6so2202834ljc.11 for ; Tue, 09 Oct 2018 09:51:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=golang-org.20150623.gappssmtp.com; s=20150623; h=mime-version:from:date:message-id:subject:to; bh=+0W0Qem6a+7rWa/pZ+O0kEZoXFBcXwglhOUAvycx+CA=; b=rrjNifJhGtoHRf2zOYAyICW/XEljaiKeakiw6OSfsnXqwQlX2BB/w8v2qrSfYoGv1v oj6aGekJTHyTZl/k4YGJ4A9WfQs7+/Ptnk9SfeFT01suK2MvHhzXZX2SdPBazULqAWqw 1gzyTQrIz3FeM5hbedo/DCD5PpAIxAQ1Hsvtg4dZNIqSlqO0GfjLLUJtQQmtL5qRmREt 6KH/DrbIdaAlxYuTfexdk25rPLxGCgh+ZNS0F+MDMKjRLvJlwrWoew7K7+AxLkTvPEKc 6rnkW9Ah06nTCbCpZJz+5+VkXA7xRO9hfwCD2Fq+YCwyn3u9AG5A/+1d3bGm1/VEhhfh TWVg== MIME-Version: 1.0 Received: by 2002:ab3:7d86:0:0:0:0:0 with HTTP; Tue, 9 Oct 2018 09:51:17 -0700 (PDT) From: Ian Lance Taylor Date: Tue, 9 Oct 2018 09:51:17 -0700 Message-ID: Subject: libgo patch committed: Skip testSetPanicOnFault when using LLVM To: gcc-patches , gofrontend-dev@googlegroups.com This patch by Cherry Zhang skips the testSetPanicOnFault tests when using gollvm. LLVM doesn't support non-call exceptions. This test was passing more or less by luck: if the faulting instruction is between two calls with the same landing pad (in instruction layout order, not the program's logic order), it generates a merged PC range that covers the faulting instruction. If the instruction layout order changes, or it uses two different (but may be degenerate) landing pads, this doesn't work. Bootstrapped and ran Go testsuite on x86_64-pc-linux-gnu. Committed to mainline. Ian Index: gcc/go/gofrontend/MERGE =================================================================== --- gcc/go/gofrontend/MERGE (revision 264932) +++ gcc/go/gofrontend/MERGE (working copy) @@ -1,4 +1,4 @@ -a9da4d34a2f878a5058f7e7d2beef52aa62471a1 +e32e9aaee598eeb43f9616cf6ca1d11acaa9d167 The first line of this file holds the git revision number of the last merge done from the gofrontend repository. Index: libgo/go/runtime/runtime_test.go =================================================================== --- libgo/go/runtime/runtime_test.go (revision 264813) +++ libgo/go/runtime/runtime_test.go (working copy) @@ -166,6 +166,9 @@ func TestSetPanicOnFault(t *testing.T) { } func testSetPanicOnFault(t *testing.T, addr uintptr, nfault *int) { + if strings.Contains(Version(), "llvm") { + t.Skip("LLVM doesn't support non-call exception") + } if GOOS == "nacl" { t.Skip("nacl doesn't seem to fault on high addresses") }