From patchwork Wed Jun 1 06:49:59 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Aneesh Kumar K.V" X-Patchwork-Id: 98130 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [140.186.70.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id D9A84B6F7A for ; Wed, 1 Jun 2011 16:52:40 +1000 (EST) Received: from localhost ([::1]:44941 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QRfIC-00081P-6B for incoming@patchwork.ozlabs.org; Wed, 01 Jun 2011 02:52:36 -0400 Received: from eggs.gnu.org ([140.186.70.92]:51490) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QRfFs-00080n-5P for qemu-devel@nongnu.org; Wed, 01 Jun 2011 02:50:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QRfFq-0000Mv-Iz for qemu-devel@nongnu.org; Wed, 01 Jun 2011 02:50:12 -0400 Received: from e28smtp06.in.ibm.com ([122.248.162.6]:55323) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QRfFp-0000EH-Gv for qemu-devel@nongnu.org; Wed, 01 Jun 2011 02:50:10 -0400 Received: from d28relay03.in.ibm.com (d28relay03.in.ibm.com [9.184.220.60]) by e28smtp06.in.ibm.com (8.14.4/8.13.1) with ESMTP id p516o0hj020548 for ; Wed, 1 Jun 2011 12:20:00 +0530 Received: from d28av05.in.ibm.com (d28av05.in.ibm.com [9.184.220.67]) by d28relay03.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p516nxNt3178568 for ; Wed, 1 Jun 2011 12:20:00 +0530 Received: from d28av05.in.ibm.com (loopback [127.0.0.1]) by d28av05.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p516nxoM012141 for ; Wed, 1 Jun 2011 16:49:59 +1000 Received: from skywalker.linux.vnet.ibm.com ([9.124.35.19]) by d28av05.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id p516nxss012132; Wed, 1 Jun 2011 16:49:59 +1000 From: "Aneesh Kumar K.V" To: Venkateswararao Jujjuri , qemu-devel@nongnu.org In-Reply-To: <4DE55D73.50806@linux.vnet.ibm.com> References: <4DB7BFDC.6050801@web.de> <1303904782-26367-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <4DE55D73.50806@linux.vnet.ibm.com> User-Agent: Notmuch/0.5-171-gcb84187 (http://notmuchmail.org) Emacs/23.2.1 (i686-pc-linux-gnu) Date: Wed, 01 Jun 2011 12:19:59 +0530 Message-ID: <87pqmycag8.fsf@linux.vnet.ibm.com> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Received-From: 122.248.162.6 Subject: Re: [Qemu-devel] [PATCH 1/3] virtio-9p: Move 9p device registration into virtio-9p.c X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org On Tue, 31 May 2011 14:28:19 -0700, Venkateswararao Jujjuri wrote: > On 04/27/2011 04:46 AM, Aneesh Kumar K.V wrote: > > This patch move the 9p device registration into its own file > > All other PCI devices registration is in this file. Not sure the need to > move 9p alone. > Also s390x doesn't support PCI..hence this breaks the s390x build. > s390 got added recently i guess, so my build didn't catch this. Fixed by the below diff. -aneesh diff --git a/Makefile.objs b/Makefile.objs index 0668e0a..2d514a7 100644 --- a/Makefile.objs +++ b/Makefile.objs @@ -45,7 +45,7 @@ net-nested-$(CONFIG_SLIRP) += slirp.o net-nested-$(CONFIG_VDE) += vde.o net-obj-y += $(addprefix net/, $(net-nested-y)) -ifeq ($(CONFIG_VIRTIO)$(CONFIG_VIRTFS),yy) +ifeq ($(CONFIG_VIRTIO)$(CONFIG_VIRTFS)$(CONFIG_PCI),yyy) # Lots of the fsdev/9pcode is pulled in by vl.c via qemu_fsdev_add. # only pull in the actual virtio-9p device