PCI:mobiveil: fix multi function endpoint failures

Message ID 1539083325-7333-1-git-send-email-l.subrahmanya@mobiveil.co.in
State Changes Requested
Delegated to: Lorenzo Pieralisi
Headers show
Series
  • PCI:mobiveil: fix multi function endpoint failures
Related show

Commit Message

Subrahmanya Lingappa Oct. 9, 2018, 11:08 a.m.
The fix enables mobiveil pcie controller to detect more than one
functions per device.

Signed-off-by: Subrahmanya Lingappa <l.subrahmanya@mobiveil.co.in>
---
 drivers/pci/controller/pcie-mobiveil.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Lorenzo Pieralisi Oct. 11, 2018, 2:20 p.m. | #1
On Tue, Oct 09, 2018 at 07:08:45AM -0400, Subrahmanya Lingappa wrote:
> The fix enables mobiveil pcie controller to detect more than one
> functions per device.

Please read:

https://marc.info/?l=linux-pci&m=150905742808166&w=2

and use it as a checklist.

Please run:

git log --oneline drivers/pci/controller/pcie-mobiveil.c

Check the result and compare it to your patch $SUBJECT, you will
notice that this patch style differs so rewrite the $SUBJECT accordingly.

Please add a Fixes: tag to define what commit you are fixing.

Thanks,
Lorenzo

> Signed-off-by: Subrahmanya Lingappa <l.subrahmanya@mobiveil.co.in>
> ---
>  drivers/pci/controller/pcie-mobiveil.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/controller/pcie-mobiveil.c b/drivers/pci/controller/pcie-mobiveil.c
> index a939e8d3..9acb81a 100644
> --- a/drivers/pci/controller/pcie-mobiveil.c
> +++ b/drivers/pci/controller/pcie-mobiveil.c
> @@ -174,7 +174,7 @@ static bool mobiveil_pcie_valid_device(struct pci_bus *bus, unsigned int devfn)
>  	 * Do not read more than one device on the bus directly
>  	 * attached to RC
>  	 */
> -	if ((bus->primary == pcie->root_bus_nr) && (devfn > 0))
> +	if ((bus->number == pcie->root_bus_nr) && (devfn > 0))
>  		return false;
>  
>  	return true;
> -- 
> 1.8.3.1
>

Patch

diff --git a/drivers/pci/controller/pcie-mobiveil.c b/drivers/pci/controller/pcie-mobiveil.c
index a939e8d3..9acb81a 100644
--- a/drivers/pci/controller/pcie-mobiveil.c
+++ b/drivers/pci/controller/pcie-mobiveil.c
@@ -174,7 +174,7 @@  static bool mobiveil_pcie_valid_device(struct pci_bus *bus, unsigned int devfn)
 	 * Do not read more than one device on the bus directly
 	 * attached to RC
 	 */
-	if ((bus->primary == pcie->root_bus_nr) && (devfn > 0))
+	if ((bus->number == pcie->root_bus_nr) && (devfn > 0))
 		return false;
 
 	return true;