diff mbox series

[U-Boot,03/14] mips: mt76xx: Enable SYS_MIPS_CACHE_INIT_RAM_LOAD for cache init

Message ID 20181009065916.31977-3-sr@denx.de
State Deferred
Delegated to: Daniel Schwierzeck
Headers show
Series [U-Boot,01/14] mips: Add in_le32(), out_le32() etc IO accessor functions | expand

Commit Message

Stefan Roese Oct. 9, 2018, 6:59 a.m. UTC
Using CONFIG_SYS_MIPS_CACHE_INIT_RAM_LOAD should ensure that the cache
is initialized correctly (parity etc). Even though some issues are
still seen on the linkit and gardena MT7688 platforms, which could
be a result of a non-optimal cache configuration / setup.

Signed-off-by: Stefan Roese <sr@denx.de>
Cc: Daniel Schwierzeck <daniel.schwierzeck@gmail.com>
---
 arch/mips/mach-mt7620/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Daniel Schwierzeck Oct. 28, 2018, 7:02 p.m. UTC | #1
Am 09.10.18 um 08:59 schrieb Stefan Roese:
> Using CONFIG_SYS_MIPS_CACHE_INIT_RAM_LOAD should ensure that the cache
> is initialized correctly (parity etc). Even though some issues are
> still seen on the linkit and gardena MT7688 platforms, which could
> be a result of a non-optimal cache configuration / setup.

I thought this doesn't really help? Also if you can't move
CONFIG_MIPS_CACHE_INDEX_BASE to some SRAM space, you need to run your
memory init code before the cache initialisation to have working DRAM
available. But this slows down the boot time.

> 
> Signed-off-by: Stefan Roese <sr@denx.de>
> Cc: Daniel Schwierzeck <daniel.schwierzeck@gmail.com>
> ---
>  arch/mips/mach-mt7620/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/mips/mach-mt7620/Kconfig b/arch/mips/mach-mt7620/Kconfig
> index 13a7bd2cc0..e42d918ba0 100644
> --- a/arch/mips/mach-mt7620/Kconfig
> +++ b/arch/mips/mach-mt7620/Kconfig
> @@ -13,6 +13,7 @@ choice
>  config SOC_MT7620
>  	bool "MT7620/8"
>  	select MIPS_L1_CACHE_SHIFT_5
> +	select SYS_MIPS_CACHE_INIT_RAM_LOAD
>  	help
>  	  This supports MediaTek MIPS MT7620 family.
>  
>
diff mbox series

Patch

diff --git a/arch/mips/mach-mt7620/Kconfig b/arch/mips/mach-mt7620/Kconfig
index 13a7bd2cc0..e42d918ba0 100644
--- a/arch/mips/mach-mt7620/Kconfig
+++ b/arch/mips/mach-mt7620/Kconfig
@@ -13,6 +13,7 @@  choice
 config SOC_MT7620
 	bool "MT7620/8"
 	select MIPS_L1_CACHE_SHIFT_5
+	select SYS_MIPS_CACHE_INIT_RAM_LOAD
 	help
 	  This supports MediaTek MIPS MT7620 family.