PM / AVS: SmartReflex: Fix module licence specification

Message ID 20181008091818.1145-1-uwe@kleine-koenig.org
State New
Headers show
Series
  • PM / AVS: SmartReflex: Fix module licence specification
Related show

Commit Message

Uwe Kleine-König Oct. 8, 2018, 9:18 a.m.
The header of this file claims "version 2" and not "or later". So adapt
the module licence specification accordingly.

Signed-off-by: Uwe Kleine-König <uwe@kleine-koenig.org>
---
 drivers/power/avs/smartreflex.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Rafael J. Wysocki Oct. 9, 2018, 7:56 a.m. | #1
On Mon, Oct 8, 2018 at 11:23 AM Uwe Kleine-König <uwe@kleine-koenig.org> wrote:
>
> The header of this file claims "version 2" and not "or later". So adapt
> the module licence specification accordingly.
>
> Signed-off-by: Uwe Kleine-König <uwe@kleine-koenig.org>
> ---
>  drivers/power/avs/smartreflex.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/power/avs/smartreflex.c b/drivers/power/avs/smartreflex.c
> index d29b6313cafc..9ed30b5d32c2 100644
> --- a/drivers/power/avs/smartreflex.c
> +++ b/drivers/power/avs/smartreflex.c
> @@ -1062,6 +1062,6 @@ static void __exit sr_exit(void)
>  module_exit(sr_exit);
>
>  MODULE_DESCRIPTION("OMAP Smartreflex Driver");
> -MODULE_LICENSE("GPL");
> +MODULE_LICENSE("GPL v2");
>  MODULE_ALIAS("platform:" DRIVER_NAME);
>  MODULE_AUTHOR("Texas Instruments Inc");
> --

While you are at it, why don't you add a proper SPDX license ID to
this file and drop the license bolierplate from the heading comment?
Uwe Kleine-König Dec. 4, 2018, 8:15 p.m. | #2
Hello Rafael,

On Tue, Oct 09, 2018 at 09:56:52AM +0200, Rafael J. Wysocki wrote:
> On Mon, Oct 8, 2018 at 11:23 AM Uwe Kleine-König <uwe@kleine-koenig.org> wrote:
> >
> > The header of this file claims "version 2" and not "or later". So adapt
> > the module licence specification accordingly.
> >
> > Signed-off-by: Uwe Kleine-König <uwe@kleine-koenig.org>
> > ---
> >  drivers/power/avs/smartreflex.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/power/avs/smartreflex.c b/drivers/power/avs/smartreflex.c
> > index d29b6313cafc..9ed30b5d32c2 100644
> > --- a/drivers/power/avs/smartreflex.c
> > +++ b/drivers/power/avs/smartreflex.c
> > @@ -1062,6 +1062,6 @@ static void __exit sr_exit(void)
> >  module_exit(sr_exit);
> >
> >  MODULE_DESCRIPTION("OMAP Smartreflex Driver");
> > -MODULE_LICENSE("GPL");
> > +MODULE_LICENSE("GPL v2");
> >  MODULE_ALIAS("platform:" DRIVER_NAME);
> >  MODULE_AUTHOR("Texas Instruments Inc");
> > --
> 
> While you are at it, why don't you add a proper SPDX license ID to
> this file and drop the license bolierplate from the heading comment?

That would be a separate patch, right? And in contrast to this one
(which is a fix IMHO) it would only be an "improvement".

As this was just a drive-by change I won't follow up on this one. Take
it as is or don't.

Best regards
Uwe

Patch

diff --git a/drivers/power/avs/smartreflex.c b/drivers/power/avs/smartreflex.c
index d29b6313cafc..9ed30b5d32c2 100644
--- a/drivers/power/avs/smartreflex.c
+++ b/drivers/power/avs/smartreflex.c
@@ -1062,6 +1062,6 @@  static void __exit sr_exit(void)
 module_exit(sr_exit);
 
 MODULE_DESCRIPTION("OMAP Smartreflex Driver");
-MODULE_LICENSE("GPL");
+MODULE_LICENSE("GPL v2");
 MODULE_ALIAS("platform:" DRIVER_NAME);
 MODULE_AUTHOR("Texas Instruments Inc");