[nf-next] netfilter: nf_nat_snmp_basic: add missing helper alias name

Message ID 20181006151707.30068-1-ap420073@gmail.com
State Accepted
Delegated to: Pablo Neira
Headers show
Series
  • [nf-next] netfilter: nf_nat_snmp_basic: add missing helper alias name
Related show

Commit Message

Taehee Yoo Oct. 6, 2018, 3:17 p.m.
In order to upload helper module automatically, helper alias name
is needed. so that MODULE_ALIAS_NFCT_HELPER() should be added.
And unlike other nat helper modules, the nf_nat_snmp_basic can be
used independently.
helper name is "snmp_trap" so that alias name will be
"nfct-helper-snmp_trap" by MODULE_ALIAS_NFCT_HELPER(snmp_trap)

test command:
   %iptables -t raw -I PREROUTING -p udp -j CT --helper snmp_trap
   %lsmod | grep nf_nat_snmp_basic

We can see nf_nat_snmp_basic module is uploaded automatically.

Signed-off-by: Taehee Yoo <ap420073@gmail.com>
---
 net/ipv4/netfilter/nf_nat_snmp_basic_main.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Pablo Neira Ayuso Oct. 15, 2018, 12:41 p.m. | #1
On Sun, Oct 07, 2018 at 12:17:07AM +0900, Taehee Yoo wrote:
> In order to upload helper module automatically, helper alias name
> is needed. so that MODULE_ALIAS_NFCT_HELPER() should be added.
> And unlike other nat helper modules, the nf_nat_snmp_basic can be
> used independently.
> helper name is "snmp_trap" so that alias name will be
> "nfct-helper-snmp_trap" by MODULE_ALIAS_NFCT_HELPER(snmp_trap)
> 
> test command:
>    %iptables -t raw -I PREROUTING -p udp -j CT --helper snmp_trap
>    %lsmod | grep nf_nat_snmp_basic
> 
> We can see nf_nat_snmp_basic module is uploaded automatically.

Applied, thanks.

Patch

diff --git a/net/ipv4/netfilter/nf_nat_snmp_basic_main.c b/net/ipv4/netfilter/nf_nat_snmp_basic_main.c
index ac110c1d55b5..a0aa13bcabda 100644
--- a/net/ipv4/netfilter/nf_nat_snmp_basic_main.c
+++ b/net/ipv4/netfilter/nf_nat_snmp_basic_main.c
@@ -60,6 +60,7 @@  MODULE_LICENSE("GPL");
 MODULE_AUTHOR("James Morris <jmorris@intercode.com.au>");
 MODULE_DESCRIPTION("Basic SNMP Application Layer Gateway");
 MODULE_ALIAS("ip_nat_snmp_basic");
+MODULE_ALIAS_NFCT_HELPER("snmp_trap");
 
 #define SNMP_PORT 161
 #define SNMP_TRAP_PORT 162