| Message ID | 20181005214507.26315-2-jae.hyun.yoo@linux.intel.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | i2c: aspeed: Add bus idle waiting logic for multi-master use cases | expand |
On Fri, 5 Oct 2018 14:45:03 -0700, Jae Hyun Yoo wrote: > This commit adds 'bus-timeout-ms' and '#retries' properties as > common optional properties that can be used for setting 'timeout' > and 'retries' values of 'struct i2c_adapter'. With this patch, the > bus timeout value and the master transfer retries count can be set > through these properties at the registration time of an adapter. > Still the values can be set by I2C_TIMEOUT and I2C_RETRIES ioctls > on cdev at runtime too. > > These properties may not be supported by all drivers. However, if > a driver wants to support one of them, it should adapt the > bindings in this document. > > Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com> > --- > Documentation/devicetree/bindings/i2c/i2c.txt | 6 ++++++ > 1 file changed, 6 insertions(+) > Reviewed-by: Rob Herring <robh@kernel.org>
On 10/11/2018 3:11 PM, Rob Herring wrote: > > Reviewed-by: Rob Herring <robh@kernel.org> > Thanks for the review, Rob!
diff --git a/Documentation/devicetree/bindings/i2c/i2c.txt b/Documentation/devicetree/bindings/i2c/i2c.txt index 11263982470e..bdead91f82a4 100644 --- a/Documentation/devicetree/bindings/i2c/i2c.txt +++ b/Documentation/devicetree/bindings/i2c/i2c.txt @@ -80,6 +80,12 @@ wants to support one of the below features, it should adapt the bindings below. Names of map programmable addresses. It can contain any map needing another address than default one. +- bus-timeout-ms + Bus timeout in milliseconds. + +- #retries + Number of retries for master transfer. + Binding may contain optional "interrupts" property, describing interrupts used by the device. I2C core will assign "irq" interrupt (or the very first interrupt if not using interrupt names) as primary interrupt for the slave.
This commit adds 'bus-timeout-ms' and '#retries' properties as common optional properties that can be used for setting 'timeout' and 'retries' values of 'struct i2c_adapter'. With this patch, the bus timeout value and the master transfer retries count can be set through these properties at the registration time of an adapter. Still the values can be set by I2C_TIMEOUT and I2C_RETRIES ioctls on cdev at runtime too. These properties may not be supported by all drivers. However, if a driver wants to support one of them, it should adapt the bindings in this document. Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com> --- Documentation/devicetree/bindings/i2c/i2c.txt | 6 ++++++ 1 file changed, 6 insertions(+)