[v3,3/4] pdbg/gdbserver: Make gdbserver optional

Message ID 20181005034254.890-4-rashmica.g@gmail.com
State New
Headers show
Series
  • Basic gdbserver for POWER8
Related show

Checks

Context Check Description
snowpatch_ozlabs/build-multiarch fail Test build-multiarch on branch master
snowpatch_ozlabs/apply_patch success master/apply_patch Successfully applied

Commit Message

Rashmica Gupta Oct. 5, 2018, 3:42 a.m.
Signed-off-by: Rashmica Gupta <rashmica.g@gmail.com>
---
 Makefile.am     | 21 +++++++++++----------
 configure.ac    |  6 ++++++
 src/pdbgproxy.c |  9 +++++++++
 3 files changed, 26 insertions(+), 10 deletions(-)

Patch

diff --git a/Makefile.am b/Makefile.am
index a476b87..581419c 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -84,14 +84,17 @@  pdbg_SOURCES = \
 	src/parsers.c \
 	src/optcmd.c \
 	src/options_@ARCH@.c \
-	src/htm.h \
-	src/main.h \
-	src/optcmd.h \
-	src/options.h \
-	src/parsers.h \
-	src/progress.h \
-	src/pdbgproxy.c \
-	src/gdb_parser.c
+	src/pdbgproxy.c
+
+pdbg_CFLAGS = -I$(top_srcdir)/libpdbg -Wall -Werror -DGIT_SHA1=\"${GIT_SHA1}\" \
+	      $(ARCH_FLAGS)
+
+if GDBSERVER
+pdbg_SOURCES += \
+	$(extra_sources)
+else
+pdbg_CFLAGS += -DDISABLE_GDBSERVER
+endif
 
 src/main.c: $(DT_headers)
 
@@ -99,8 +102,6 @@  pdbg_LDADD = $(DT_objects) libpdbg.la libfdt.la libccan.a \
 	-L.libs -lrt
 
 pdbg_LDFLAGS = -Wl,--whole-archive,-lpdbg,--no-whole-archive
-pdbg_CFLAGS = -I$(top_srcdir)/libpdbg -Wall -Werror -DGIT_SHA1=\"${GIT_SHA1}\" \
-	      $(ARCH_FLAGS)
 
 lib_LTLIBRARIES = libpdbg.la libfdt.la
 
diff --git a/configure.ac b/configure.ac
index 7cfd2ea..24440ac 100644
--- a/configure.ac
+++ b/configure.ac
@@ -36,4 +36,10 @@  AC_SUBST([ARCH])
 AM_CONDITIONAL([TARGET_ARM], [test x"$ARCH" = "xarm"])
 AM_CONDITIONAL([TARGET_PPC], [test x"$ARCH" = "xppc"])
 
+AC_ARG_ENABLE(gdbserver,
+AC_HELP_STRING([--disable-gdbserver], [disables building the gdbserver]),
+want_gdbserver=false,
+want_gdbserver=true)
+AM_CONDITIONAL([GDBSERVER], [test x$want_gdbserver = xtrue])
+
 AC_OUTPUT
diff --git a/src/pdbgproxy.c b/src/pdbgproxy.c
index 1ec66d6..3d1fdc7 100644
--- a/src/pdbgproxy.c
+++ b/src/pdbgproxy.c
@@ -25,6 +25,8 @@ 
 #include "debug.h"
 #include "chip.h"
 
+#ifndef DISABLE_GDBSERVER
+
 /* Maximum packet size */
 #define BUFFER_SIZE    	8192
 
@@ -544,4 +546,11 @@  static int gdbserver(uint16_t port)
 	gdbserver_start(target, port);
 	return 0;
 }
+#else
+
+static int gdbserver(uint16_t port)
+{
+	return 0;
+}
+#endif
 OPTCMD_DEFINE_CMD_WITH_ARGS(gdbserver, gdbserver, (DATA16));