| Message ID | 73a25549dfd4206b53f5fd8e98f789b20ac861a4.1538652143.git.tgolembi@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | qga: report serial number and disk node | expand |
Hi On Thu, Oct 4, 2018 at 3:22 PM Tomáš Golembiovský <tgolembi@redhat.com> wrote: > > There was inconsistency between commits: > > 50cbebb9a3 configure: add configure check for ntdddisk.h > a3ef3b2272 qga: added bus type and disk location path > > The first commit added #define CONFIG_QGA_NTDDDISK but the second commit > expected the name to be CONFIG_QGA_NTDDSCSI. As a result the code in > second patch was never used. > > Renaming the option to CONFIG_QGA_NTDDSCSI to match the name of header > file that is being checked for. > > Signed-off-by: Tomáš Golembiovský <tgolembi@redhat.com> Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com> > --- > configure | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure b/configure > index 58862d2ae8..0f168607e8 100755 > --- a/configure > +++ b/configure > @@ -6201,7 +6201,7 @@ if test "$mingw32" = "yes" ; then > echo "WIN_SDK=\"$win_sdk\"" >> $config_host_mak > fi > if test "$guest_agent_ntddscsi" = "yes" ; then > - echo "CONFIG_QGA_NTDDDISK=y" >> $config_host_mak > + echo "CONFIG_QGA_NTDDSCSI=y" >> $config_host_mak > fi > if test "$guest_agent_msi" = "yes"; then > echo "QEMU_GA_MSI_ENABLED=yes" >> $config_host_mak > -- > 2.19.0 >
Reviewed-by: Sameeh Jubran <sjubran@redhat.com> On Thu, Oct 4, 2018 at 4:23 PM Marc-André Lureau <marcandre.lureau@redhat.com> wrote: > > Hi > > On Thu, Oct 4, 2018 at 3:22 PM Tomáš Golembiovský <tgolembi@redhat.com> wrote: > > > > There was inconsistency between commits: > > > > 50cbebb9a3 configure: add configure check for ntdddisk.h > > a3ef3b2272 qga: added bus type and disk location path > > > > The first commit added #define CONFIG_QGA_NTDDDISK but the second commit > > expected the name to be CONFIG_QGA_NTDDSCSI. As a result the code in > > second patch was never used. > > > > Renaming the option to CONFIG_QGA_NTDDSCSI to match the name of header > > file that is being checked for. > > > > Signed-off-by: Tomáš Golembiovský <tgolembi@redhat.com> > > Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com> > > > --- > > configure | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/configure b/configure > > index 58862d2ae8..0f168607e8 100755 > > --- a/configure > > +++ b/configure > > @@ -6201,7 +6201,7 @@ if test "$mingw32" = "yes" ; then > > echo "WIN_SDK=\"$win_sdk\"" >> $config_host_mak > > fi > > if test "$guest_agent_ntddscsi" = "yes" ; then > > - echo "CONFIG_QGA_NTDDDISK=y" >> $config_host_mak > > + echo "CONFIG_QGA_NTDDSCSI=y" >> $config_host_mak > > fi > > if test "$guest_agent_msi" = "yes"; then > > echo "QEMU_GA_MSI_ENABLED=yes" >> $config_host_mak > > -- > > 2.19.0 > > >
diff --git a/configure b/configure index 58862d2ae8..0f168607e8 100755 --- a/configure +++ b/configure @@ -6201,7 +6201,7 @@ if test "$mingw32" = "yes" ; then echo "WIN_SDK=\"$win_sdk\"" >> $config_host_mak fi if test "$guest_agent_ntddscsi" = "yes" ; then - echo "CONFIG_QGA_NTDDDISK=y" >> $config_host_mak + echo "CONFIG_QGA_NTDDSCSI=y" >> $config_host_mak fi if test "$guest_agent_msi" = "yes"; then echo "QEMU_GA_MSI_ENABLED=yes" >> $config_host_mak
There was inconsistency between commits: 50cbebb9a3 configure: add configure check for ntdddisk.h a3ef3b2272 qga: added bus type and disk location path The first commit added #define CONFIG_QGA_NTDDDISK but the second commit expected the name to be CONFIG_QGA_NTDDSCSI. As a result the code in second patch was never used. Renaming the option to CONFIG_QGA_NTDDSCSI to match the name of header file that is being checked for. Signed-off-by: Tomáš Golembiovský <tgolembi@redhat.com> --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)