From patchwork Mon May 30 07:13:32 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Connor Hansen X-Patchwork-Id: 97869 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 12F06B6F6E for ; Mon, 30 May 2011 17:13:40 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754263Ab1E3HNi (ORCPT ); Mon, 30 May 2011 03:13:38 -0400 Received: from mail-pv0-f174.google.com ([74.125.83.174]:53891 "EHLO mail-pv0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753585Ab1E3HNh (ORCPT ); Mon, 30 May 2011 03:13:37 -0400 Received: by pvg12 with SMTP id 12so1499260pvg.19 for ; Mon, 30 May 2011 00:13:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:from:to:cc:subject:date:message-id:x-mailer :mime-version:content-type:content-transfer-encoding; bh=SejSYNw6PqHmz2U1/agNaHssqYwc6yHoaPGswLT24rE=; b=cSe+4KelGPq1nDBJYyue2htOWLmu6pnePuyCzgbgpBvV0n5kK2uqqkWDzLJBeZPP9y jYgwkqiEWRUm/SO89lkJdgz0lH6phss0nU79WzwoLI7vYZDZkOzYJ4VHAWwQj5XDUe8P gH1zj0Jhf1hXNqVTd9rkECYknx+XbsKa+QgOU= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer:mime-version :content-type:content-transfer-encoding; b=MjpTZYEV+GM71HPBt8G1OLO3tiWOCkf8MH9+NswNPvam6Ew8O7+zLExc07GxMihrW8 9CRfwAc43z79HE9WgN3nqZch/dryGdWqztqbxOsbplIUCAu43VBdKxo3nNMTAkXZ+D+I lAhXPQrbfXb5w0OT8PGl8fMOYshygl+crzbfU= Received: by 10.68.49.40 with SMTP id r8mr2018999pbn.109.1306739617469; Mon, 30 May 2011 00:13:37 -0700 (PDT) Received: from localhost.localdomain (c-71-197-87-91.hsd1.ca.comcast.net [71.197.87.91]) by mx.google.com with ESMTPS id b8sm2656311pbj.78.2011.05.30.00.13.36 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 30 May 2011 00:13:37 -0700 (PDT) From: Connor Hansen To: "David S. Miller" Cc: Borislav Petkov , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, Connor Hansen Subject: [PATCH 1/2] ide-cd: Fix signedness warning Date: Mon, 30 May 2011 00:13:32 -0700 Message-Id: <1306739612-29239-1-git-send-email-cmdkhh@gmail.com> X-Mailer: git-send-email 1.7.4.4 MIME-Version: 1.0 Sender: linux-ide-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org One of the legit warnings 'make W=3 drivers/ide/ide-cd.o´ generates is drivers/ide/ide-cd.c: In function .ide_cdrom_prep_fs.: drivers/ide/ide-cd.c:1314: warning: conversion to .unsigned int. from .int. may change the sign of the result because queue_logical_block_size() returns unsigned short but hard_sect is defined as int. Fix that no matter how low the potential for this becoming a bug is. Signed-off-by: Connor Hansen --- drivers/ide/ide-cd.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/ide/ide-cd.c b/drivers/ide/ide-cd.c index 6e5123b..c1de54a 100644 --- a/drivers/ide/ide-cd.c +++ b/drivers/ide/ide-cd.c @@ -1309,7 +1309,7 @@ static int ide_cdrom_probe_capabilities(ide_drive_t *drive) /* standard prep_rq_fn that builds 10 byte cmds */ static int ide_cdrom_prep_fs(struct request_queue *q, struct request *rq) { - int hard_sect = queue_logical_block_size(q); + unsigned short hard_sect = queue_logical_block_size(q); long block = (long)blk_rq_pos(rq) / (hard_sect >> 9); unsigned long blocks = blk_rq_sectors(rq) / (hard_sect >> 9);