diff mbox

[V2,3/3] Remove warning in printf due to type mismatch

Message ID 1306707770-14632-4-git-send-email-cerbere@gmail.com
State New
Headers show

Commit Message

Alexandre Raymond May 29, 2011, 10:22 p.m. UTC
----8<----
qemu/target-lm32/translate.c: In function ‘gen_intermediate_code_internal’:
qemu/target-lm32/translate.c:1135: warning: format ‘%zd’ expects type ‘signed size_t’, but argument 4 has type ‘int’
----8<----

Both gen_opc_ptr and gen_opc_buf are "uint16_t *". The difference between
pointers is a ptrdiff_t so printf needs '%td'.

Signed-off-by: Alexandre Raymond <cerbere@gmail.com>
---
 target-lm32/translate.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Comments

Andreas Färber June 1, 2011, 9:13 p.m. UTC | #1
Markus, Stefan,

Am 30.05.2011 um 00:22 schrieb Alexandre Raymond:

> ----8<----
> qemu/target-lm32/translate.c: In function  
> ‘gen_intermediate_code_internal’:
> qemu/target-lm32/translate.c:1135: warning: format ‘%zd’ expects  
> type ‘signed size_t’, but argument 4 has type ‘int’
> ----8<----
>
> Both gen_opc_ptr and gen_opc_buf are "uint16_t *". The difference  
> between
> pointers is a ptrdiff_t so printf needs '%td'.
>
> Signed-off-by: Alexandre Raymond <cerbere@gmail.com>

You suggested the use of t, are you planning to ack it?

Andreas

> ---
> target-lm32/translate.c |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/target-lm32/translate.c b/target-lm32/translate.c
> index eb21158..5e19725 100644
> --- a/target-lm32/translate.c
> +++ b/target-lm32/translate.c
> @@ -1132,7 +1132,7 @@ static void  
> gen_intermediate_code_internal(CPUState *env,
>     if (qemu_loglevel_mask(CPU_LOG_TB_IN_ASM)) {
>         qemu_log("\n");
>         log_target_disas(pc_start, dc->pc - pc_start, 0);
> -        qemu_log("\nisize=%d osize=%zd\n",
> +        qemu_log("\nisize=%d osize=%td\n",
>             dc->pc - pc_start, gen_opc_ptr - gen_opc_buf);
>     }
> #endif
> -- 
> 1.7.5
>
>
Stefan Weil June 2, 2011, 7:18 a.m. UTC | #2
Am 30.05.2011 00:22, schrieb Alexandre Raymond:
> ----8<----
> qemu/target-lm32/translate.c: In function 
> ‘gen_intermediate_code_internal’:
> qemu/target-lm32/translate.c:1135: warning: format ‘%zd’ expects type 
> ‘signed size_t’, but argument 4 has type ‘int’
> ----8<----
>
> Both gen_opc_ptr and gen_opc_buf are "uint16_t *". The difference between
> pointers is a ptrdiff_t so printf needs '%td'.
>
> Signed-off-by: Alexandre Raymond <cerbere@gmail.com>
> ---
> target-lm32/translate.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/target-lm32/translate.c b/target-lm32/translate.c
> index eb21158..5e19725 100644
> --- a/target-lm32/translate.c
> +++ b/target-lm32/translate.c
> @@ -1132,7 +1132,7 @@ static void 
> gen_intermediate_code_internal(CPUState *env,
> if (qemu_loglevel_mask(CPU_LOG_TB_IN_ASM)) {
> qemu_log("\n");
> log_target_disas(pc_start, dc->pc - pc_start, 0);
> - qemu_log("\nisize=%d osize=%zd\n",
> + qemu_log("\nisize=%d osize=%td\n",
> dc->pc - pc_start, gen_opc_ptr - gen_opc_buf);
> }
> #endif

Acked-by: Stefan Weil <weil@mail.berlios.de>
diff mbox

Patch

diff --git a/target-lm32/translate.c b/target-lm32/translate.c
index eb21158..5e19725 100644
--- a/target-lm32/translate.c
+++ b/target-lm32/translate.c
@@ -1132,7 +1132,7 @@  static void gen_intermediate_code_internal(CPUState *env,
     if (qemu_loglevel_mask(CPU_LOG_TB_IN_ASM)) {
         qemu_log("\n");
         log_target_disas(pc_start, dc->pc - pc_start, 0);
-        qemu_log("\nisize=%d osize=%zd\n",
+        qemu_log("\nisize=%d osize=%td\n",
             dc->pc - pc_start, gen_opc_ptr - gen_opc_buf);
     }
 #endif