[COMMITTED] kl_GL: Fix spelling of Sunday, should be "sapaat" (bug 20209).

Message ID 739179024.735093.1538519122756@poczta.nazwa.pl
State New
Headers show
Series
  • [COMMITTED] kl_GL: Fix spelling of Sunday, should be "sapaat" (bug 20209).
Related show

Commit Message

Rafal Luzynski Oct. 2, 2018, 10:25 p.m.
I have pushed this as the change is trivial and confirmed by Oqaasileriffik,
the official Greenlandic language regulator.

My question is: is it OK to backport this change to 2.28? Carlos?

Regards,

Rafal

Comments

Carlos O'Donell Oct. 4, 2018, 3:49 a.m. | #1
On 10/2/18 6:25 PM, Rafal Luzynski wrote:
> I have pushed this as the change is trivial and confirmed by Oqaasileriffik,
> the official Greenlandic language regulator.
> 
> My question is: is it OK to backport this change to 2.28? Carlos?

There could be existing UI's designed for 2.28 with the width of the spelling 
taken into account. Here because the width is the same I think we're OK.

In the past I have backported whole *new* locales to RHEL, and that's been fine
because we weren't changing existing locales.

However, changing collation, or making strings significantly longer can cause
problems. This is note the case here.

I think this case is OK for backport to 2.28.
Rafal Luzynski Oct. 4, 2018, 10:06 a.m. | #2
4.10.2018 05:49 Carlos O'Donell <carlos@redhat.com> wrote:
> [...]
> There could be existing UI's designed for 2.28 with the width of the spelling
> taken into account. Here because the width is the same I think we're OK.
>
> In the past I have backported whole *new* locales to RHEL, and that's been
> fine
> because we weren't changing existing locales.
>
> However, changing collation, or making strings significantly longer can cause
> problems. This is note the case here.
>
> I think this case is OK for backport to 2.28.

Thank you for explaining, Carlos.  I will have another patch for kl_GL so I'm
not backporting this now, I'd rather backport them both in a bundle.  Of course,
I will ask about your opinion first.

Regards,

Rafal

Patch

From ece13abb662414906d88c7d26872cb7b494187f6 Mon Sep 17 00:00:00 2001
From: Rafal Luzynski <digitalfreak@lingonborough.com>
Date: Tue, 2 Oct 2018 23:34:18 +0200
Subject: [PATCH] kl_GL: Fix spelling of Sunday, should be "sapaat" (bug
 20209).

Although CLDR says otherwise, it is confirmed by Oqaasileriffik, the
official Greenlandic language regulator, that this change is correct.

	[BZ #20209]
	* localedata/locales/kl_GL: (abday): Fix spelling of Sun (Sunday),
	should be "sap" rather than "sab".
	(day): Fix spelling of Sunday, should be "sapaat" rather than
	"sabaat".
---
 localedata/locales/kl_GL | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/localedata/locales/kl_GL b/localedata/locales/kl_GL
index 5ab14a3..5723ce7 100644
--- a/localedata/locales/kl_GL
+++ b/localedata/locales/kl_GL
@@ -70,11 +70,11 @@  copy "da_DK"
 END LC_NUMERIC
 
 LC_TIME
-abday    "sab";"ata";/
+abday    "sap";"ata";/
          "mar";"pin";/
          "sis";"tal";/
          "arf"
-day      "sabaat";/
+day      "sapaat";/
          "ataasinngorneq";/
          "marlunngorneq";/
          "pingasunngorneq";/
-- 
2.7.5